Added bounds checking to memcpy and use memory-safe strlcpy (#6351)

* Added bounds checking to memcpy and use memory-safe strlcpy for reading serial data in processWXSerial() function.

* Fixed linting with trunk

src/modules/SerialModule.cpp

@@ -468,6 +468,7 @@ void SerialModule::processWXSerial()
                     // Extract the current line
                     char line[meshtastic_Constants_DATA_PAYLOAD_LEN];
                     memset(line, '\0', sizeof(line));
+                    if (lineEnd - lineStart < sizeof(line) - 1) {
                         memcpy(line, &serialBytes[lineStart], lineEnd - lineStart);
                         if (strstr(line, "Wind") != NULL) // we have a wind line
                         {
@@ -479,14 +480,14 @@ void SerialModule::processWXSerial()
 
                             if (windDirPos != NULL) {
                                 // Extract data after "=" for WindDir
-                            strcpy(windDir, windDirPos + 15); // Add 15 to skip "WindDir = "
+                                strlcpy(windDir, windDirPos + 15, sizeof(windDir)); // Add 15 to skip "WindDir = "
                                 double radians = GeoCoord::toRadians(strtof(windDir, nullptr));
                                 dir_sum_sin += sin(radians);
                                 dir_sum_cos += cos(radians);
                                 dirCount++;
                             } else if (windSpeedPos != NULL) {
                                 // Extract data after "=" for WindSpeed
-                            strcpy(windVel, windSpeedPos + 15); // Add 15 to skip "WindSpeed = "
+                                strlcpy(windVel, windSpeedPos + 15, sizeof(windVel)); // Add 15 to skip "WindSpeed = "
                                 float newv = strtof(windVel, nullptr);
                                 velSum += newv;
                                 velCount++;
@@ -494,7 +495,7 @@ void SerialModule::processWXSerial()
                                     lull = newv;
 
                             } else if (windGustPos != NULL) {
-                            strcpy(windGust, windGustPos + 15); // Add 15 to skip "WindSpeed = "
+                                strlcpy(windGust, windGustPos + 15, sizeof(windGust)); // Add 15 to skip "WindSpeed = "
                                 float newg = strtof(windGust, nullptr);
                                 if (newg > gust)
                                     gust = newg;
@@ -504,21 +505,21 @@ void SerialModule::processWXSerial()
                         } else if (strstr(line, "BatVoltage") != NULL) { // we have a battVoltage line
                             char *batVoltagePos = strstr(line, "BatVoltage     = ");
                             if (batVoltagePos != NULL) {
-                            strcpy(batVoltage, batVoltagePos + 17); // 18 for ws 80, 17 for ws85
+                                strlcpy(batVoltage, batVoltagePos + 17, sizeof(batVoltage)); // 18 for ws 80, 17 for ws85
                                 batVoltageF = strtof(batVoltage, nullptr);
                                 break; // last possible data we want so break
                             }
                         } else if (strstr(line, "CapVoltage") != NULL) { // we have a cappVoltage line
                             char *capVoltagePos = strstr(line, "CapVoltage     = ");
                             if (capVoltagePos != NULL) {
-                            strcpy(capVoltage, capVoltagePos + 17); // 18 for ws 80, 17 for ws85
+                                strlcpy(capVoltage, capVoltagePos + 17, sizeof(capVoltage)); // 18 for ws 80, 17 for ws85
                                 capVoltageF = strtof(capVoltage, nullptr);
                             }
                             // GXTS04Temp   = 24.4
                         } else if (strstr(line, "GXTS04Temp") != NULL) { // we have a temperature line
                             char *tempPos = strstr(line, "GXTS04Temp   = ");
                             if (tempPos != NULL) {
-                            strcpy(temperature, tempPos + 15); // 15 spaces for ws85
+                                strlcpy(temperature, tempPos + 15, sizeof(temperature)); // 15 spaces for ws85
                                 temperatureF = strtof(temperature, nullptr);
                             }
 
@@ -526,7 +527,7 @@ void SerialModule::processWXSerial()
                             // LOG_INFO(line);
                             char *pos = strstr(line, "RainIntSum     = ");
                             if (pos != NULL) {
-                            strcpy(rainStr, pos + 17); // 17 spaces for ws85
+                                strlcpy(rainStr, pos + 17, sizeof(rainStr)); // 17 spaces for ws85
                                 rainSum = int(strtof(rainStr, nullptr));
                             }
 
@@ -535,7 +536,7 @@ void SerialModule::processWXSerial()
                                 // LOG_INFO(line);
                                 char *pos = strstr(line, "Rain           = ");
                                 if (pos != NULL) {
-                                strcpy(rainStr, pos + 17); // 17 spaces for ws85
+                                    strlcpy(rainStr, pos + 17, sizeof(rainStr)); // 17 spaces for ws85
                                     rain = strtof(rainStr, nullptr);
                                 }
                             }
@@ -545,6 +546,7 @@ void SerialModule::processWXSerial()
                         lineStart = lineEnd + 1;
                     }
                 }
+            }
             break;
             // clear the input buffer
             while (Serial2.available() > 0) {