pohui_pohui/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2025-02-08 05:31:25 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix potential memory leak in AtakPluginModule (#5803)

Browse Source
This commit is contained in:
Eric Severance 2025-01-09 16:25:25 -08:00 committed by GitHub
parent 8aac9f2e8e
commit 1d756ae574
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/modules/AtakPluginModule.cpp
View File

@ -131,7 +131,6 @@ void AtakPluginModule::alterReceivedProtobuf(meshtastic_MeshPacket &mp, meshtast
} }
// Decompress for Phone (EUD) // Decompress for Phone (EUD)
auto decompressedCopy = packetPool.allocCopy(mp);
auto uncompressed = cloneTAKPacketData(t); auto uncompressed = cloneTAKPacketData(t);
uncompressed.is_compressed = false; uncompressed.is_compressed = false;
if (t->has_contact) { if (t->has_contact) {
@ -188,6 +187,7 @@ void AtakPluginModule::alterReceivedProtobuf(meshtastic_MeshPacket &mp, meshtast
LOG_DEBUG("Decompressed chat to_callsign: %d bytes", length); LOG_DEBUG("Decompressed chat to_callsign: %d bytes", length);
} }
} }
auto decompressedCopy = packetPool.allocCopy(mp);
decompressedCopy->decoded.payload.size = decompressedCopy->decoded.payload.size =
pb_encode_to_bytes(decompressedCopy->decoded.payload.bytes, sizeof(decompressedCopy->decoded.payload), pb_encode_to_bytes(decompressedCopy->decoded.payload.bytes, sizeof(decompressedCopy->decoded.payload),
meshtastic_TAKPacket_fields, &uncompressed); meshtastic_TAKPacket_fields, &uncompressed);