only show time on OLED if we have a valid UTC clock

docs/software/TODO.md

@@ -11,11 +11,15 @@ You probably don't care about this section - skip to the next one.
 * DONE channel sharing in android
 * DONE test 1.0 firmware update on android
 * DONE test 1.1 firmware update on android
-* test 1.2.10 firmware update on android
+* DONE test 1.2.10 firmware update on android
 * DONE test link sharing on android
 * luxon bug report - seeing rx acks for nodes that are not on the network
 * document how to do remote admin
-* release py, android, device
+* release py
+* DONE show GPS time only if we know what global time is
+* android should always provide time to nodes - so that it is easier for the mesh to learn the current time
+* nrf52 should preserve local time across reset
+* firmware OTA updates of is_router true nodes fails?
   
 ## 1.2 cleanup & multichannel support:
 

src/RedirectablePrint.cpp

@@ -1,22 +1,24 @@
 #include "RedirectablePrint.h"
+#include "RTC.h"
 #include "concurrency/OSThread.h"
 #include "configuration.h"
 #include <assert.h>
 #include <sys/time.h>
 #include <time.h>
-#include "RTC.h"
 
 /**
  * A printer that doesn't go anywhere
  */
 NoopPrint noopPrint;
 
-void RedirectablePrint::setDestination(Print *_dest) {
+void RedirectablePrint::setDestination(Print *_dest)
+{
     assert(_dest);
     dest = _dest;
 }
 
-size_t RedirectablePrint::write(uint8_t c) {
+size_t RedirectablePrint::write(uint8_t c)
+{
     // Always send the characters to our segger JTAG debugger
 #ifdef SEGGER_STDOUT_CH
     SEGGER_RTT_PutChar(SEGGER_STDOUT_CH, c);
@@ -49,10 +51,6 @@ size_t RedirectablePrint::vprintf(const char *format, va_list arg)
     return len;
 }
 
-#define SEC_PER_DAY 86400
-#define SEC_PER_HOUR 3600
-#define SEC_PER_MIN 60
-
 size_t RedirectablePrint::logDebug(const char *format, ...)
 {
     size_t r = 0;

src/gps/RTC.h

@@ -28,3 +28,7 @@ uint32_t getTime();
 uint32_t getValidTime(RTCQuality minQuality);
 
 void readFromRTC();
+
+#define SEC_PER_DAY 86400
+#define SEC_PER_HOUR 3600
+#define SEC_PER_MIN 60

src/graphics/Screen.cpp

@@ -28,11 +28,12 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "Screen.h"
 #include "configuration.h"
 #include "fonts.h"
+#include "gps/RTC.h"
 #include "graphics/images.h"
 #include "main.h"
 #include "mesh-pb-constants.h"
-#include "plugins/TextMessagePlugin.h"
 #include "mesh/Channels.h"
+#include "plugins/TextMessagePlugin.h"
 #include "target_specific.h"
 #include "utils.h"
 
@@ -163,8 +164,7 @@ static void drawPluginFrame(OLEDDisplay *display, OLEDDisplayUiState *state, int
         // if we're transitioning from the end of the frame list back around to the first
         // frame, then we want this to be `0`
         plugin_frame = state->transitionFrameTarget;
-    }
+    } else {
-    else {
         // otherwise, just display the plugin frame that's aligned with the current frame
         plugin_frame = state->currentFrame;
         // DEBUG_MSG("Screen is not in transition.  Frame: %d\n\n", plugin_frame);
@@ -172,7 +172,6 @@ static void drawPluginFrame(OLEDDisplay *display, OLEDDisplayUiState *state, int
     // DEBUG_MSG("Drawing Plugin Frame %d\n\n", plugin_frame);
     MeshPlugin &pi = *pluginFrames.at(plugin_frame);
     pi.drawFrame(display, state, x, y);
-    
 }
 
 static void drawFrameBluetooth(OLEDDisplay *display, OLEDDisplayUiState *state, int16_t x, int16_t y)
@@ -208,7 +207,6 @@ static void drawFrameFirmware(OLEDDisplay *display, OLEDDisplayUiState *state, i
     // display->drawString(64 + x, 26 + y, btPIN);
 }
 
-
 /// Draw the last text message we received
 static void drawCriticalFaultFrame(OLEDDisplay *display, OLEDDisplayUiState *state, int16_t x, int16_t y)
 {
@@ -1286,14 +1284,41 @@ void DebugInfo::drawFrameSettings(OLEDDisplay *display, OLEDDisplayUiState *stat
     uint32_t minutes = seconds / 60;
     uint32_t hours = minutes / 60;
     uint32_t days = hours / 24;
-    currentMillis %= 1000;
+    // currentMillis %= 1000;
-    seconds %= 60;
+    // seconds %= 60;
-    minutes %= 60;
+    // minutes %= 60;
-    hours %= 24;
+    // hours %= 24;
 
-    display->drawString(x, y + FONT_HEIGHT_SMALL * 1,
+    // Show uptime as days, hours, minutes OR seconds
-                        String(days) + "d " + (hours < 10 ? "0" : "") + String(hours) + ":" + (minutes < 10 ? "0" : "") +
+    String uptime;
-                            String(minutes) + ":" + (seconds < 10 ? "0" : "") + String(seconds));
+    if (days >= 2)
+        uptime += String(days) + "d ";
+    else if (hours >= 2)
+        uptime += String(hours) + "h ";
+    else if (minutes >= 1)
+        uptime += String(minutes) + "m ";
+    else
+        uptime += String(seconds) + "s ";
+
+    uint32_t rtc_sec = getValidTime(RTCQuality::RTCQualityFromNet);
+    if (rtc_sec > 0) {
+        long hms = rtc_sec % SEC_PER_DAY;
+        // hms += tz.tz_dsttime * SEC_PER_HOUR;
+        // hms -= tz.tz_minuteswest * SEC_PER_MIN;
+        // mod `hms` to ensure in positive range of [0...SEC_PER_DAY)
+        hms = (hms + SEC_PER_DAY) % SEC_PER_DAY;
+
+        // Tear apart hms into h:m:s
+        int hour = hms / SEC_PER_HOUR;
+        int min = (hms % SEC_PER_HOUR) / SEC_PER_MIN;
+        int sec = (hms % SEC_PER_HOUR) % SEC_PER_MIN; // or hms % SEC_PER_MIN
+
+        char timebuf[9];
+        snprintf(timebuf, sizeof(timebuf), "%02d:%02d:%02d", hour, min, sec);
+        uptime += timebuf;
+    }
+
+    display->drawString(x, y + FONT_HEIGHT_SMALL * 1, uptime);
 
 #ifndef NO_ESP32
     // Show CPU Frequency.