Unify the shutdown proceedure (#7393)

* Unify the shutdown proceedure

* Don't double save nodeDB on shutdown

* Re-tool button shutdown to better correspond to tones

* Beep then save

---------

Co-authored-by: Ben Meadors <benmmeadors@gmail.com>

src/Power.cpp

@@ -681,7 +681,14 @@ bool Power::setup()
 
 void Power::shutdown()
 {
-    LOG_INFO("Shutting Down");
+
+#if HAS_SCREEN
+    if (screen) {
+        screen->showSimpleBanner("Shutting Down...", 0); // stays on screen
+    }
+#endif
+    playShutdownMelody();
+    nodeDB->saveToDisk();
 
 #if defined(ARCH_NRF52) || defined(ARCH_ESP32) || defined(ARCH_RP2040)
 #ifdef PIN_LED1
@@ -693,7 +700,11 @@ void Power::shutdown()
 #ifdef PIN_LED3
     ledOff(PIN_LED3);
 #endif
-    doDeepSleep(DELAY_FOREVER, false, false);
+    doDeepSleep(DELAY_FOREVER, false, true);
+#elif defined(ARCH_PORTDUINO)
+    exit(EXIT_SUCCESS);
+#else
+    LOG_WARN("FIXME implement shutdown for this platform");
 #endif
 }
 

src/buzz/BuzzerFeedbackThread.cpp

@@ -47,10 +47,6 @@ int BuzzerFeedbackThread::handleInputEvent(const InputEvent *event)
         playComboTune(); // Ping sent feedback
         break;
 
-    case INPUT_BROKER_SHUTDOWN:
-        playShutdownMelody(); // Shutdown feedback
-        break;
-
     default:
         // For other events, check if it's a printable character
         if (event->kbchar >= 32 && event->kbchar <= 126) {

src/graphics/draw/MenuHandler.cpp

@@ -815,9 +815,8 @@ void menuHandler::shutdownMenu()
     bannerOptions.optionsCount = 2;
     bannerOptions.bannerCallback = [](int selected) -> void {
         if (selected == 1) {
-            IF_SCREEN(screen->showSimpleBanner("Shutting Down...", 0));
+            InputEvent event = {.inputEvent = (input_broker_event)INPUT_BROKER_SHUTDOWN, .kbchar = 0, .touchX = 0, .touchY = 0};
-            nodeDB->saveToDisk();
+            inputBroker->injectInputEvent(&event);
-            power->shutdown();
         } else {
             menuQueue = power_menu;
             screen->runNow();

src/input/ButtonThread.cpp

@@ -53,23 +53,21 @@ bool ButtonThread::initButton(const ButtonConfig &config)
         },
         this);
 
-    if (config.longPress != INPUT_BROKER_NONE) {
+    _longPress = config.longPress;
-        _longPress = config.longPress;
+    userButton.attachLongPressStart(
-        userButton.attachLongPressStart(
+        [](void *callerThread) -> void {
-            [](void *callerThread) -> void {
+            ButtonThread *thread = (ButtonThread *)callerThread;
-                ButtonThread *thread = (ButtonThread *)callerThread;
+            // if (millis() > 30000) // hold off 30s after boot
-                // if (millis() > 30000) // hold off 30s after boot
+            thread->btnEvent = BUTTON_EVENT_LONG_PRESSED;
-                thread->btnEvent = BUTTON_EVENT_LONG_PRESSED;
+        },
-            },
+        this);
-            this);
+    userButton.attachLongPressStop(
-        userButton.attachLongPressStop(
+        [](void *callerThread) -> void {
-            [](void *callerThread) -> void {
+            ButtonThread *thread = (ButtonThread *)callerThread;
-                ButtonThread *thread = (ButtonThread *)callerThread;
+            // if (millis() > 30000) // hold off 30s after boot
-                // if (millis() > 30000) // hold off 30s after boot
+            thread->btnEvent = BUTTON_EVENT_LONG_RELEASED;
-                thread->btnEvent = BUTTON_EVENT_LONG_RELEASED;
+        },
-            },
+        this);
-            this);
-    }
 
     if (config.doublePress != INPUT_BROKER_NONE) {
         _doublePress = config.doublePress;
@@ -202,11 +200,11 @@ int32_t ButtonThread::runOnce()
 
                 break;
             }
-
+            if (_longPress != INPUT_BROKER_NONE) {
-            // Forward long press to InputBroker (but NOT as DOWN/SELECT, just forward a "button long press" event)
+                // Forward long press to InputBroker (but NOT as DOWN/SELECT, just forward a "button long press" event)
-            evt.inputEvent = _longPress;
+                evt.inputEvent = _longPress;
-            this->notifyObservers(&evt);
+                this->notifyObservers(&evt);
-
+            }
             // Reset combination tracking
             waitingForLongPress = false;
 
@@ -253,7 +251,7 @@ int32_t ButtonThread::runOnce()
         // may wake the board immediatedly.
         case BUTTON_EVENT_LONG_RELEASED: {
 
-            LOG_INFO("LONG PRESS RELEASE");
+            LOG_INFO("LONG PRESS RELEASE AFTER %u MILLIS", millis() - buttonPressStartTime);
             if (millis() > 30000 && _longLongPress != INPUT_BROKER_NONE &&
                 (millis() - buttonPressStartTime) >= _longLongPressTime) {
                 evt.inputEvent = _longLongPress;

src/input/ButtonThread.h

@@ -18,7 +18,7 @@ struct ButtonConfig {
     uint16_t longPressTime = 500;
     input_broker_event doublePress = INPUT_BROKER_NONE;
     input_broker_event longLongPress = INPUT_BROKER_NONE;
-    uint16_t longLongPressTime = 5000;
+    uint16_t longLongPressTime = 3900;
     input_broker_event triplePress = INPUT_BROKER_NONE;
     input_broker_event shortLong = INPUT_BROKER_NONE;
     bool touchQuirk = false;

src/input/ExpressLRSFiveWay.cpp

@@ -233,14 +233,7 @@ void ExpressLRSFiveWay::sendAdhocPing()
 // Contained as one method for easier remapping of buttons by user
 void ExpressLRSFiveWay::shutdown()
 {
-    LOG_INFO("Shutdown from long press");
+    sendKey(INPUT_BROKER_SHUTDOWN);
-    powerFSM.trigger(EVENT_PRESS);
-    screen->startAlert("Shutting Down...");
-    // Don't set alerting = true. We don't want to auto-dismiss this alert.
-
-    playShutdownMelody(); // In case user adds a buzzer
-
-    shutdownAtMsec = millis() + 3000;
 }
 
 void ExpressLRSFiveWay::click()

src/main.cpp

@@ -1042,8 +1042,9 @@ void setup()
             mainDelay.interruptFromISR(&higherWake);
         };
         userConfigNoScreen.singlePress = INPUT_BROKER_USER_PRESS;
-        userConfigNoScreen.longPress = INPUT_BROKER_SHUTDOWN;
+        userConfigNoScreen.longPress = INPUT_BROKER_NONE;
-        userConfigNoScreen.longPressTime = 5000;
+        userConfigNoScreen.longPressTime = 500;
+        userConfigNoScreen.longLongPress = INPUT_BROKER_SHUTDOWN;
         userConfigNoScreen.doublePress = INPUT_BROKER_SEND_PING;
         userConfigNoScreen.triplePress = INPUT_BROKER_GPS_TOGGLE;
         UserButtonThread->initButton(userConfigNoScreen);

src/modules/SystemCommandsModule.cpp

@@ -107,11 +107,7 @@ int SystemCommandsModule::handleInputEvent(const InputEvent *event)
         return true;
     // Power control
     case INPUT_BROKER_SHUTDOWN:
-        LOG_ERROR("Shutting Down");
+        shutdownAtMsec = millis();
-        IF_SCREEN(screen->showSimpleBanner("Shutting Down..."));
-        nodeDB->saveToDisk();
-        shutdownAtMsec = millis() + DEFAULT_SHUTDOWN_SECONDS * 1000;
-        // runState = CANNED_MESSAGE_RUN_STATE_INACTIVE;
         return true;
 
     default:

src/shutdown.h

@@ -40,21 +40,8 @@ void powerCommandsCheck()
 #endif
     }
 
-#if defined(ARCH_ESP32) || defined(ARCH_NRF52)
-    if (shutdownAtMsec && screen) {
-        screen->showSimpleBanner("Shutting Down...", 0); // stays on screen
-    }
-#endif
-
     if (shutdownAtMsec && millis() > shutdownAtMsec) {
-        LOG_INFO("Shut down from admin command");
+        shutdownAtMsec = 0;
-#if defined(ARCH_NRF52) || defined(ARCH_ESP32) || defined(ARCH_RP2040)
-        playShutdownMelody();
         power->shutdown();
-#elif defined(ARCH_PORTDUINO)
-        exit(EXIT_SUCCESS);
-#else
-        LOG_WARN("FIXME implement shutdown for this platform");
-#endif
     }
 }