check more error codes

proto

@@ -1 +1 @@
-Subproject commit 7c025b9a4d54bb410ec17ee653122861b413f177
+Subproject commit e56f2770c33216ba94f289e2fb7f0b2dfd33aca2

src/RedirectablePrint.cpp

@@ -1,9 +1,9 @@
 #include "RedirectablePrint.h"
+#include "concurrency/OSThread.h"
 #include "configuration.h"
 #include <assert.h>
 #include <sys/time.h>
 #include <time.h>
-#include "concurrency/OSThread.h"
 
 /**
  * A printer that doesn't go anywhere
@@ -38,7 +38,7 @@ size_t RedirectablePrint::vprintf(const char *format, va_list arg)
         va_end(arg);
         return 0;
     };
-    if (len >= (int) printBufLen) {
+    if (len >= (int)printBufLen) {
         delete[] printBuf;
         printBufLen *= 2;
         printBuf = new char[printBufLen];
@@ -55,21 +55,24 @@ size_t RedirectablePrint::vprintf(const char *format, va_list arg)
 
 size_t RedirectablePrint::logDebug(const char *format, ...)
 {
+    size_t r = 0;
+
+    if (!inDebugPrint) {
+        inDebugPrint = true;
+
         va_list arg;
         va_start(arg, format);
 
         // Cope with 0 len format strings, but look for new line terminator
         bool hasNewline = *format && format[strlen(format) - 1] == '\n';
 
-    size_t r = 0;
-
         // If we are the first message on a report, include the header
         if (!isContinuationMessage) {
             struct timeval tv;
             if (!gettimeofday(&tv, NULL)) {
                 long hms = tv.tv_sec % SEC_PER_DAY;
-            //hms += tz.tz_dsttime * SEC_PER_HOUR;
+                // hms += tz.tz_dsttime * SEC_PER_HOUR;
-            //hms -= tz.tz_minuteswest * SEC_PER_MIN;
+                // hms -= tz.tz_minuteswest * SEC_PER_MIN;
                 // mod `hms` to ensure in positive range of [0...SEC_PER_DAY)
                 hms = (hms + SEC_PER_DAY) % SEC_PER_DAY;
 
@@ -83,7 +86,7 @@ size_t RedirectablePrint::logDebug(const char *format, ...)
                 r += printf("??:??:?? %u ", millis() / 1000);
 
             auto thread = concurrency::OSThread::currentThread;
-        if(thread) {
+            if (thread) {
                 print("[");
                 // printf("%p ", thread);
                 // assert(thread->ThreadName.length());
@@ -96,6 +99,8 @@ size_t RedirectablePrint::logDebug(const char *format, ...)
         va_end(arg);
 
         isContinuationMessage = !hasNewline;
+        inDebugPrint = false;
+    }
 
     return r;
 }

src/RedirectablePrint.h

@@ -19,6 +19,8 @@ class RedirectablePrint : public Print
     /// Used to allow multiple logDebug messages to appear on a single log line
     bool isContinuationMessage = false;
 
+    volatile bool inDebugPrint = false;
+
   public:
     RedirectablePrint(Print *_dest) : dest(_dest) {}
 

src/concurrency/BinarySemaphoreFreeRTOS.cpp

@@ -1,5 +1,6 @@
 #include "concurrency/BinarySemaphoreFreeRTOS.h"
 #include "configuration.h"
+#include <assert.h>
 
 #ifdef HAS_FREE_RTOS
 
@@ -9,6 +10,7 @@ namespace concurrency
 BinarySemaphoreFreeRTOS::BinarySemaphoreFreeRTOS()
 {
     semaphore = xSemaphoreCreateBinary();
+    assert(semaphore);
 }
 
 BinarySemaphoreFreeRTOS::~BinarySemaphoreFreeRTOS()

src/mesh/MemoryPool.h

@@ -101,25 +101,30 @@ template <class T> class MemoryPool : public Allocator<T>
     /// Return a buffer for use by others
     virtual void release(T *p)
     {
-        assert(dead.enqueue(p, 0));
         assert(p >= buf &&
                (size_t)(p - buf) <
                    maxElements); // sanity check to make sure a programmer didn't free something that didn't come from this pool
+        assert(dead.enqueue(p, 0));
     }
 
 #ifdef HAS_FREE_RTOS
     /// Return a buffer from an ISR, if higherPriWoken is set to true you have some work to do ;-)
     void releaseFromISR(T *p, BaseType_t *higherPriWoken)
     {
-        assert(dead.enqueueFromISR(p, higherPriWoken));
         assert(p >= buf &&
                (size_t)(p - buf) <
                    maxElements); // sanity check to make sure a programmer didn't free something that didn't come from this pool
+        assert(dead.enqueueFromISR(p, higherPriWoken));
     }
 #endif
 
   protected:
     /// Return a queable object which has been prefilled with zeros - allow timeout to wait for available buffers (you
     /// probably don't want this version).
-    virtual T *alloc(TickType_t maxWait) { return dead.dequeuePtr(maxWait); }
+    virtual T *alloc(TickType_t maxWait)
+    {
+        T *p = dead.dequeuePtr(maxWait);
+        assert(p);
+        return p;
+    }
 };