pohui_pohui/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2025-09-22 17:34:25 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

refactor: don't init system applets using onActivate

Browse Source 
System applets cannot be deactivated, so we will avoid using onActivate / onDeactivate methods entirely.
This commit is contained in:
Todd Herbert 2025-03-22 14:17:28 +13:00
parent f1f9aac134
commit 7c327ce0e4
4 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.cpp
View File

@ -27,8 +27,6 @@ InkHUD::MenuApplet::MenuApplet() : concurrency::OSThread("MenuApplet")
} }
} }
void InkHUD::MenuApplet::onActivate() {}
void InkHUD::MenuApplet::onForeground() void InkHUD::MenuApplet::onForeground()
{ {
// We do need this before we render, but we can optimize by just calculating it once now // We do need this before we render, but we can optimize by just calculating it once now

1
src/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.h
View File

@ -21,7 +21,6 @@ class MenuApplet : public SystemApplet, public concurrency::OSThread
{ {
public: public:
MenuApplet(); MenuApplet();
void onActivate() override;
void onForeground() override; void onForeground() override;
void onBackground() override; void onBackground() override;
void onButtonShortPress() override; void onButtonShortPress() override;

2
src/graphics/niche/InkHUD/Applets/System/Tips/TipsApplet.cpp
View File

@ -207,8 +207,6 @@ void InkHUD::TipsApplet::onBackground()
inkhud->forceUpdate(EInk::UpdateTypes::FULL); inkhud->forceUpdate(EInk::UpdateTypes::FULL);
} }
void InkHUD::TipsApplet::onActivate() {}
// While our SystemApplet::handleInput flag is true // While our SystemApplet::handleInput flag is true
void InkHUD::TipsApplet::onButtonShortPress() void InkHUD::TipsApplet::onButtonShortPress()
{ {

1
src/graphics/niche/InkHUD/Applets/System/Tips/TipsApplet.h
View File

@ -33,7 +33,6 @@ class TipsApplet : public SystemApplet
TipsApplet(); TipsApplet();
void onRender() override; void onRender() override;
void onActivate() override;
void onForeground() override; void onForeground() override;
void onBackground() override; void onBackground() override;
void onButtonShortPress() override; void onButtonShortPress() override;