From 7c5ab885bec039559fc088f3f526b4d0a9eb1adf Mon Sep 17 00:00:00 2001 From: Kevin Hester Date: Fri, 19 Mar 2021 15:24:24 +0800 Subject: [PATCH] geeksville todo --- docs/software/TODO.md | 11 +++++++---- src/plugins/AdminPlugin.cpp | 3 +-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/software/TODO.md b/docs/software/TODO.md index c65a53658..18fa36a67 100644 --- a/docs/software/TODO.md +++ b/docs/software/TODO.md @@ -2,16 +2,19 @@ You probably don't care about this section - skip to the next one. -## 1.2 cleanup & multichannel support: +## before next release * before next relase: test empty channel sets on android * test link sharing on android +* timestamps on oled screen are wrong - don't seem to be updating based on message rx +* channel hash suffixes are wrong on android +* luxon bug report - seeing rx acks for nodes that are not on the network +## 1.2 cleanup & multichannel support: + * DONE cleanup the external notification and serial plugins * non ack version of stress test fails sometimes! -* timestamps on oled screen are wrong - don't seem to be updating based on message rx -* luxon bug report - seeing rx acks for nodes that are not on the network -* channel hash suffixes are wrong on android + * tx fault test has a bug #734 * DONE move device types into an enum in nodeinfo * fix android to use new device types for firmware update diff --git a/src/plugins/AdminPlugin.cpp b/src/plugins/AdminPlugin.cpp index 5cc4876aa..e80ae32a4 100644 --- a/src/plugins/AdminPlugin.cpp +++ b/src/plugins/AdminPlugin.cpp @@ -113,8 +113,7 @@ void AdminPlugin::handleSetChannel(const Channel &cc) if (cc.index == 0) { // FIXME, this updates the user preferences also, which isn't needed - we really just want to notify on configChanged service.reloadConfig(); - } - else { + } else { channels.onConfigChanged(); // tell the radios about this change nodeDB.saveChannelsToDisk(); }