From 8815746006fc21e8ba1661fb0c3aad8cb98fb83f Mon Sep 17 00:00:00 2001 From: GUVWAF Date: Fri, 25 Nov 2022 20:32:43 +0100 Subject: [PATCH 1/2] Fix wrong comment --- src/modules/AdminModule.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/AdminModule.h b/src/modules/AdminModule.h index 3afbfa133..369bcc60b 100644 --- a/src/modules/AdminModule.h +++ b/src/modules/AdminModule.h @@ -2,7 +2,7 @@ #include "ProtobufModule.h" /** - * Routing module for router control messages + * Admin module for admin messages */ class AdminModule : public ProtobufModule { From c45a85547eb0c3bfca9651790591cc74b31ebba5 Mon Sep 17 00:00:00 2001 From: GUVWAF Date: Fri, 25 Nov 2022 20:33:12 +0100 Subject: [PATCH 2/2] Send 'ACK' response for admin message --- src/modules/AdminModule.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/modules/AdminModule.cpp b/src/modules/AdminModule.cpp index 7226abd0b..3ce8731e7 100644 --- a/src/modules/AdminModule.cpp +++ b/src/modules/AdminModule.cpp @@ -176,6 +176,12 @@ bool AdminModule::handleReceivedProtobuf(const MeshPacket &mp, AdminMessage *r) } break; } + + // If asked for a response and it is not yet set, generate an 'ACK' response + if (mp.decoded.want_response && !myReply) { + myReply = allocErrorResponse(Routing_Error_NONE, &mp); + } + return handled; }