From 35bcf684b49fbb537c3681cd02a6729660b44ef8 Mon Sep 17 00:00:00 2001 From: ford-jones Date: Fri, 22 Aug 2025 21:09:55 +1200 Subject: [PATCH 1/3] Set position broadcasting default to opt-in --- src/mesh/NodeDB.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index 18014eb02..dc3a3b160 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -640,7 +640,7 @@ void NodeDB::installDefaultConfig(bool preserveKey = false) #ifdef USERPREFS_CONFIG_SMART_POSITION_ENABLED config.position.position_broadcast_smart_enabled = USERPREFS_CONFIG_SMART_POSITION_ENABLED; #else - config.position.position_broadcast_smart_enabled = true; + config.position.position_broadcast_smart_enabled = false; // Position broadcasting is opt-in #endif config.position.broadcast_smart_minimum_distance = 100; config.position.broadcast_smart_minimum_interval_secs = 30; From 851ea2248536c60da155a38e86cf2d354dcbd5a4 Mon Sep 17 00:00:00 2001 From: ford-jones Date: Fri, 22 Aug 2025 23:51:31 +1200 Subject: [PATCH 2/3] Updated comments --- src/mesh/NodeDB.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index dc3a3b160..8d0526779 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -928,8 +928,8 @@ void NodeDB::installRoleDefaults(meshtastic_Config_DeviceConfig_Role role) owner.has_is_unmessagable = true; owner.is_unmessagable = true; config.device.node_info_broadcast_secs = ONE_DAY; - config.position.position_broadcast_smart_enabled = true; - config.position.position_broadcast_secs = 3 * 60; // Every 3 minutes + config.position.position_broadcast_smart_enabled = true; // Broadcast is implicit in the selection of this role + config.position.position_broadcast_secs = 3 * 60; // Every 3 minutes config.position.broadcast_smart_minimum_distance = 20; config.position.broadcast_smart_minimum_interval_secs = 15; // Remove Altitude MSL from flags since CoTs use HAE (height above ellipsoid) From c5f478a85508f984a065bc1524590b82f9fb9975 Mon Sep 17 00:00:00 2001 From: ford-jones Date: Sat, 23 Aug 2025 01:34:37 +1200 Subject: [PATCH 3/3] Default broadcast interval to maximum value --- src/mesh/NodeDB.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index 8d0526779..5dac16396 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -751,7 +751,7 @@ void NodeDB::initConfigIntervals() #ifdef USERPREFS_CONFIG_POSITION_BROADCAST_INTERVAL config.position.position_broadcast_secs = USERPREFS_CONFIG_POSITION_BROADCAST_INTERVAL; #else - config.position.position_broadcast_secs = default_broadcast_interval_secs; + config.position.position_broadcast_secs = MAX_INTERVAL; #endif config.power.ls_secs = default_ls_secs;