pohui_pohui/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2025-02-02 02:39:57 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Merge pull request #2295 from meshtastic/2228-bug-heap-leak-in-rangetestmodule

Browse Source 
tryfix #2228 as suggested by @mverch67
This commit is contained in:
Thomas Göttgens 2023-02-21 20:40:20 +01:00 committed by GitHub
commit 9fc18c2a19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mesh/ReliableRouter.cpp
View File

@ -148,7 +148,11 @@ bool ReliableRouter::stopRetransmission(GlobalPacketId key)
if (old) { if (old) {
auto numErased = pending.erase(key); auto numErased = pending.erase(key);
assert(numErased == 1); assert(numErased == 1);
// remove the 'original' (identified by originator and packet->id) from the txqueue and free it
cancelSending(getFrom(old->packet), old->packet->id); cancelSending(getFrom(old->packet), old->packet->id);
// now free the pooled copy for retransmission too. tryfix for #2228
if (old->packet)
packetPool.release(old->packet);
return true; return true;
} else } else
return false; return false;