diff --git a/docs/software/TODO.md b/docs/software/TODO.md index 0c742665d..e26948017 100644 --- a/docs/software/TODO.md +++ b/docs/software/TODO.md @@ -1,7 +1,7 @@ # High priority - why is the net so chatty now? -- do a release +- CONFIG_CLASSIC_BT_ENABLED=n - device wakes, turns BLE on and phone doesn't notice (while phone was sitting in auto-connect) - E22 bringup - encryption review findings writeup @@ -60,6 +60,7 @@ Items after the first final candidate release. - add a watchdog timer - handle millis() rollover in GPS.getTime - otherwise we will break after 50 days - report esp32 device code bugs back to the mothership via android +- change BLE bonding to something more secure. see comment by pSecurity->setAuthenticationMode(ESP_LE_AUTH_BOND) # Spinoff project ideas diff --git a/src/esp32/main-esp32.cpp b/src/esp32/main-esp32.cpp index 2b4711d5e..cf02ebebf 100644 --- a/src/esp32/main-esp32.cpp +++ b/src/esp32/main-esp32.cpp @@ -154,6 +154,18 @@ void axp192Init() } #endif +/* +static void printBLEinfo() { + int dev_num = esp_ble_get_bond_device_num(); + + esp_ble_bond_dev_t *dev_list = (esp_ble_bond_dev_t *)malloc(sizeof(esp_ble_bond_dev_t) * dev_num); + esp_ble_get_bond_device_list(&dev_num, dev_list); + for (int i = 0; i < dev_num; i++) { + // esp_ble_remove_bond_device(dev_list[i].bd_addr); + } + +} */ + void esp32Setup() { uint32_t seed = esp_random(); diff --git a/src/mesh/MeshService.cpp b/src/mesh/MeshService.cpp index 49cd0fe79..eebfb227e 100644 --- a/src/mesh/MeshService.cpp +++ b/src/mesh/MeshService.cpp @@ -160,7 +160,7 @@ int MeshService::handleFromRadio(const MeshPacket *mp) // If we veto a received User packet, we don't put it into the DB or forward it to the phone (to prevent confusing it) if (mp) { - DEBUG_MSG("Forwarding to phone, from=0x%x, rx_time=%u\n", mp->from, mp->rx_time); + printPacket("Forwarding to phone", mp); nodeDB.updateFrom(*mp); // update our DB state based off sniffing every RX packet from the radio fromNum++; diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index e1ea45dd6..4e87ac773 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -30,7 +30,7 @@ DeviceState versions used to be defined in the .proto file but really only this #define here. */ -#define DEVICESTATE_CUR_VER 9 +#define DEVICESTATE_CUR_VER 10 #define DEVICESTATE_MIN_VER DEVICESTATE_CUR_VER #ifndef NO_ESP32 diff --git a/src/mesh/PacketHistory.cpp b/src/mesh/PacketHistory.cpp index 75005d408..3d1884ace 100644 --- a/src/mesh/PacketHistory.cpp +++ b/src/mesh/PacketHistory.cpp @@ -2,8 +2,6 @@ #include "configuration.h" #include "mesh-pb-constants.h" - - PacketHistory::PacketHistory() { recentPackets.reserve(MAX_NUM_NODES); // Prealloc the worst case # of records - to prevent heap fragmentation @@ -48,7 +46,7 @@ bool PacketHistory::wasSeenRecently(const MeshPacket *p, bool withUpdate) r.sender = p->from; r.rxTimeMsec = now; recentPackets.push_back(r); - DEBUG_MSG("Adding packet record for fr=0x%x,to=0x%x,id=%d\n", p->from, p->to, p->id); + printPacket("Adding packet record", p); } return false; diff --git a/src/mesh/PhoneAPI.cpp b/src/mesh/PhoneAPI.cpp index ec071fa5f..59750d468 100644 --- a/src/mesh/PhoneAPI.cpp +++ b/src/mesh/PhoneAPI.cpp @@ -2,6 +2,7 @@ #include "MeshService.h" #include "NodeDB.h" #include "PowerFSM.h" +#include "RadioInterface.h" #include PhoneAPI::PhoneAPI() @@ -43,8 +44,7 @@ void PhoneAPI::handleToRadio(const uint8_t *buf, size_t bufLength) switch (toRadioScratch.which_variant) { case ToRadio_packet_tag: { MeshPacket &p = toRadioScratch.variant.packet; - DEBUG_MSG("PACKET FROM PHONE: id=%d, to=%x, want_ack=%d, which1=%d, which2=%d, typ=%d, buflen=%d\n", p.id, p.to, p.want_ack, p.which_payload, - p.decoded.which_payload, p.decoded.data.typ, bufLength); + printPacket("PACKET FROM PHONE", &p); service.handleToRadio(p); break; } diff --git a/src/mesh/RadioInterface.cpp b/src/mesh/RadioInterface.cpp index 43d9a6696..4307b0a7d 100644 --- a/src/mesh/RadioInterface.cpp +++ b/src/mesh/RadioInterface.cpp @@ -24,6 +24,52 @@ separated by 2.16 MHz with respect to the adjacent channels. Channel zero starts // 1kb was too small #define RADIO_STACK_SIZE 4096 +void printPacket(const char *prefix, const MeshPacket *p) +{ + DEBUG_MSG("%s (id=0x%08x Fr0x%02x To0x%02x, WantAck%d, HopLim%d", prefix, p->id, p->from & 0xff, p->to & 0xff, p->want_ack, + p->hop_limit); + if (p->which_payload == MeshPacket_decoded_tag) { + auto &s = p->decoded; + switch (s.which_payload) { + case SubPacket_data_tag: + DEBUG_MSG(" Payload:Data"); + break; + case SubPacket_position_tag: + DEBUG_MSG(" Payload:Position"); + break; + case SubPacket_user_tag: + DEBUG_MSG(" Payload:User"); + break; + case 0: + DEBUG_MSG(" Payload:None"); + break; + default: + DEBUG_MSG(" Payload:%d", s.which_payload); + break; + } + if (s.want_response) + DEBUG_MSG(" WANTRESP"); + + if (s.source != 0) + DEBUG_MSG(" source=%08x", s.source); + + if (s.dest != 0) + DEBUG_MSG(" dest=%08x", s.dest); + + if (s.which_ack == SubPacket_success_id_tag) + DEBUG_MSG(" successId=%08x", s.ack.success_id); + else if (s.which_ack == SubPacket_fail_id_tag) + DEBUG_MSG(" failId=%08x", s.ack.fail_id); + } else { + DEBUG_MSG(" encrypted"); + } + + if (p->rx_time != 0) { + DEBUG_MSG(" rxtime=%u", p->rx_time); + } + DEBUG_MSG(")\n"); +} + RadioInterface::RadioInterface() { assert(sizeof(PacketHeader) == 4 || sizeof(PacketHeader) == 16); // make sure the compiler did what we expected diff --git a/src/mesh/RadioInterface.h b/src/mesh/RadioInterface.h index 0617592ac..988034dbb 100644 --- a/src/mesh/RadioInterface.h +++ b/src/mesh/RadioInterface.h @@ -162,3 +162,6 @@ class SimRadio : public RadioInterface /// \return true if initialisation succeeded. virtual bool init() { return true; } }; + +/// Debug printing for packets +void printPacket(const char *prefix, const MeshPacket *p); \ No newline at end of file diff --git a/src/mesh/RadioLibInterface.cpp b/src/mesh/RadioLibInterface.cpp index 5239f8f60..8fb1ce781 100644 --- a/src/mesh/RadioLibInterface.cpp +++ b/src/mesh/RadioLibInterface.cpp @@ -114,8 +114,8 @@ bool RadioLibInterface::canSendImmediately() /// bluetooth comms code. If the txmit queue is empty it might return an error ErrorCode RadioLibInterface::send(MeshPacket *p) { - DEBUG_MSG("enqueuing for send on mesh fr=0x%x,to=0x%x,id=%d (txGood=%d,rxGood=%d,rxBad=%d)\n", p->from, p->to, p->id, txGood, - rxGood, rxBad); + printPacket("enqueuing for send", p); + DEBUG_MSG("txGood=%d,rxGood=%d,rxBad=%d\n", txGood, rxGood, rxBad); ErrorCode res = txQueue.enqueue(p, 0) ? ERRNO_OK : ERRNO_UNKNOWN; if (res != ERRNO_OK) { // we weren't able to queue it, so we must drop it to prevent leaks @@ -237,7 +237,7 @@ void RadioLibInterface::completeSending() { if (sendingPacket) { txGood++; - DEBUG_MSG("Completed sending to=0x%x, id=%u\n", sendingPacket->to, sendingPacket->id); + printPacket("Completed sending", sendingPacket); // We are done sending that packet, release it packetPool.release(sendingPacket); @@ -291,7 +291,7 @@ void RadioLibInterface::handleReceiveInterrupt() memcpy(mp->encrypted.bytes, payload, payloadLen); mp->encrypted.size = payloadLen; - DEBUG_MSG("Lora RX interrupt from=0x%x, id=%u\n", mp->from, mp->id); + printPacket("Lora RX", mp); deliverToReceiver(mp); } @@ -301,7 +301,7 @@ void RadioLibInterface::handleReceiveInterrupt() /** start an immediate transmit */ void RadioLibInterface::startSend(MeshPacket *txp) { - DEBUG_MSG("Starting low level send from=0x%x, to=0x%x, id=%u, want_ack=%d\n", txp->from, txp->to, txp->id, txp->want_ack); + printPacket("Starting low level send", txp); setStandby(); // Cancel any already in process receives size_t numbytes = beginSending(txp); diff --git a/src/mesh/ReliableRouter.cpp b/src/mesh/ReliableRouter.cpp index 3499c51b6..acec6b7f9 100644 --- a/src/mesh/ReliableRouter.cpp +++ b/src/mesh/ReliableRouter.cpp @@ -27,7 +27,7 @@ ErrorCode ReliableRouter::send(MeshPacket *p) bool ReliableRouter::shouldFilterReceived(const MeshPacket *p) { if (p->to == NODENUM_BROADCAST && p->from == getNodeNum()) { - DEBUG_MSG("Received someone rebroadcasting for us fr=0x%x,to=0x%x,id=%d\n", p->from, p->to, p->id); + printPacket("Rx someone rebroadcasting for us", p); // We are seeing someone rebroadcast one of our broadcast attempts. // If this is the first time we saw this, cancel any retransmissions we have queued up and generate an internal ack for diff --git a/src/mesh/Router.cpp b/src/mesh/Router.cpp index bbf03944f..444ccc7ad 100644 --- a/src/mesh/Router.cpp +++ b/src/mesh/Router.cpp @@ -150,8 +150,8 @@ ErrorCode Router::send(MeshPacket *p) */ void Router::sniffReceived(const MeshPacket *p) { - DEBUG_MSG("FIXME-update-db Sniffing packet fr=0x%x,to=0x%x,id=%d\n", p->from, p->to, p->id); - // FIXME, update nodedb + DEBUG_MSG("FIXME-update-db Sniffing packet\n"); + // FIXME, update nodedb here for any packet that passes through us } bool Router::perhapsDecode(MeshPacket *p) @@ -202,7 +202,7 @@ void Router::handleReceived(MeshPacket *p) sniffReceived(p); if (p->to == NODENUM_BROADCAST || p->to == getNodeNum()) { - DEBUG_MSG("Notifying observers of received packet fr=0x%x,to=0x%x,id=%d\n", p->from, p->to, p->id); + printPacket("Delivering rx packet", p); notifyPacketReceived.notifyObservers(p); } }