pohui_pohui/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2025-09-21 01:04:01 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Warnings and log cleanup (#5472)

Browse Source 
* Don't log if keyboard not found

* Signed comparison issue
This commit is contained in:
Ben Meadors 2024-11-28 11:20:06 -06:00 committed by Tom Fifield
parent 85d23d6988
commit b4ae5e399d
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gps/GPS.h
View File

@ -158,8 +158,8 @@ class GPS : private concurrency::OSThread
uint32_t rx_gpio = 0;
uint32_t tx_gpio = 0;
int speedSelect = 0;
int probeTries = 0;
uint8_t speedSelect = 0;
uint8_t probeTries = 0;
/**
* hasValidLocation - indicates that the position variables contain a complete
@ -239,4 +239,4 @@ class GPS : private concurrency::OSThread
};
extern GPS *gps;
#endif // Exclude GPS
#endif // Exclude GPS

3
src/input/cardKbI2cImpl.cpp
View File

@ -49,10 +49,11 @@ void CardKbI2cImpl::init()
kb_model = 0x00;
}
}
LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address);
if (cardkb_found.address == 0x00) {
disable();
return;
} else {
LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address);
}
}
#else