Warnings and log cleanup (#5472)

* Don't log if keyboard not found * Signed comparison issue
2025-04-23 09:06:02 +00:00 · 2024-11-28 11:20:06 -06:00 · 2024-11-28 11:20:06 -06:00 · b5777beb7d
commit b5777beb7d
parent 5ad30a55ea
2 changed files with 5 additions and 4 deletions
--- a/src/gps/GPS.h
+++ b/src/gps/GPS.h
@ -158,8 +158,8 @@ class GPS : private concurrency::OSThread
    uint32_t rx_gpio = 0;
    uint32_t tx_gpio = 0;

-    int speedSelect = 0;
-    int probeTries = 0;
+    uint8_t speedSelect = 0;
+    uint8_t probeTries = 0;

    /**
     * hasValidLocation - indicates that the position variables contain a complete
@ -239,4 +239,4 @@ class GPS : private concurrency::OSThread
 };

 extern GPS *gps;
-#endif // Exclude GPS
+#endif // Exclude GPS
--- a/src/input/cardKbI2cImpl.cpp
+++ b/src/input/cardKbI2cImpl.cpp
@ -49,10 +49,11 @@ void CardKbI2cImpl::init()
                kb_model = 0x00;
            }
        }
-        LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address);
        if (cardkb_found.address == 0x00) {
            disable();
            return;
+        } else {
+            LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address);
        }
    }
 #else