Call getMacAddr within pickNewNodeNum() (#2576)

It could be called from within NodeDB::init() before it is set
This commit is contained in:
GUVWAF 2023-06-27 02:26:12 +02:00 committed by GitHub
parent e677a02273
commit ccb682bbb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -290,9 +290,6 @@ void NodeDB::installDefaultDeviceState()
generatePacketId(); // FIXME - ugly way to init current_packet_id;
// Init our blank owner info to reasonable defaults
getMacAddr(ourMacAddr);
// Set default owner name
pickNewNodeNum(); // based on macaddr now
snprintf(owner.long_name, sizeof(owner.long_name), "Meshtastic %02x%02x", ourMacAddr[4], ourMacAddr[5]);
@ -378,6 +375,8 @@ void NodeDB::pickNewNodeNum()
{
NodeNum r = myNodeInfo.my_node_num;
getMacAddr(ourMacAddr); // Make sure ourMacAddr is set
// Pick an initial nodenum based on the macaddr
r = (ourMacAddr[2] << 24) | (ourMacAddr[3] << 16) | (ourMacAddr[4] << 8) | ourMacAddr[5];