mirror of
https://github.com/meshtastic/firmware.git
synced 2025-10-03 05:53:24 +00:00
Merge branch 'develop' into reduce_cpu_load
This commit is contained in:
commit
d9f0590f8e
@ -9,7 +9,7 @@ plugins:
|
|||||||
lint:
|
lint:
|
||||||
enabled:
|
enabled:
|
||||||
- checkov@3.2.471
|
- checkov@3.2.471
|
||||||
- renovate@41.125.3
|
- renovate@41.127.2
|
||||||
- prettier@3.6.2
|
- prettier@3.6.2
|
||||||
- trufflehog@3.90.8
|
- trufflehog@3.90.8
|
||||||
- yamllint@1.37.1
|
- yamllint@1.37.1
|
||||||
|
@ -1,7 +1,12 @@
|
|||||||
#include "FloodingRouter.h"
|
#include "FloodingRouter.h"
|
||||||
|
#include "MeshTypes.h"
|
||||||
|
#include "NodeDB.h"
|
||||||
#include "configuration.h"
|
#include "configuration.h"
|
||||||
#include "mesh-pb-constants.h"
|
#include "mesh-pb-constants.h"
|
||||||
|
#include "meshUtils.h"
|
||||||
|
#if !MESHTASTIC_EXCLUDE_TRACEROUTE
|
||||||
|
#include "modules/TraceRouteModule.h"
|
||||||
|
#endif
|
||||||
|
|
||||||
FloodingRouter::FloodingRouter() {}
|
FloodingRouter::FloodingRouter() {}
|
||||||
|
|
||||||
@ -21,7 +26,37 @@ ErrorCode FloodingRouter::send(meshtastic_MeshPacket *p)
|
|||||||
|
|
||||||
bool FloodingRouter::shouldFilterReceived(const meshtastic_MeshPacket *p)
|
bool FloodingRouter::shouldFilterReceived(const meshtastic_MeshPacket *p)
|
||||||
{
|
{
|
||||||
if (wasSeenRecently(p)) { // Note: this will also add a recent packet record
|
bool wasUpgraded = false;
|
||||||
|
bool seenRecently =
|
||||||
|
wasSeenRecently(p, true, nullptr, nullptr, &wasUpgraded); // Updates history; returns false when an upgrade is detected
|
||||||
|
|
||||||
|
// Handle hop_limit upgrade scenario for rebroadcasters
|
||||||
|
// isRebroadcaster() is duplicated in perhapsRebroadcast(), but this avoids confusing log messages
|
||||||
|
if (wasUpgraded && isRebroadcaster() && iface && p->hop_limit > 0) {
|
||||||
|
// wasSeenRecently() reports false in upgrade cases so we handle replacement before the duplicate short-circuit
|
||||||
|
// If we overhear a duplicate copy of the packet with more hops left than the one we are waiting to
|
||||||
|
// rebroadcast, then remove the packet currently sitting in the TX queue and use this one instead.
|
||||||
|
uint8_t dropThreshold = p->hop_limit; // remove queued packets that have fewer hops remaining
|
||||||
|
if (iface->removePendingTXPacket(getFrom(p), p->id, dropThreshold)) {
|
||||||
|
LOG_DEBUG("Processing upgraded packet 0x%08x for rebroadcast with hop limit %d (dropping queued < %d)", p->id,
|
||||||
|
p->hop_limit, dropThreshold);
|
||||||
|
|
||||||
|
if (nodeDB)
|
||||||
|
nodeDB->updateFrom(*p);
|
||||||
|
#if !MESHTASTIC_EXCLUDE_TRACEROUTE
|
||||||
|
if (traceRouteModule && p->which_payload_variant == meshtastic_MeshPacket_decoded_tag &&
|
||||||
|
p->decoded.portnum == meshtastic_PortNum_TRACEROUTE_APP)
|
||||||
|
traceRouteModule->processUpgradedPacket(*p);
|
||||||
|
#endif
|
||||||
|
|
||||||
|
perhapsRebroadcast(p);
|
||||||
|
|
||||||
|
// We already enqueued the improved copy, so make sure the incoming packet stops here.
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (seenRecently) {
|
||||||
printPacket("Ignore dupe incoming msg", p);
|
printPacket("Ignore dupe incoming msg", p);
|
||||||
rxDupe++;
|
rxDupe++;
|
||||||
|
|
||||||
@ -90,7 +125,12 @@ void FloodingRouter::perhapsRebroadcast(const meshtastic_MeshPacket *p)
|
|||||||
if (isRebroadcaster()) {
|
if (isRebroadcaster()) {
|
||||||
meshtastic_MeshPacket *tosend = packetPool.allocCopy(*p); // keep a copy because we will be sending it
|
meshtastic_MeshPacket *tosend = packetPool.allocCopy(*p); // keep a copy because we will be sending it
|
||||||
|
|
||||||
tosend->hop_limit--; // bump down the hop count
|
// Use shared logic to determine if hop_limit should be decremented
|
||||||
|
if (shouldDecrementHopLimit(p)) {
|
||||||
|
tosend->hop_limit--; // bump down the hop count
|
||||||
|
} else {
|
||||||
|
LOG_INFO("favorite-ROUTER/CLIENT_BASE-to-ROUTER/CLIENT_BASE flood: preserving hop_limit");
|
||||||
|
}
|
||||||
#if USERPREFS_EVENT_MODE
|
#if USERPREFS_EVENT_MODE
|
||||||
if (tosend->hop_limit > 2) {
|
if (tosend->hop_limit > 2) {
|
||||||
// if we are "correcting" the hop_limit, "correct" the hop_start by the same amount to preserve hops away.
|
// if we are "correcting" the hop_limit, "correct" the hop_start by the same amount to preserve hops away.
|
||||||
@ -98,6 +138,7 @@ void FloodingRouter::perhapsRebroadcast(const meshtastic_MeshPacket *p)
|
|||||||
tosend->hop_limit = 2;
|
tosend->hop_limit = 2;
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
tosend->next_hop = NO_NEXT_HOP_PREFERENCE; // this should already be the case, but just in case
|
tosend->next_hop = NO_NEXT_HOP_PREFERENCE; // this should already be the case, but just in case
|
||||||
|
|
||||||
LOG_INFO("Rebroadcast received floodmsg");
|
LOG_INFO("Rebroadcast received floodmsg");
|
||||||
@ -127,4 +168,4 @@ void FloodingRouter::sniffReceived(const meshtastic_MeshPacket *p, const meshtas
|
|||||||
|
|
||||||
// handle the packet as normal
|
// handle the packet as normal
|
||||||
Router::sniffReceived(p, c);
|
Router::sniffReceived(p, c);
|
||||||
}
|
}
|
||||||
|
@ -155,7 +155,7 @@ template <typename T> bool LR11x0Interface<T>::reconfigure()
|
|||||||
if (err != RADIOLIB_ERR_NONE)
|
if (err != RADIOLIB_ERR_NONE)
|
||||||
RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
|
RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
|
||||||
|
|
||||||
err = lora.setBandwidth(bw);
|
err = lora.setBandwidth(bw, wideLora() && (getFreq() > 1000.0f));
|
||||||
if (err != RADIOLIB_ERR_NONE)
|
if (err != RADIOLIB_ERR_NONE)
|
||||||
RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
|
RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
|
||||||
|
|
||||||
|
@ -103,12 +103,26 @@ meshtastic_MeshPacket *MeshPacketQueue::getFront()
|
|||||||
return p;
|
return p;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** Attempt to find and remove a packet from this queue. Returns a pointer to the removed packet, or NULL if not found */
|
/** Get a packet from this queue. Returns a pointer to the packet, or NULL if not found. */
|
||||||
meshtastic_MeshPacket *MeshPacketQueue::remove(NodeNum from, PacketId id, bool tx_normal, bool tx_late)
|
meshtastic_MeshPacket *MeshPacketQueue::getPacketFromQueue(NodeNum from, PacketId id)
|
||||||
{
|
{
|
||||||
for (auto it = queue.begin(); it != queue.end(); it++) {
|
for (auto it = queue.begin(); it != queue.end(); it++) {
|
||||||
auto p = (*it);
|
auto p = (*it);
|
||||||
if (getFrom(p) == from && p->id == id && ((tx_normal && !p->tx_after) || (tx_late && p->tx_after))) {
|
if (getFrom(p) == from && p->id == id) {
|
||||||
|
return p;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Attempt to find and remove a packet from this queue. Returns a pointer to the removed packet, or NULL if not found */
|
||||||
|
meshtastic_MeshPacket *MeshPacketQueue::remove(NodeNum from, PacketId id, bool tx_normal, bool tx_late, uint8_t hop_limit_lt)
|
||||||
|
{
|
||||||
|
for (auto it = queue.begin(); it != queue.end(); it++) {
|
||||||
|
auto p = (*it);
|
||||||
|
if (getFrom(p) == from && p->id == id && ((tx_normal && !p->tx_after) || (tx_late && p->tx_after)) &&
|
||||||
|
(!hop_limit_lt || p->hop_limit < hop_limit_lt)) {
|
||||||
queue.erase(it);
|
queue.erase(it);
|
||||||
return p;
|
return p;
|
||||||
}
|
}
|
||||||
@ -120,14 +134,7 @@ meshtastic_MeshPacket *MeshPacketQueue::remove(NodeNum from, PacketId id, bool t
|
|||||||
/* Attempt to find a packet from this queue. Return true if it was found. */
|
/* Attempt to find a packet from this queue. Return true if it was found. */
|
||||||
bool MeshPacketQueue::find(const NodeNum from, const PacketId id)
|
bool MeshPacketQueue::find(const NodeNum from, const PacketId id)
|
||||||
{
|
{
|
||||||
for (auto it = queue.begin(); it != queue.end(); it++) {
|
return getPacketFromQueue(from, id) != NULL;
|
||||||
const auto *p = *it;
|
|
||||||
if (getFrom(p) == from && p->id == id) {
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return false;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -35,8 +35,12 @@ class MeshPacketQueue
|
|||||||
|
|
||||||
meshtastic_MeshPacket *getFront();
|
meshtastic_MeshPacket *getFront();
|
||||||
|
|
||||||
|
/** Get a packet from this queue. Returns a pointer to the packet, or NULL if not found. */
|
||||||
|
meshtastic_MeshPacket *getPacketFromQueue(NodeNum from, PacketId id);
|
||||||
|
|
||||||
/** Attempt to find and remove a packet from this queue. Returns the packet which was removed from the queue */
|
/** Attempt to find and remove a packet from this queue. Returns the packet which was removed from the queue */
|
||||||
meshtastic_MeshPacket *remove(NodeNum from, PacketId id, bool tx_normal = true, bool tx_late = true);
|
meshtastic_MeshPacket *remove(NodeNum from, PacketId id, bool tx_normal = true, bool tx_late = true,
|
||||||
|
uint8_t hop_limit_lt = 0);
|
||||||
|
|
||||||
/* Attempt to find a packet from this queue. Return true if it was found. */
|
/* Attempt to find a packet from this queue. Return true if it was found. */
|
||||||
bool find(const NodeNum from, const PacketId id);
|
bool find(const NodeNum from, const PacketId id);
|
||||||
|
@ -453,4 +453,4 @@ uint32_t MeshService::GetTimeSinceMeshPacket(const meshtastic_MeshPacket *mp)
|
|||||||
delta = 0;
|
delta = 0;
|
||||||
|
|
||||||
return delta;
|
return delta;
|
||||||
}
|
}
|
||||||
|
@ -190,4 +190,4 @@ class MeshService
|
|||||||
friend class RoutingModule;
|
friend class RoutingModule;
|
||||||
};
|
};
|
||||||
|
|
||||||
extern MeshService *service;
|
extern MeshService *service;
|
||||||
|
@ -1,4 +1,10 @@
|
|||||||
#include "NextHopRouter.h"
|
#include "NextHopRouter.h"
|
||||||
|
#include "MeshTypes.h"
|
||||||
|
#include "meshUtils.h"
|
||||||
|
#if !MESHTASTIC_EXCLUDE_TRACEROUTE
|
||||||
|
#include "modules/TraceRouteModule.h"
|
||||||
|
#endif
|
||||||
|
#include "NodeDB.h"
|
||||||
|
|
||||||
NextHopRouter::NextHopRouter() {}
|
NextHopRouter::NextHopRouter() {}
|
||||||
|
|
||||||
@ -32,7 +38,35 @@ bool NextHopRouter::shouldFilterReceived(const meshtastic_MeshPacket *p)
|
|||||||
{
|
{
|
||||||
bool wasFallback = false;
|
bool wasFallback = false;
|
||||||
bool weWereNextHop = false;
|
bool weWereNextHop = false;
|
||||||
if (wasSeenRecently(p, true, &wasFallback, &weWereNextHop)) { // Note: this will also add a recent packet record
|
bool wasUpgraded = false;
|
||||||
|
bool seenRecently = wasSeenRecently(p, true, &wasFallback, &weWereNextHop,
|
||||||
|
&wasUpgraded); // Updates history; returns false when an upgrade is detected
|
||||||
|
|
||||||
|
// Handle hop_limit upgrade scenario for rebroadcasters
|
||||||
|
// isRebroadcaster() is duplicated in perhapsRelay(), but this avoids confusing log messages
|
||||||
|
if (wasUpgraded && isRebroadcaster() && iface && p->hop_limit > 0) {
|
||||||
|
// Upgrade detection bypasses the duplicate short-circuit so we replace the queued packet before exiting
|
||||||
|
uint8_t dropThreshold = p->hop_limit; // remove queued packets that have fewer hops remaining
|
||||||
|
if (iface->removePendingTXPacket(getFrom(p), p->id, dropThreshold)) {
|
||||||
|
LOG_DEBUG("Processing upgraded packet 0x%08x for relay with hop limit %d (dropping queued < %d)", p->id, p->hop_limit,
|
||||||
|
dropThreshold);
|
||||||
|
|
||||||
|
if (nodeDB)
|
||||||
|
nodeDB->updateFrom(*p);
|
||||||
|
#if !MESHTASTIC_EXCLUDE_TRACEROUTE
|
||||||
|
if (traceRouteModule && p->which_payload_variant == meshtastic_MeshPacket_decoded_tag &&
|
||||||
|
p->decoded.portnum == meshtastic_PortNum_TRACEROUTE_APP)
|
||||||
|
traceRouteModule->processUpgradedPacket(*p);
|
||||||
|
#endif
|
||||||
|
|
||||||
|
perhapsRelay(p);
|
||||||
|
|
||||||
|
// We already enqueued the improved copy, so make sure the incoming packet stops here.
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (seenRecently) {
|
||||||
printPacket("Ignore dupe incoming msg", p);
|
printPacket("Ignore dupe incoming msg", p);
|
||||||
|
|
||||||
if (p->transport_mechanism == meshtastic_MeshPacket_TransportMechanism_TRANSPORT_LORA) {
|
if (p->transport_mechanism == meshtastic_MeshPacket_TransportMechanism_TRANSPORT_LORA) {
|
||||||
@ -108,7 +142,13 @@ bool NextHopRouter::perhapsRelay(const meshtastic_MeshPacket *p)
|
|||||||
meshtastic_MeshPacket *tosend = packetPool.allocCopy(*p); // keep a copy because we will be sending it
|
meshtastic_MeshPacket *tosend = packetPool.allocCopy(*p); // keep a copy because we will be sending it
|
||||||
LOG_INFO("Relaying received message coming from %x", p->relay_node);
|
LOG_INFO("Relaying received message coming from %x", p->relay_node);
|
||||||
|
|
||||||
tosend->hop_limit--; // bump down the hop count
|
// Use shared logic to determine if hop_limit should be decremented
|
||||||
|
if (shouldDecrementHopLimit(p)) {
|
||||||
|
tosend->hop_limit--; // bump down the hop count
|
||||||
|
} else {
|
||||||
|
LOG_INFO("Router/CLIENT_BASE-to-favorite-router/CLIENT_BASE relay: preserving hop_limit");
|
||||||
|
}
|
||||||
|
|
||||||
NextHopRouter::send(tosend);
|
NextHopRouter::send(tosend);
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
@ -291,4 +331,4 @@ void NextHopRouter::setNextTx(PendingPacket *pending)
|
|||||||
LOG_DEBUG("Setting next retransmission in %u msecs: ", d);
|
LOG_DEBUG("Setting next retransmission in %u msecs: ", d);
|
||||||
printPacket("", pending->packet);
|
printPacket("", pending->packet);
|
||||||
setReceivedMessage(); // Run ASAP, so we can figure out our correct sleep time
|
setReceivedMessage(); // Run ASAP, so we can figure out our correct sleep time
|
||||||
}
|
}
|
||||||
|
@ -45,7 +45,8 @@ PacketHistory::~PacketHistory()
|
|||||||
}
|
}
|
||||||
|
|
||||||
/** Update recentPackets and return true if we have already seen this packet */
|
/** Update recentPackets and return true if we have already seen this packet */
|
||||||
bool PacketHistory::wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpdate, bool *wasFallback, bool *weWereNextHop)
|
bool PacketHistory::wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpdate, bool *wasFallback, bool *weWereNextHop,
|
||||||
|
bool *wasUpgraded)
|
||||||
{
|
{
|
||||||
if (!initOk()) {
|
if (!initOk()) {
|
||||||
LOG_ERROR("Packet History - Was Seen Recently: NOT INITIALIZED!");
|
LOG_ERROR("Packet History - Was Seen Recently: NOT INITIALIZED!");
|
||||||
@ -66,6 +67,7 @@ bool PacketHistory::wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpd
|
|||||||
r.id = p->id;
|
r.id = p->id;
|
||||||
r.sender = getFrom(p); // If 0 then use our ID
|
r.sender = getFrom(p); // If 0 then use our ID
|
||||||
r.next_hop = p->next_hop;
|
r.next_hop = p->next_hop;
|
||||||
|
r.hop_limit = p->hop_limit;
|
||||||
r.relayed_by[0] = p->relay_node;
|
r.relayed_by[0] = p->relay_node;
|
||||||
|
|
||||||
r.rxTimeMsec = millis(); //
|
r.rxTimeMsec = millis(); //
|
||||||
@ -81,6 +83,16 @@ bool PacketHistory::wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpd
|
|||||||
PacketRecord *found = find(r.sender, r.id); // Find the packet record in the recentPackets array
|
PacketRecord *found = find(r.sender, r.id); // Find the packet record in the recentPackets array
|
||||||
bool seenRecently = (found != NULL); // If found -> the packet was seen recently
|
bool seenRecently = (found != NULL); // If found -> the packet was seen recently
|
||||||
|
|
||||||
|
// Check for hop_limit upgrade scenario
|
||||||
|
if (seenRecently && wasUpgraded && found->hop_limit < p->hop_limit) {
|
||||||
|
LOG_DEBUG("Packet History - Hop limit upgrade: packet 0x%08x from hop_limit=%d to hop_limit=%d", p->id, found->hop_limit,
|
||||||
|
p->hop_limit);
|
||||||
|
*wasUpgraded = true;
|
||||||
|
seenRecently = false; // Allow router processing but prevent duplicate app delivery
|
||||||
|
} else if (wasUpgraded) {
|
||||||
|
*wasUpgraded = false; // Initialize to false if not an upgrade
|
||||||
|
}
|
||||||
|
|
||||||
if (seenRecently) {
|
if (seenRecently) {
|
||||||
uint8_t ourRelayID = nodeDB->getLastByteOfNodeNum(nodeDB->getNodeNum()); // Get our relay ID from our node number
|
uint8_t ourRelayID = nodeDB->getLastByteOfNodeNum(nodeDB->getNodeNum()); // Get our relay ID from our node number
|
||||||
|
|
||||||
@ -126,6 +138,11 @@ bool PacketHistory::wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpd
|
|||||||
millis() - found->rxTimeMsec);
|
millis() - found->rxTimeMsec);
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
// Preserve the highest hop_limit we've ever seen for this packet so upgrades aren't lost when a later copy has
|
||||||
|
// fewer hops remaining.
|
||||||
|
if (found->hop_limit > r.hop_limit)
|
||||||
|
r.hop_limit = found->hop_limit;
|
||||||
|
|
||||||
// Add the existing relayed_by to the new record
|
// Add the existing relayed_by to the new record
|
||||||
for (uint8_t i = 0; i < (NUM_RELAYERS - 1); i++) {
|
for (uint8_t i = 0; i < (NUM_RELAYERS - 1); i++) {
|
||||||
if (found->relayed_by[i] != 0)
|
if (found->relayed_by[i] != 0)
|
||||||
|
@ -16,8 +16,9 @@ class PacketHistory
|
|||||||
PacketId id;
|
PacketId id;
|
||||||
uint32_t rxTimeMsec; // Unix time in msecs - the time we received it, 0 means empty
|
uint32_t rxTimeMsec; // Unix time in msecs - the time we received it, 0 means empty
|
||||||
uint8_t next_hop; // The next hop asked for this packet
|
uint8_t next_hop; // The next hop asked for this packet
|
||||||
|
uint8_t hop_limit; // Highest hop limit observed for this packet
|
||||||
uint8_t relayed_by[NUM_RELAYERS]; // Array of nodes that relayed this packet
|
uint8_t relayed_by[NUM_RELAYERS]; // Array of nodes that relayed this packet
|
||||||
}; // 4B + 4B + 4B + 1B + 3B = 16B
|
}; // 4B + 4B + 4B + 1B + 1B + 3B = 17B (will be padded to 20B)
|
||||||
|
|
||||||
uint32_t recentPacketsCapacity =
|
uint32_t recentPacketsCapacity =
|
||||||
0; // Can be set in constructor, no need to recompile. Used to allocate memory for mx_recentPackets.
|
0; // Can be set in constructor, no need to recompile. Used to allocate memory for mx_recentPackets.
|
||||||
@ -50,9 +51,10 @@ class PacketHistory
|
|||||||
* @param withUpdate if true and not found we add an entry to recentPackets
|
* @param withUpdate if true and not found we add an entry to recentPackets
|
||||||
* @param wasFallback if not nullptr, packet will be checked for fallback to flooding and value will be set to true if so
|
* @param wasFallback if not nullptr, packet will be checked for fallback to flooding and value will be set to true if so
|
||||||
* @param weWereNextHop if not nullptr, packet will be checked for us being the next hop and value will be set to true if so
|
* @param weWereNextHop if not nullptr, packet will be checked for us being the next hop and value will be set to true if so
|
||||||
|
* @param wasUpgraded if not nullptr, will be set to true if this packet has better hop_limit than previously seen
|
||||||
*/
|
*/
|
||||||
bool wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpdate = true, bool *wasFallback = nullptr,
|
bool wasSeenRecently(const meshtastic_MeshPacket *p, bool withUpdate = true, bool *wasFallback = nullptr,
|
||||||
bool *weWereNextHop = nullptr);
|
bool *weWereNextHop = nullptr, bool *wasUpgraded = nullptr);
|
||||||
|
|
||||||
/* Check if a certain node was a relayer of a packet in the history given an ID and sender
|
/* Check if a certain node was a relayer of a packet in the history given an ID and sender
|
||||||
* If wasSole is not nullptr, it will be set to true if the relayer was the only relayer of that packet
|
* If wasSole is not nullptr, it will be set to true if the relayer was the only relayer of that packet
|
||||||
|
@ -189,6 +189,12 @@ class RadioInterface
|
|||||||
/** If the packet is not already in the late rebroadcast window, move it there */
|
/** If the packet is not already in the late rebroadcast window, move it there */
|
||||||
virtual void clampToLateRebroadcastWindow(NodeNum from, PacketId id) { return; }
|
virtual void clampToLateRebroadcastWindow(NodeNum from, PacketId id) { return; }
|
||||||
|
|
||||||
|
/**
|
||||||
|
* If there is a packet pending TX in the queue with a worse hop limit, remove it pending replacement with a better version
|
||||||
|
* @return Whether a pending packet was removed
|
||||||
|
*/
|
||||||
|
virtual bool removePendingTXPacket(NodeNum from, PacketId id, uint32_t hop_limit_lt) { return false; }
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Calculate airtime per
|
* Calculate airtime per
|
||||||
* https://www.rs-online.com/designspark/rel-assets/ds-assets/uploads/knowledge-items/application-notes-for-the-internet-of-things/LoRa%20Design%20Guide.pdf
|
* https://www.rs-online.com/designspark/rel-assets/ds-assets/uploads/knowledge-items/application-notes-for-the-internet-of-things/LoRa%20Design%20Guide.pdf
|
||||||
@ -266,4 +272,4 @@ class RadioInterface
|
|||||||
};
|
};
|
||||||
|
|
||||||
/// Debug printing for packets
|
/// Debug printing for packets
|
||||||
void printPacket(const char *prefix, const meshtastic_MeshPacket *p);
|
void printPacket(const char *prefix, const meshtastic_MeshPacket *p);
|
||||||
|
@ -362,6 +362,26 @@ void RadioLibInterface::clampToLateRebroadcastWindow(NodeNum from, PacketId id)
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* If there is a packet pending TX in the queue with a worse hop limit, remove it pending replacement with a better version
|
||||||
|
* @return Whether a pending packet was removed
|
||||||
|
*/
|
||||||
|
bool RadioLibInterface::removePendingTXPacket(NodeNum from, PacketId id, uint32_t hop_limit_lt)
|
||||||
|
{
|
||||||
|
meshtastic_MeshPacket *p = txQueue.remove(from, id, true, true, hop_limit_lt);
|
||||||
|
if (p) {
|
||||||
|
LOG_DEBUG("Dropping pending-TX packet 0x%08x with hop limit %d", p->id, p->hop_limit);
|
||||||
|
packetPool.release(p);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Remove a packet that is eligible for replacement from the TX queue
|
||||||
|
*/
|
||||||
|
// void RadioLibInterface::removePending
|
||||||
|
|
||||||
void RadioLibInterface::handleTransmitInterrupt()
|
void RadioLibInterface::handleTransmitInterrupt()
|
||||||
{
|
{
|
||||||
// This can be null if we forced the device to enter standby mode. In that case
|
// This can be null if we forced the device to enter standby mode. In that case
|
||||||
|
@ -215,4 +215,11 @@ class RadioLibInterface : public RadioInterface, protected concurrency::Notified
|
|||||||
* If the packet is not already in the late rebroadcast window, move it there
|
* If the packet is not already in the late rebroadcast window, move it there
|
||||||
*/
|
*/
|
||||||
void clampToLateRebroadcastWindow(NodeNum from, PacketId id);
|
void clampToLateRebroadcastWindow(NodeNum from, PacketId id);
|
||||||
};
|
|
||||||
|
/**
|
||||||
|
* If there is a packet pending TX in the queue with a worse hop limit, remove it pending replacement with a better version
|
||||||
|
* @return Whether a pending packet was removed
|
||||||
|
*/
|
||||||
|
|
||||||
|
bool removePendingTXPacket(NodeNum from, PacketId id, uint32_t hop_limit_lt) override;
|
||||||
|
};
|
||||||
|
@ -69,6 +69,58 @@ Router::Router() : concurrency::OSThread("Router"), fromRadioQueue(MAX_RX_FROMRA
|
|||||||
cryptLock = new concurrency::Lock();
|
cryptLock = new concurrency::Lock();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
bool Router::shouldDecrementHopLimit(const meshtastic_MeshPacket *p)
|
||||||
|
{
|
||||||
|
// First hop MUST always decrement to prevent retry issues
|
||||||
|
bool isFirstHop = (p->hop_start != 0 && p->hop_start == p->hop_limit);
|
||||||
|
if (isFirstHop) {
|
||||||
|
return true; // Always decrement on first hop
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if both local device and previous relay are routers (including CLIENT_BASE)
|
||||||
|
bool localIsRouter =
|
||||||
|
IS_ONE_OF(config.device.role, meshtastic_Config_DeviceConfig_Role_ROUTER, meshtastic_Config_DeviceConfig_Role_ROUTER_LATE,
|
||||||
|
meshtastic_Config_DeviceConfig_Role_CLIENT_BASE);
|
||||||
|
|
||||||
|
// If local device isn't a router, always decrement
|
||||||
|
if (!localIsRouter) {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
// For subsequent hops, check if previous relay is a favorite router
|
||||||
|
// Optimized search for favorite routers with matching last byte
|
||||||
|
// Check ordering optimized for IoT devices (cheapest checks first)
|
||||||
|
for (int i = 0; i < nodeDB->getNumMeshNodes(); i++) {
|
||||||
|
meshtastic_NodeInfoLite *node = nodeDB->getMeshNodeByIndex(i);
|
||||||
|
if (!node)
|
||||||
|
continue;
|
||||||
|
|
||||||
|
// Check 1: is_favorite (cheapest - single bool)
|
||||||
|
if (!node->is_favorite)
|
||||||
|
continue;
|
||||||
|
|
||||||
|
// Check 2: has_user (cheap - single bool)
|
||||||
|
if (!node->has_user)
|
||||||
|
continue;
|
||||||
|
|
||||||
|
// Check 3: role check (moderate cost - multiple comparisons)
|
||||||
|
if (!IS_ONE_OF(node->user.role, meshtastic_Config_DeviceConfig_Role_ROUTER,
|
||||||
|
meshtastic_Config_DeviceConfig_Role_ROUTER_LATE, meshtastic_Config_DeviceConfig_Role_CLIENT_BASE)) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check 4: last byte extraction and comparison (most expensive)
|
||||||
|
if (nodeDB->getLastByteOfNodeNum(node->num) == p->relay_node) {
|
||||||
|
// Found a favorite router match
|
||||||
|
LOG_DEBUG("Identified favorite relay router 0x%x from last byte 0x%x", node->num, p->relay_node);
|
||||||
|
return false; // Don't decrement hop_limit
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// No favorite router match found, decrement hop_limit
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* do idle processing
|
* do idle processing
|
||||||
* Mostly looking in our incoming rxPacket queue and calling handleReceived.
|
* Mostly looking in our incoming rxPacket queue and calling handleReceived.
|
||||||
|
@ -104,6 +104,18 @@ class Router : protected concurrency::OSThread, protected PacketHistory
|
|||||||
*/
|
*/
|
||||||
virtual bool shouldFilterReceived(const meshtastic_MeshPacket *p) { return false; }
|
virtual bool shouldFilterReceived(const meshtastic_MeshPacket *p) { return false; }
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Determine if hop_limit should be decremented for a relay operation.
|
||||||
|
* Returns false (preserve hop_limit) only if all conditions are met:
|
||||||
|
* - It's NOT the first hop (first hop must always decrement)
|
||||||
|
* - Local device is a ROUTER, ROUTER_LATE, or CLIENT_BASE
|
||||||
|
* - Previous relay is a favorite ROUTER, ROUTER_LATE, or CLIENT_BASE
|
||||||
|
*
|
||||||
|
* @param p The packet being relayed
|
||||||
|
* @return true if hop_limit should be decremented, false to preserve it
|
||||||
|
*/
|
||||||
|
bool shouldDecrementHopLimit(const meshtastic_MeshPacket *p);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Every (non duplicate) packet this node receives will be passed through this method. This allows subclasses to
|
* Every (non duplicate) packet this node receives will be passed through this method. This allows subclasses to
|
||||||
* update routing tables etc... based on what we overhear (even for messages not destined to our node)
|
* update routing tables etc... based on what we overhear (even for messages not destined to our node)
|
||||||
@ -162,4 +174,4 @@ PacketId generatePacketId();
|
|||||||
#define BITFIELD_WANT_RESPONSE_SHIFT 1
|
#define BITFIELD_WANT_RESPONSE_SHIFT 1
|
||||||
#define BITFIELD_OK_TO_MQTT_SHIFT 0
|
#define BITFIELD_OK_TO_MQTT_SHIFT 0
|
||||||
#define BITFIELD_WANT_RESPONSE_MASK (1 << BITFIELD_WANT_RESPONSE_SHIFT)
|
#define BITFIELD_WANT_RESPONSE_MASK (1 << BITFIELD_WANT_RESPONSE_SHIFT)
|
||||||
#define BITFIELD_OK_TO_MQTT_MASK (1 << BITFIELD_OK_TO_MQTT_SHIFT)
|
#define BITFIELD_OK_TO_MQTT_MASK (1 << BITFIELD_OK_TO_MQTT_SHIFT)
|
||||||
|
@ -13,6 +13,7 @@ ProcessMessage TextMessageModule::handleReceived(const meshtastic_MeshPacket &mp
|
|||||||
auto &p = mp.decoded;
|
auto &p = mp.decoded;
|
||||||
LOG_INFO("Received text msg from=0x%0x, id=0x%x, msg=%.*s", mp.from, mp.id, p.payload.size, p.payload.bytes);
|
LOG_INFO("Received text msg from=0x%0x, id=0x%x, msg=%.*s", mp.from, mp.id, p.payload.size, p.payload.bytes);
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
// We only store/display messages destined for us.
|
// We only store/display messages destined for us.
|
||||||
// Keep a copy of the most recent text message.
|
// Keep a copy of the most recent text message.
|
||||||
devicestate.rx_text_message = mp;
|
devicestate.rx_text_message = mp;
|
||||||
@ -30,4 +31,4 @@ ProcessMessage TextMessageModule::handleReceived(const meshtastic_MeshPacket &mp
|
|||||||
bool TextMessageModule::wantPacket(const meshtastic_MeshPacket *p)
|
bool TextMessageModule::wantPacket(const meshtastic_MeshPacket *p)
|
||||||
{
|
{
|
||||||
return MeshService::isTextPayload(p);
|
return MeshService::isTextPayload(p);
|
||||||
}
|
}
|
||||||
|
@ -153,6 +153,20 @@ void TraceRouteModule::alterReceivedProtobuf(meshtastic_MeshPacket &p, meshtasti
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
void TraceRouteModule::processUpgradedPacket(const meshtastic_MeshPacket &mp)
|
||||||
|
{
|
||||||
|
if (mp.which_payload_variant != meshtastic_MeshPacket_decoded_tag || mp.decoded.portnum != meshtastic_PortNum_TRACEROUTE_APP)
|
||||||
|
return;
|
||||||
|
|
||||||
|
meshtastic_RouteDiscovery decoded = meshtastic_RouteDiscovery_init_zero;
|
||||||
|
if (!pb_decode_from_bytes(mp.decoded.payload.bytes, mp.decoded.payload.size, &meshtastic_RouteDiscovery_msg, &decoded))
|
||||||
|
return;
|
||||||
|
|
||||||
|
handleReceivedProtobuf(mp, &decoded);
|
||||||
|
// Intentionally modify the packet in-place so downstream relays see our updates.
|
||||||
|
alterReceivedProtobuf(const_cast<meshtastic_MeshPacket &>(mp), &decoded);
|
||||||
|
}
|
||||||
|
|
||||||
void TraceRouteModule::insertUnknownHops(meshtastic_MeshPacket &p, meshtastic_RouteDiscovery *r, bool isTowardsDestination)
|
void TraceRouteModule::insertUnknownHops(meshtastic_MeshPacket &p, meshtastic_RouteDiscovery *r, bool isTowardsDestination)
|
||||||
{
|
{
|
||||||
pb_size_t *route_count;
|
pb_size_t *route_count;
|
||||||
@ -760,4 +774,4 @@ int32_t TraceRouteModule::runOnce()
|
|||||||
}
|
}
|
||||||
|
|
||||||
return INT32_MAX;
|
return INT32_MAX;
|
||||||
}
|
}
|
||||||
|
@ -35,6 +35,8 @@ class TraceRouteModule : public ProtobufModule<meshtastic_RouteDiscovery>,
|
|||||||
virtual bool wantUIFrame() override { return shouldDraw(); }
|
virtual bool wantUIFrame() override { return shouldDraw(); }
|
||||||
virtual Observable<const UIFrameEvent *> *getUIFrameObservable() override { return this; }
|
virtual Observable<const UIFrameEvent *> *getUIFrameObservable() override { return this; }
|
||||||
|
|
||||||
|
void processUpgradedPacket(const meshtastic_MeshPacket &mp);
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
bool handleReceivedProtobuf(const meshtastic_MeshPacket &mp, meshtastic_RouteDiscovery *r) override;
|
bool handleReceivedProtobuf(const meshtastic_MeshPacket &mp, meshtastic_RouteDiscovery *r) override;
|
||||||
|
|
||||||
@ -70,4 +72,4 @@ class TraceRouteModule : public ProtobufModule<meshtastic_RouteDiscovery>,
|
|||||||
bool initialized = false;
|
bool initialized = false;
|
||||||
};
|
};
|
||||||
|
|
||||||
extern TraceRouteModule *traceRouteModule;
|
extern TraceRouteModule *traceRouteModule;
|
||||||
|
Loading…
Reference in New Issue
Block a user