From da8a3a328e234b16e438767963203b436800b994 Mon Sep 17 00:00:00 2001 From: ford-jones Date: Fri, 10 Oct 2025 22:16:11 +1300 Subject: [PATCH] Fix equality check, use existing macro for role validation --- src/mesh/NodeDB.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index 639e5bc45..b3e96da22 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -402,10 +402,9 @@ NodeDB::NodeDB() config.position.gps_mode = meshtastic_Config_PositionConfig_GpsMode_ENABLED; config.position.gps_enabled = 0; } - if (config.device.role == meshtastic_Config_DeviceConfig_Role_CLIENT_BASE || - config.device.role == meshtastic_Config_DeviceConfig_Role_ROUTER || - config.device.role == meshtastic_Config_DeviceConfig_Role_ROUTER_LATE) { - saveFavourites == true; + if (IS_ONE_OF(config.device.role, meshtastic_Config_DeviceConfig_Role_CLIENT_BASE, meshtastic_Config_DeviceConfig_Role_ROUTER, + meshtastic_Config_DeviceConfig_Role_ROUTER_LATE)) { + saveFavourites = true; } #ifdef USERPREFS_FIRMWARE_EDITION myNodeInfo.firmware_edition = USERPREFS_FIRMWARE_EDITION;