pohui_pohui/firmware
1
0
Fork 0
mirror of https://github.com/meshtastic/firmware.git synced 2025-06-22 21:14:50 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Don't use assert() in MeshService to guard queueing packets (#6388)

Browse Source
This commit is contained in:
Chloe Bethel 2025-03-24 22:26:59 +00:00 committed by GitHub
parent daa4186d65
commit e722a97987
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/mesh/MeshService.cpp
View File

@ -309,7 +309,10 @@ void MeshService::sendToPhone(meshtastic_MeshPacket *p)
} }
} }
assert(toPhoneQueue.enqueue(p, 0)); if (toPhoneQueue.enqueue(p, 0) == false) {
LOG_CRIT("Failed to queue a packet into toPhoneQueue!");
abort();
}
fromNum++; fromNum++;
} }
@ -323,7 +326,10 @@ void MeshService::sendMqttMessageToClientProxy(meshtastic_MqttClientProxyMessage
releaseMqttClientProxyMessageToPool(d); releaseMqttClientProxyMessageToPool(d);
} }
assert(toPhoneMqttProxyQueue.enqueue(m, 0)); if (toPhoneMqttProxyQueue.enqueue(m, 0) == false) {
LOG_CRIT("Failed to queue a packet into toPhoneMqttProxyQueue!");
abort();
}
fromNum++; fromNum++;
} }
@ -337,7 +343,10 @@ void MeshService::sendClientNotification(meshtastic_ClientNotification *n)
releaseClientNotificationToPool(d); releaseClientNotificationToPool(d);
} }
assert(toPhoneClientNotificationQueue.enqueue(n, 0)); if (toPhoneClientNotificationQueue.enqueue(n, 0) == false) {
LOG_CRIT("Failed to queue a notification into toPhoneClientNotificationQueue!");
abort();
}
fromNum++; fromNum++;
} }