diff --git a/proto b/proto index 106f4bfde..b1aed0644 160000 --- a/proto +++ b/proto @@ -1 +1 @@ -Subproject commit 106f4bfdebe277ab0b86d2b8c950ab78a35b0654 +Subproject commit b1aed06442025624841b2288fac273d9bc41c438 diff --git a/src/graphics/Screen.cpp b/src/graphics/Screen.cpp index 6f022943f..853cdc29c 100644 --- a/src/graphics/Screen.cpp +++ b/src/graphics/Screen.cpp @@ -201,7 +201,7 @@ static void drawTextMessageFrame(OLEDDisplay *display, OLEDDisplayUiState *state // the max length of this buffer is much longer than we can possibly print static char tempBuf[96]; - assert(mp.decoded.which_payload == SubPacket_data_tag); + assert(mp.decoded.which_payloadVariant == SubPacket_data_tag); snprintf(tempBuf, sizeof(tempBuf), " %s", mp.decoded.data.payload.bytes); display->drawStringMaxWidth(4 + x, 10 + y, SCREEN_WIDTH - (6 + x), tempBuf); diff --git a/src/mesh/DSRRouter.cpp b/src/mesh/DSRRouter.cpp index ad41afdde..8b1e6f67e 100644 --- a/src/mesh/DSRRouter.cpp +++ b/src/mesh/DSRRouter.cpp @@ -72,7 +72,7 @@ void DSRRouter::sniffReceived(const MeshPacket *p) addRoute(p->from, p->from, 0); // We are adjacent with zero hops } - switch (p->decoded.which_payload) { + switch (p->decoded.which_payloadVariant) { case SubPacket_route_request_tag: // Handle route discovery packets (will be a broadcast message) // FIXME - always start request with the senders nodenum @@ -139,7 +139,7 @@ void DSRRouter::sniffReceived(const MeshPacket *p) // handle naks - convert them to route error packets // All naks are generated locally, because we failed resending the packet too many times - PacketId nakId = p->decoded.which_ack == SubPacket_fail_id_tag ? p->decoded.ack.fail_id : 0; + PacketId nakId = p->decoded.which_ackVariant == SubPacket_fail_id_tag ? p->decoded.ackVariant.fail_id : 0; if (nakId) { auto pending = findPendingPacket(p->to, nakId); if (pending && pending->packet->decoded.source) { // if source not set, this was not a multihop packet, just ignore diff --git a/src/mesh/MeshPacketQueue.cpp b/src/mesh/MeshPacketQueue.cpp new file mode 100644 index 000000000..363e83ba7 --- /dev/null +++ b/src/mesh/MeshPacketQueue.cpp @@ -0,0 +1,91 @@ +#include "MeshPacketQueue.h" + +#include + +/// @return the priority of the specified packet +inline uint32_t getPriority(MeshPacket *p) +{ + auto pri = p->priority; + return pri; +} + +/// @return "true" if "p1" is ordered before "p2" +bool CompareMeshPacket::operator()(MeshPacket *p1, MeshPacket *p2) +{ + assert(p1 && p2); + auto p1p = getPriority(p1), p2p = getPriority(p2); + + // If priorities differ, use that + // for equal priorities, order by id (older packets have higher priority - this will briefly be wrong when IDs roll over but + // no big deal) + return (p1p != p2p) ? (p1p < p2p) // prefer bigger priorities + : (p1->id >= p2->id); // prefer smaller packet ids +} + +MeshPacketQueue::MeshPacketQueue(size_t _maxLen) : maxLen(_maxLen) {} + +/** Some clients might not properly set priority, therefore we fix it here. + */ +void fixPriority(MeshPacket *p) +{ + // We might receive acks from other nodes (and since generated remotely, they won't have priority assigned. Check for that + // and fix it + if (p->priority == MeshPacket_Priority_UNSET) { + // if acks give high priority + // if a reliable message give a bit higher default priority + p->priority = p->decoded.which_ackVariant ? MeshPacket_Priority_ACK : + (p->want_ack ? MeshPacket_Priority_RELIABLE : MeshPacket_Priority_DEFAULT); + } +} + +/** enqueue a packet, return false if full */ +bool MeshPacketQueue::enqueue(MeshPacket *p) +{ + + fixPriority(p); + + // fixme if there is something lower priority in the queue that can be deleted to make space, delete that instead + if (size() >= maxLen) + return false; + else { + push(p); + return true; + } +} + +MeshPacket *MeshPacketQueue::dequeue() +{ + if (empty()) + return NULL; + else { + auto p = top(); + pop(); // remove the first item + return p; + } +} + +// this is kinda yucky, but I'm not sure if all arduino c++ compilers support closuers. And we only have one +// thread that can run at a time - so safe +static NodeNum findFrom; +static PacketId findId; + +static bool isMyPacket(MeshPacket *p) +{ + return p->id == findId && p->from == findFrom; +} + +/** Attempt to find and remove a packet from this queue. Returns true the packet which was removed from the queue */ +MeshPacket *MeshPacketQueue::remove(NodeNum from, PacketId id) +{ + findFrom = from; + findId = id; + auto it = std::find_if(this->c.begin(), this->c.end(), isMyPacket); + if (it != this->c.end()) { + auto p = *it; + this->c.erase(it); + std::make_heap(this->c.begin(), this->c.end(), this->comp); + return p; + } else { + return NULL; + } +} diff --git a/src/mesh/MeshPacketQueue.h b/src/mesh/MeshPacketQueue.h new file mode 100644 index 000000000..f04649cb5 --- /dev/null +++ b/src/mesh/MeshPacketQueue.h @@ -0,0 +1,33 @@ +#pragma once + +#include "MeshTypes.h" + +#include +#include + +// this is an strucure which implements the +// operator overloading +struct CompareMeshPacket { + bool operator()(MeshPacket *p1, MeshPacket *p2); +}; + +/** + * A priority queue of packets. + * + */ +class MeshPacketQueue : public std::priority_queue, CompareMeshPacket> +{ + size_t maxLen; + public: + MeshPacketQueue(size_t _maxLen); + + /** enqueue a packet, return false if full */ + bool enqueue(MeshPacket *p); + + // bool isEmpty(); + + MeshPacket *dequeue(); + + /** Attempt to find and remove a packet from this queue. Returns true the packet which was removed from the queue */ + MeshPacket *remove(NodeNum from, PacketId id); +}; \ No newline at end of file diff --git a/src/mesh/MeshService.cpp b/src/mesh/MeshService.cpp index 073c48144..f3a3bd1aa 100644 --- a/src/mesh/MeshService.cpp +++ b/src/mesh/MeshService.cpp @@ -169,6 +169,11 @@ void MeshService::handleToRadio(MeshPacket &p) } } +/** Attempt to cancel a previously sent packet from this _local_ node. Returns true if a packet was found we could cancel */ +bool MeshService::cancelSending(PacketId id) { + return router->cancelSending(nodeDB.getNodeNum(), id); +} + void MeshService::sendToMesh(MeshPacket *p) { nodeDB.updateFrom(*p); // update our local DB for this packet (because phone might have sent position packets etc...) @@ -176,7 +181,7 @@ void MeshService::sendToMesh(MeshPacket *p) // Strip out any time information before sending packets to other nodes - to keep the wire size small (and because other // nodes shouldn't trust it anyways) Note: we allow a device with a local GPS to include the time, so that gpsless // devices can get time. - if (p->which_payload == MeshPacket_decoded_tag && p->decoded.which_payload == SubPacket_position_tag && + if (p->which_payloadVariant == MeshPacket_decoded_tag && p->decoded.which_payloadVariant == SubPacket_position_tag && p->decoded.position.time) { if (getRTCQuality() < RTCQualityGPS) { DEBUG_MSG("Stripping time %u from position send\n", p->decoded.position.time); diff --git a/src/mesh/MeshService.h b/src/mesh/MeshService.h index 5c30339a0..8cba07710 100644 --- a/src/mesh/MeshService.h +++ b/src/mesh/MeshService.h @@ -79,6 +79,9 @@ class MeshService /// cache void sendToMesh(MeshPacket *p); + /** Attempt to cancel a previously sent packet from this _local_ node. Returns true if a packet was found we could cancel */ + bool cancelSending(PacketId id); + /// Pull the latest power and time info into my nodeinfo NodeInfo *refreshMyNodeInfo(); diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp index ea79e6ccb..b8f0b5697 100644 --- a/src/mesh/NodeDB.cpp +++ b/src/mesh/NodeDB.cpp @@ -265,16 +265,15 @@ void NodeDB::installDefaultDeviceState() // Init our blank owner info to reasonable defaults getMacAddr(ourMacAddr); - sprintf(owner.id, "!%02x%02x%02x%02x%02x%02x", ourMacAddr[0], ourMacAddr[1], ourMacAddr[2], ourMacAddr[3], ourMacAddr[4], - ourMacAddr[5]); - memcpy(owner.macaddr, ourMacAddr, sizeof(owner.macaddr)); // Set default owner name - pickNewNodeNum(); // Note: we will repick later, just in case the settings are corrupted, but we need a valid - // owner.short_name now + pickNewNodeNum(); // based on macaddr now sprintf(owner.long_name, "Unknown %02x%02x", ourMacAddr[4], ourMacAddr[5]); sprintf(owner.short_name, "?%02X", (unsigned)(myNodeInfo.my_node_num & 0xff)); + sprintf(owner.id, "!%08x", getNodeNum()); // Default node ID now based on nodenum + memcpy(owner.macaddr, ourMacAddr, sizeof(owner.macaddr)); + // Restore region if possible if (oldRegionCode != RegionCode_Unset) radioConfig.preferences.region = oldRegionCode; @@ -526,7 +525,7 @@ void NodeDB::updateUser(uint32_t nodeId, const User &p) /// we updateGUI and updateGUIforNode if we think our this change is big enough for a redraw void NodeDB::updateFrom(const MeshPacket &mp) { - if (mp.which_payload == MeshPacket_decoded_tag) { + if (mp.which_payloadVariant == MeshPacket_decoded_tag) { const SubPacket &p = mp.decoded; DEBUG_MSG("Update DB node 0x%x, rx_time=%u\n", mp.from, mp.rx_time); @@ -539,7 +538,7 @@ void NodeDB::updateFrom(const MeshPacket &mp) info->snr = mp.rx_snr; // keep the most recent SNR we received for this node. - switch (p.which_payload) { + switch (p.which_payloadVariant) { case SubPacket_position_tag: { // handle a legacy position packet DEBUG_MSG("WARNING: Processing a (deprecated) position packet from %d\n", mp.from); @@ -601,7 +600,7 @@ void recordCriticalError(CriticalErrorCode code, uint32_t address) // Print error to screen and serial port String lcd = String("Critical error ") + code + "!\n"; screen->print(lcd.c_str()); - DEBUG_MSG("NOTE! Recording critical error %d, address=%x\n", code, address); + DEBUG_MSG("NOTE! Recording critical error %d, address=%lx\n", code, address); // Record error to DB myNodeInfo.error_code = code; diff --git a/src/mesh/PhoneAPI.cpp b/src/mesh/PhoneAPI.cpp index 48898f16b..fa10e20fa 100644 --- a/src/mesh/PhoneAPI.cpp +++ b/src/mesh/PhoneAPI.cpp @@ -59,15 +59,15 @@ void PhoneAPI::handleToRadio(const uint8_t *buf, size_t bufLength) // return (lastContactMsec != 0) && if (pb_decode_from_bytes(buf, bufLength, ToRadio_fields, &toRadioScratch)) { - switch (toRadioScratch.which_variant) { + switch (toRadioScratch.which_payloadVariant) { case ToRadio_packet_tag: { - MeshPacket &p = toRadioScratch.variant.packet; + MeshPacket &p = toRadioScratch.packet; printPacket("PACKET FROM PHONE", &p); service.handleToRadio(p); break; } case ToRadio_want_config_id_tag: - config_nonce = toRadioScratch.variant.want_config_id; + config_nonce = toRadioScratch.want_config_id; DEBUG_MSG("Client wants config, nonce=%u\n", config_nonce); state = STATE_SEND_MY_INFO; @@ -79,12 +79,12 @@ void PhoneAPI::handleToRadio(const uint8_t *buf, size_t bufLength) case ToRadio_set_owner_tag: DEBUG_MSG("Client is setting owner\n"); - handleSetOwner(toRadioScratch.variant.set_owner); + handleSetOwner(toRadioScratch.set_owner); break; case ToRadio_set_radio_tag: DEBUG_MSG("Client is setting radio\n"); - handleSetRadio(toRadioScratch.variant.set_radio); + handleSetRadio(toRadioScratch.set_radio); break; default: @@ -131,22 +131,22 @@ size_t PhoneAPI::getFromRadio(uint8_t *buf) myNodeInfo.has_gps = (radioConfig.preferences.location_share == LocationSharing_LocDisabled) ? true : (gps && gps->isConnected()); // Update with latest GPS connect info - fromRadioScratch.which_variant = FromRadio_my_info_tag; - fromRadioScratch.variant.my_info = myNodeInfo; + fromRadioScratch.which_payloadVariant = FromRadio_my_info_tag; + fromRadioScratch.my_info = myNodeInfo; state = STATE_SEND_RADIO; service.refreshMyNodeInfo(); // Update my NodeInfo because the client will be asking for it soon. break; case STATE_SEND_RADIO: - fromRadioScratch.which_variant = FromRadio_radio_tag; + fromRadioScratch.which_payloadVariant = FromRadio_radio_tag; - fromRadioScratch.variant.radio = radioConfig; + fromRadioScratch.radio = radioConfig; // NOTE: The phone app needs to know the ls_secs value so it can properly expect sleep behavior. // So even if we internally use 0 to represent 'use default' we still need to send the value we are // using to the app (so that even old phone apps work with new device loads). - fromRadioScratch.variant.radio.preferences.ls_secs = getPref_ls_secs(); + fromRadioScratch.radio.preferences.ls_secs = getPref_ls_secs(); state = STATE_SEND_NODEINFO; break; @@ -158,8 +158,8 @@ size_t PhoneAPI::getFromRadio(uint8_t *buf) if (info) { DEBUG_MSG("Sending nodeinfo: num=0x%x, lastseen=%u, id=%s, name=%s\n", info->num, info->position.time, info->user.id, info->user.long_name); - fromRadioScratch.which_variant = FromRadio_node_info_tag; - fromRadioScratch.variant.node_info = *info; + fromRadioScratch.which_payloadVariant = FromRadio_node_info_tag; + fromRadioScratch.node_info = *info; // Stay in current state until done sending nodeinfos } else { DEBUG_MSG("Done sending nodeinfos\n"); @@ -171,8 +171,8 @@ size_t PhoneAPI::getFromRadio(uint8_t *buf) } case STATE_SEND_COMPLETE_ID: - fromRadioScratch.which_variant = FromRadio_config_complete_id_tag; - fromRadioScratch.variant.config_complete_id = config_nonce; + fromRadioScratch.which_payloadVariant = FromRadio_config_complete_id_tag; + fromRadioScratch.config_complete_id = config_nonce; config_nonce = 0; state = STATE_SEND_PACKETS; break; @@ -185,8 +185,8 @@ size_t PhoneAPI::getFromRadio(uint8_t *buf) printPacket("phone downloaded packet", packetForPhone); // Encapsulate as a FromRadio packet - fromRadioScratch.which_variant = FromRadio_packet_tag; - fromRadioScratch.variant.packet = *packetForPhone; + fromRadioScratch.which_payloadVariant = FromRadio_packet_tag; + fromRadioScratch.packet = *packetForPhone; service.releaseToPool(packetForPhone); // we just copied the bytes, so don't need this buffer anymore packetForPhone = NULL; @@ -198,9 +198,9 @@ size_t PhoneAPI::getFromRadio(uint8_t *buf) } // Do we have a message from the mesh? - if (fromRadioScratch.which_variant != 0) { + if (fromRadioScratch.which_payloadVariant != 0) { // Encapsulate as a FromRadio packet - DEBUG_MSG("encoding toPhone packet to phone variant=%d", fromRadioScratch.which_variant); + DEBUG_MSG("encoding toPhone packet to phone variant=%d", fromRadioScratch.which_payloadVariant); size_t numbytes = pb_encode_to_bytes(buf, FromRadio_size, FromRadio_fields, &fromRadioScratch); DEBUG_MSG(", %d bytes\n", numbytes); return numbytes; diff --git a/src/mesh/RadioInterface.cpp b/src/mesh/RadioInterface.cpp index 01f3f7911..0884c260d 100644 --- a/src/mesh/RadioInterface.cpp +++ b/src/mesh/RadioInterface.cpp @@ -83,7 +83,7 @@ uint32_t RadioInterface::getPacketTime(uint32_t pl) uint32_t RadioInterface::getPacketTime(MeshPacket *p) { - assert(p->which_payload == MeshPacket_encrypted_tag); // It should have already been encoded by now + assert(p->which_payloadVariant == MeshPacket_encrypted_tag); // It should have already been encoded by now uint32_t pl = p->encrypted.size + sizeof(PacketHeader); return getPacketTime(pl); @@ -119,9 +119,9 @@ void printPacket(const char *prefix, const MeshPacket *p) { DEBUG_MSG("%s (id=0x%08x Fr0x%02x To0x%02x, WantAck%d, HopLim%d", prefix, p->id, p->from & 0xff, p->to & 0xff, p->want_ack, p->hop_limit); - if (p->which_payload == MeshPacket_decoded_tag) { + if (p->which_payloadVariant == MeshPacket_decoded_tag) { auto &s = p->decoded; - switch (s.which_payload) { + switch (s.which_payloadVariant) { case SubPacket_data_tag: DEBUG_MSG(" Portnum=%d", s.data.portnum); break; @@ -135,7 +135,7 @@ void printPacket(const char *prefix, const MeshPacket *p) DEBUG_MSG(" Payload:None"); break; default: - DEBUG_MSG(" Payload:%d", s.which_payload); + DEBUG_MSG(" Payload:%d", s.which_payloadVariant); break; } if (s.want_response) @@ -147,10 +147,10 @@ void printPacket(const char *prefix, const MeshPacket *p) if (s.dest != 0) DEBUG_MSG(" dest=%08x", s.dest); - if (s.which_ack == SubPacket_success_id_tag) - DEBUG_MSG(" successId=%08x", s.ack.success_id); - else if (s.which_ack == SubPacket_fail_id_tag) - DEBUG_MSG(" failId=%08x", s.ack.fail_id); + if (s.which_ackVariant == SubPacket_success_id_tag) + DEBUG_MSG(" successId=%08x", s.ackVariant.success_id); + else if (s.which_ackVariant == SubPacket_fail_id_tag) + DEBUG_MSG(" failId=%08x", s.ackVariant.fail_id); } else { DEBUG_MSG(" encrypted"); } @@ -161,6 +161,9 @@ void printPacket(const char *prefix, const MeshPacket *p) if (p->rx_snr != 0.0) { DEBUG_MSG(" rxSNR=%g", p->rx_snr); } + if(p->priority != 0) + DEBUG_MSG(" priority=%d", p->priority); + DEBUG_MSG(")\n"); } @@ -348,7 +351,7 @@ size_t RadioInterface::beginSending(MeshPacket *p) assert(!sendingPacket); // DEBUG_MSG("sending queued packet on mesh (txGood=%d,rxGood=%d,rxBad=%d)\n", rf95.txGood(), rf95.rxGood(), rf95.rxBad()); - assert(p->which_payload == MeshPacket_encrypted_tag); // It should have already been encoded by now + assert(p->which_payloadVariant == MeshPacket_encrypted_tag); // It should have already been encoded by now lastTxStart = millis(); diff --git a/src/mesh/RadioInterface.h b/src/mesh/RadioInterface.h index 1f4fb8457..51cb0e789 100644 --- a/src/mesh/RadioInterface.h +++ b/src/mesh/RadioInterface.h @@ -105,6 +105,9 @@ class RadioInterface */ virtual ErrorCode send(MeshPacket *p) = 0; + /** Attempt to cancel a previously sent packet. Returns true if a packet was found we could cancel */ + virtual bool cancelSending(NodeNum from, PacketId id) { return false; } + // methods from radiohead /// Initialise the Driver transport hardware and software. diff --git a/src/mesh/RadioLibInterface.cpp b/src/mesh/RadioLibInterface.cpp index f2fafef76..84fd37ee6 100644 --- a/src/mesh/RadioLibInterface.cpp +++ b/src/mesh/RadioLibInterface.cpp @@ -100,7 +100,7 @@ ErrorCode RadioLibInterface::send(MeshPacket *p) uint32_t xmitMsec = getPacketTime(p); DEBUG_MSG("txGood=%d,rxGood=%d,rxBad=%d\n", txGood, rxGood, rxBad); - ErrorCode res = txQueue.enqueue(p, 0) ? ERRNO_OK : ERRNO_UNKNOWN; + ErrorCode res = txQueue.enqueue(p) ? ERRNO_OK : ERRNO_UNKNOWN; if (res != ERRNO_OK) { // we weren't able to queue it, so we must drop it to prevent leaks packetPool.release(p); @@ -125,13 +125,25 @@ ErrorCode RadioLibInterface::send(MeshPacket *p) bool RadioLibInterface::canSleep() { - bool res = txQueue.isEmpty(); + bool res = txQueue.empty(); if (!res) // only print debug messages if we are vetoing sleep DEBUG_MSG("radio wait to sleep, txEmpty=%d\n", res); return res; } +/** Attempt to cancel a previously sent packet. Returns true if a packet was found we could cancel */ +bool RadioLibInterface::cancelSending(NodeNum from, PacketId id) { + auto p = txQueue.remove(from, id); + if(p) + packetPool.release(p); // free the packet we just removed + + bool result = (p != NULL); + DEBUG_MSG("cancelSending id=0x%x, removed=%d", id, result); + return result; +} + + /** radio helper thread callback. We never immediately transmit after any operation (either rx or tx). Instead we should start receiving and @@ -165,12 +177,12 @@ void RadioLibInterface::onNotify(uint32_t notification) // If we are not currently in receive mode, then restart the timer and try again later (this can happen if the main thread // has placed the unit into standby) FIXME, how will this work if the chipset is in sleep mode? - if (!txQueue.isEmpty()) { + if (!txQueue.empty()) { if (!canSendImmediately()) { startTransmitTimer(); // try again in a little while } else { // Send any outgoing packets we have ready - MeshPacket *txp = txQueue.dequeuePtr(0); + MeshPacket *txp = txQueue.dequeue(); assert(txp); startSend(txp); } @@ -186,7 +198,7 @@ void RadioLibInterface::onNotify(uint32_t notification) void RadioLibInterface::startTransmitTimer(bool withDelay) { // If we have work to do and the timer wasn't already scheduled, schedule it now - if (!txQueue.isEmpty()) { + if (!txQueue.empty()) { uint32_t delay = !withDelay ? 1 : getTxDelayMsec(); // DEBUG_MSG("xmit timer %d\n", delay); notifyLater(delay, TRANSMIT_DELAY_COMPLETED, false); // This will implicitly enable @@ -264,7 +276,7 @@ void RadioLibInterface::handleReceiveInterrupt() addReceiveMetadata(mp); - mp->which_payload = MeshPacket_encrypted_tag; // Mark that the payload is still encrypted at this point + mp->which_payloadVariant = MeshPacket_encrypted_tag; // Mark that the payload is still encrypted at this point assert(((uint32_t) payloadLen) <= sizeof(mp->encrypted.bytes)); memcpy(mp->encrypted.bytes, payload, payloadLen); mp->encrypted.size = payloadLen; diff --git a/src/mesh/RadioLibInterface.h b/src/mesh/RadioLibInterface.h index e762fdcdc..726e81b37 100644 --- a/src/mesh/RadioLibInterface.h +++ b/src/mesh/RadioLibInterface.h @@ -2,6 +2,7 @@ #include "../concurrency/OSThread.h" #include "RadioInterface.h" +#include "MeshPacketQueue.h" #ifdef CubeCell_BoardPlus #define RADIOLIB_SOFTWARE_SERIAL_UNSUPPORTED @@ -74,7 +75,7 @@ class RadioLibInterface : public RadioInterface, protected concurrency::Notified */ uint32_t rxBad = 0, rxGood = 0, txGood = 0; - PointerQueue txQueue = PointerQueue(MAX_TX_QUEUE); + MeshPacketQueue txQueue = MeshPacketQueue(MAX_TX_QUEUE); protected: @@ -136,6 +137,9 @@ class RadioLibInterface : public RadioInterface, protected concurrency::Notified */ virtual bool isActivelyReceiving() = 0; + /** Attempt to cancel a previously sent packet. Returns true if a packet was found we could cancel */ + virtual bool cancelSending(NodeNum from, PacketId id); + private: /** if we have something waiting to send, start a short random timer so we can come check for collision before actually doing * the transmit diff --git a/src/mesh/ReliableRouter.cpp b/src/mesh/ReliableRouter.cpp index 6060b1f03..3bc8bfde5 100644 --- a/src/mesh/ReliableRouter.cpp +++ b/src/mesh/ReliableRouter.cpp @@ -65,8 +65,8 @@ void ReliableRouter::sniffReceived(const MeshPacket *p) // If the payload is valid, look for ack/nak - PacketId ackId = p->decoded.which_ack == SubPacket_success_id_tag ? p->decoded.ack.success_id : 0; - PacketId nakId = p->decoded.which_ack == SubPacket_fail_id_tag ? p->decoded.ack.fail_id : 0; + PacketId ackId = p->decoded.which_ackVariant == SubPacket_success_id_tag ? p->decoded.ackVariant.success_id : 0; + PacketId nakId = p->decoded.which_ackVariant == SubPacket_fail_id_tag ? p->decoded.ackVariant.fail_id : 0; // We intentionally don't check wasSeenRecently, because it is harmless to delete non existent retransmission records if (ackId || nakId) { diff --git a/src/mesh/Router.cpp b/src/mesh/Router.cpp index c3a345522..43d939c31 100644 --- a/src/mesh/Router.cpp +++ b/src/mesh/Router.cpp @@ -88,7 +88,7 @@ MeshPacket *Router::allocForSending() { MeshPacket *p = packetPool.allocZeroed(); - p->which_payload = MeshPacket_decoded_tag; // Assume payload is decoded at start. + p->which_payloadVariant = MeshPacket_decoded_tag; // Assume payload is decoded at start. p->from = nodeDB.getNodeNum(); p->to = NODENUM_BROADCAST; p->hop_limit = HOP_RELIABLE; @@ -110,20 +110,23 @@ void Router::sendAckNak(ErrorReason err, NodeNum to, PacketId idFrom) DEBUG_MSG("Sending an err=%d,to=0x%x,idFrom=0x%x,id=0x%x\n", err, to, idFrom, p->id); if (!err) { - p->decoded.ack.success_id = idFrom; - p->decoded.which_ack = SubPacket_success_id_tag; + p->decoded.ackVariant.success_id = idFrom; + p->decoded.which_ackVariant = SubPacket_success_id_tag; } else { - p->decoded.ack.fail_id = idFrom; - p->decoded.which_ack = SubPacket_fail_id_tag; + p->decoded.ackVariant.fail_id = idFrom; + p->decoded.which_ackVariant = SubPacket_fail_id_tag; // Also send back the error reason - p->decoded.which_payload = SubPacket_error_reason_tag; + p->decoded.which_payloadVariant = SubPacket_error_reason_tag; p->decoded.error_reason = err; } + p->priority = MeshPacket_Priority_ACK; sendLocal(p); // we sometimes send directly to the local node } + + ErrorCode Router::sendLocal(MeshPacket *p) { // No need to deliver externally if the destination is the local node @@ -160,7 +163,7 @@ ErrorCode Router::send(MeshPacket *p) { assert(p->to != nodeDB.getNodeNum()); // should have already been handled by sendLocal - PacketId nakId = p->decoded.which_ack == SubPacket_fail_id_tag ? p->decoded.ack.fail_id : 0; + PacketId nakId = p->decoded.which_ackVariant == SubPacket_fail_id_tag ? p->decoded.ackVariant.fail_id : 0; assert( !nakId); // I don't think we ever send 0hop naks over the wire (other than to the phone), test that assumption with assert @@ -170,11 +173,11 @@ ErrorCode Router::send(MeshPacket *p) // If the packet hasn't yet been encrypted, do so now (it might already be encrypted if we are just forwarding it) - assert(p->which_payload == MeshPacket_encrypted_tag || - p->which_payload == MeshPacket_decoded_tag); // I _think_ all packets should have a payload by now + assert(p->which_payloadVariant == MeshPacket_encrypted_tag || + p->which_payloadVariant == MeshPacket_decoded_tag); // I _think_ all packets should have a payload by now // First convert from protobufs to raw bytes - if (p->which_payload == MeshPacket_decoded_tag) { + if (p->which_payloadVariant == MeshPacket_decoded_tag) { static uint8_t bytes[MAX_RHPACKETLEN]; // we have to use a scratch buffer because a union size_t numbytes = pb_encode_to_bytes(bytes, sizeof(bytes), SubPacket_fields, &p->decoded); @@ -185,7 +188,7 @@ ErrorCode Router::send(MeshPacket *p) // Copy back into the packet and set the variant type memcpy(p->encrypted.bytes, bytes, numbytes); p->encrypted.size = numbytes; - p->which_payload = MeshPacket_encrypted_tag; + p->which_payloadVariant = MeshPacket_encrypted_tag; } assert(iface); // This should have been detected already in sendLocal (or we just received a packet from outside) @@ -199,6 +202,13 @@ ErrorCode Router::send(MeshPacket *p) } */ } +/** Attempt to cancel a previously sent packet. Returns true if a packet was found we could cancel */ +bool Router::cancelSending(NodeNum from, PacketId id) { + return iface ? iface->cancelSending(from, id) : false; +} + + + /** * Every (non duplicate) packet this node receives will be passed through this method. This allows subclasses to * update routing tables etc... based on what we overhear (even for messages not destined to our node) @@ -211,10 +221,10 @@ void Router::sniffReceived(const MeshPacket *p) bool Router::perhapsDecode(MeshPacket *p) { - if (p->which_payload == MeshPacket_decoded_tag) + if (p->which_payloadVariant == MeshPacket_decoded_tag) return true; // If packet was already decoded just return - assert(p->which_payload == MeshPacket_encrypted_tag); + assert(p->which_payloadVariant == MeshPacket_encrypted_tag); // FIXME - someday don't send routing packets encrypted. That would allow us to route for other channels without // being able to decrypt their data. @@ -230,7 +240,7 @@ bool Router::perhapsDecode(MeshPacket *p) return false; } else { // parsing was successful - p->which_payload = MeshPacket_decoded_tag; + p->which_payloadVariant = MeshPacket_decoded_tag; return true; } } diff --git a/src/mesh/Router.h b/src/mesh/Router.h index dfc44dfa4..3951f3062 100644 --- a/src/mesh/Router.h +++ b/src/mesh/Router.h @@ -55,7 +55,12 @@ class Router : protected concurrency::OSThread */ ErrorCode sendLocal(MeshPacket *p); - /// Allocate and return a meshpacket which defaults as send to broadcast from the current node. + /** Attempt to cancel a previously sent packet. Returns true if a packet was found we could cancel */ + bool cancelSending(NodeNum from, PacketId id); + + /** Allocate and return a meshpacket which defaults as send to broadcast from the current node. + * The returned packet is guaranteed to have a unique packet ID already assigned + */ MeshPacket *allocForSending(); /** diff --git a/src/mesh/SinglePortPlugin.h b/src/mesh/SinglePortPlugin.h index 01ee1963a..d182579b7 100644 --- a/src/mesh/SinglePortPlugin.h +++ b/src/mesh/SinglePortPlugin.h @@ -32,7 +32,7 @@ class SinglePortPlugin : public MeshPlugin { // Update our local node info with our position (even if we don't decide to update anyone else) MeshPacket *p = router->allocForSending(); - p->decoded.which_payload = SubPacket_data_tag; + p->decoded.which_payloadVariant = SubPacket_data_tag; p->decoded.data.portnum = ourPortNum; return p; diff --git a/src/mesh/StreamAPI.cpp b/src/mesh/StreamAPI.cpp index 06b80b2fa..8015b951b 100644 --- a/src/mesh/StreamAPI.cpp +++ b/src/mesh/StreamAPI.cpp @@ -84,8 +84,8 @@ void StreamAPI::emitRebooted() { // In case we send a FromRadio packet memset(&fromRadioScratch, 0, sizeof(fromRadioScratch)); - fromRadioScratch.which_variant = FromRadio_rebooted_tag; - fromRadioScratch.variant.rebooted = true; + fromRadioScratch.which_payloadVariant = FromRadio_rebooted_tag; + fromRadioScratch.rebooted = true; DEBUG_MSG("Emitting reboot packet for serial shell\n"); emitTxBuffer(pb_encode_to_bytes(txBuf + HEADER_LEN, FromRadio_size, FromRadio_fields, &fromRadioScratch)); diff --git a/src/mesh/generated/mesh.pb.c b/src/mesh/generated/mesh.pb.c index 3bc2b0800..0bf5fbe38 100644 --- a/src/mesh/generated/mesh.pb.c +++ b/src/mesh/generated/mesh.pb.c @@ -58,3 +58,4 @@ PB_BIND(ToRadio, ToRadio, 2) + diff --git a/src/mesh/generated/mesh.pb.h b/src/mesh/generated/mesh.pb.h index d37806307..397a313ea 100644 --- a/src/mesh/generated/mesh.pb.h +++ b/src/mesh/generated/mesh.pb.h @@ -83,6 +83,16 @@ typedef enum _CriticalErrorCode { CriticalErrorCode_TransmitFailed = 8 } CriticalErrorCode; +typedef enum _MeshPacket_Priority { + MeshPacket_Priority_UNSET = 0, + MeshPacket_Priority_MIN = 1, + MeshPacket_Priority_BACKGROUND = 10, + MeshPacket_Priority_DEFAULT = 64, + MeshPacket_Priority_RELIABLE = 70, + MeshPacket_Priority_ACK = 120, + MeshPacket_Priority_MAX = 127 +} MeshPacket_Priority; + typedef enum _ChannelSettings_ModemConfig { ChannelSettings_ModemConfig_Bw125Cr45Sf128 = 0, ChannelSettings_ModemConfig_Bw500Cr45Sf128 = 1, @@ -230,7 +240,7 @@ typedef struct _RadioConfig { } RadioConfig; typedef struct _SubPacket { - pb_size_t which_payload; + pb_size_t which_payloadVariant; union { Position position; Data data; @@ -242,11 +252,11 @@ typedef struct _SubPacket { uint32_t original_id; bool want_response; uint32_t dest; - pb_size_t which_ack; + pb_size_t which_ackVariant; union { uint32_t success_id; uint32_t fail_id; - } ack; + } ackVariant; uint32_t source; } SubPacket; @@ -254,7 +264,7 @@ typedef PB_BYTES_ARRAY_T(256) MeshPacket_encrypted_t; typedef struct _MeshPacket { uint32_t from; uint32_t to; - pb_size_t which_payload; + pb_size_t which_payloadVariant; union { SubPacket decoded; MeshPacket_encrypted_t encrypted; @@ -265,11 +275,12 @@ typedef struct _MeshPacket { uint32_t rx_time; uint32_t hop_limit; bool want_ack; + MeshPacket_Priority priority; } MeshPacket; typedef struct _FromRadio { uint32_t num; - pb_size_t which_variant; + pb_size_t which_payloadVariant; union { MeshPacket packet; MyNodeInfo my_info; @@ -279,18 +290,18 @@ typedef struct _FromRadio { uint32_t config_complete_id; bool rebooted; ChannelSettings channel; - } variant; + }; } FromRadio; typedef struct _ToRadio { - pb_size_t which_variant; + pb_size_t which_payloadVariant; union { MeshPacket packet; uint32_t want_config_id; RadioConfig set_radio; User set_owner; ChannelSettings set_channel; - } variant; + }; } ToRadio; @@ -323,6 +334,10 @@ typedef struct _ToRadio { #define _CriticalErrorCode_MAX CriticalErrorCode_TransmitFailed #define _CriticalErrorCode_ARRAYSIZE ((CriticalErrorCode)(CriticalErrorCode_TransmitFailed+1)) +#define _MeshPacket_Priority_MIN MeshPacket_Priority_UNSET +#define _MeshPacket_Priority_MAX MeshPacket_Priority_MAX +#define _MeshPacket_Priority_ARRAYSIZE ((MeshPacket_Priority)(MeshPacket_Priority_MAX+1)) + #define _ChannelSettings_ModemConfig_MIN ChannelSettings_ModemConfig_Bw125Cr45Sf128 #define _ChannelSettings_ModemConfig_MAX ChannelSettings_ModemConfig_Bw125Cr48Sf4096 #define _ChannelSettings_ModemConfig_ARRAYSIZE ((ChannelSettings_ModemConfig)(ChannelSettings_ModemConfig_Bw125Cr48Sf4096+1)) @@ -342,7 +357,7 @@ extern "C" { #define User_init_default {"", "", "", {0}} #define RouteDiscovery_init_default {0, {0, 0, 0, 0, 0, 0, 0, 0}} #define SubPacket_init_default {0, {Position_init_default}, 0, 0, 0, 0, {0}, 0} -#define MeshPacket_init_default {0, 0, 0, {SubPacket_init_default}, 0, 0, 0, 0, 0, 0} +#define MeshPacket_init_default {0, 0, 0, {SubPacket_init_default}, 0, 0, 0, 0, 0, 0, _MeshPacket_Priority_MIN} #define ChannelSettings_init_default {0, _ChannelSettings_ModemConfig_MIN, {0, {0}}, "", 0, 0, 0, 0, 0, 0, 0} #define RadioConfig_init_default {false, RadioConfig_UserPreferences_init_default, false, ChannelSettings_init_default} #define RadioConfig_UserPreferences_init_default {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "", "", 0, _RegionCode_MIN, _ChargeCurrent_MIN, _LocationSharing_MIN, _GpsOperation_MIN, 0, 0, 0, 0, 0, 0, 0, 0, {0, 0, 0}, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} @@ -356,7 +371,7 @@ extern "C" { #define User_init_zero {"", "", "", {0}} #define RouteDiscovery_init_zero {0, {0, 0, 0, 0, 0, 0, 0, 0}} #define SubPacket_init_zero {0, {Position_init_zero}, 0, 0, 0, 0, {0}, 0} -#define MeshPacket_init_zero {0, 0, 0, {SubPacket_init_zero}, 0, 0, 0, 0, 0, 0} +#define MeshPacket_init_zero {0, 0, 0, {SubPacket_init_zero}, 0, 0, 0, 0, 0, 0, _MeshPacket_Priority_MIN} #define ChannelSettings_init_zero {0, _ChannelSettings_ModemConfig_MIN, {0, {0}}, "", 0, 0, 0, 0, 0, 0, 0} #define RadioConfig_init_zero {false, RadioConfig_UserPreferences_init_zero, false, ChannelSettings_init_zero} #define RadioConfig_UserPreferences_init_zero {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "", "", 0, _RegionCode_MIN, _ChargeCurrent_MIN, _LocationSharing_MIN, _GpsOperation_MIN, 0, 0, 0, 0, 0, 0, 0, 0, {0, 0, 0}, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} @@ -479,6 +494,7 @@ extern "C" { #define MeshPacket_rx_time_tag 9 #define MeshPacket_hop_limit_tag 10 #define MeshPacket_want_ack_tag 11 +#define MeshPacket_priority_tag 12 #define FromRadio_num_tag 1 #define FromRadio_packet_tag 2 #define FromRadio_my_info_tag 3 @@ -524,40 +540,41 @@ X(a, STATIC, REPEATED, INT32, route, 2) #define RouteDiscovery_DEFAULT NULL #define SubPacket_FIELDLIST(X, a) \ -X(a, STATIC, ONEOF, MESSAGE, (payload,position,position), 1) \ -X(a, STATIC, ONEOF, MESSAGE, (payload,data,data), 3) \ -X(a, STATIC, ONEOF, MESSAGE, (payload,user,user), 4) \ -X(a, STATIC, ONEOF, MESSAGE, (payload,route_request,route_request), 6) \ -X(a, STATIC, ONEOF, MESSAGE, (payload,route_reply,route_reply), 7) \ -X(a, STATIC, ONEOF, UENUM, (payload,error_reason,error_reason), 13) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,position,position), 1) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,data,data), 3) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,user,user), 4) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,route_request,route_request), 6) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,route_reply,route_reply), 7) \ +X(a, STATIC, ONEOF, UENUM, (payloadVariant,error_reason,error_reason), 13) \ X(a, STATIC, SINGULAR, UINT32, original_id, 2) \ X(a, STATIC, SINGULAR, BOOL, want_response, 5) \ X(a, STATIC, SINGULAR, UINT32, dest, 9) \ -X(a, STATIC, ONEOF, UINT32, (ack,success_id,ack.success_id), 10) \ -X(a, STATIC, ONEOF, UINT32, (ack,fail_id,ack.fail_id), 11) \ +X(a, STATIC, ONEOF, UINT32, (ackVariant,success_id,ackVariant.success_id), 10) \ +X(a, STATIC, ONEOF, UINT32, (ackVariant,fail_id,ackVariant.fail_id), 11) \ X(a, STATIC, SINGULAR, UINT32, source, 12) #define SubPacket_CALLBACK NULL #define SubPacket_DEFAULT NULL -#define SubPacket_payload_position_MSGTYPE Position -#define SubPacket_payload_data_MSGTYPE Data -#define SubPacket_payload_user_MSGTYPE User -#define SubPacket_payload_route_request_MSGTYPE RouteDiscovery -#define SubPacket_payload_route_reply_MSGTYPE RouteDiscovery +#define SubPacket_payloadVariant_position_MSGTYPE Position +#define SubPacket_payloadVariant_data_MSGTYPE Data +#define SubPacket_payloadVariant_user_MSGTYPE User +#define SubPacket_payloadVariant_route_request_MSGTYPE RouteDiscovery +#define SubPacket_payloadVariant_route_reply_MSGTYPE RouteDiscovery #define MeshPacket_FIELDLIST(X, a) \ X(a, STATIC, SINGULAR, UINT32, from, 1) \ X(a, STATIC, SINGULAR, UINT32, to, 2) \ -X(a, STATIC, ONEOF, MESSAGE, (payload,decoded,decoded), 3) \ -X(a, STATIC, ONEOF, BYTES, (payload,encrypted,encrypted), 8) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,decoded,decoded), 3) \ +X(a, STATIC, ONEOF, BYTES, (payloadVariant,encrypted,encrypted), 8) \ X(a, STATIC, SINGULAR, UINT32, channel_index, 4) \ X(a, STATIC, SINGULAR, UINT32, id, 6) \ X(a, STATIC, SINGULAR, FLOAT, rx_snr, 7) \ X(a, STATIC, SINGULAR, FIXED32, rx_time, 9) \ X(a, STATIC, SINGULAR, UINT32, hop_limit, 10) \ -X(a, STATIC, SINGULAR, BOOL, want_ack, 11) +X(a, STATIC, SINGULAR, BOOL, want_ack, 11) \ +X(a, STATIC, SINGULAR, UENUM, priority, 12) #define MeshPacket_CALLBACK NULL #define MeshPacket_DEFAULT NULL -#define MeshPacket_payload_decoded_MSGTYPE SubPacket +#define MeshPacket_payloadVariant_decoded_MSGTYPE SubPacket #define ChannelSettings_FIELDLIST(X, a) \ X(a, STATIC, SINGULAR, INT32, tx_power, 1) \ @@ -667,35 +684,35 @@ X(a, STATIC, SINGULAR, UENUM, level, 4) #define FromRadio_FIELDLIST(X, a) \ X(a, STATIC, SINGULAR, UINT32, num, 1) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,packet,variant.packet), 2) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,my_info,variant.my_info), 3) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,node_info,variant.node_info), 4) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,radio,variant.radio), 6) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,log_record,variant.log_record), 7) \ -X(a, STATIC, ONEOF, UINT32, (variant,config_complete_id,variant.config_complete_id), 8) \ -X(a, STATIC, ONEOF, BOOL, (variant,rebooted,variant.rebooted), 9) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,channel,variant.channel), 10) +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,packet,packet), 2) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,my_info,my_info), 3) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,node_info,node_info), 4) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,radio,radio), 6) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,log_record,log_record), 7) \ +X(a, STATIC, ONEOF, UINT32, (payloadVariant,config_complete_id,config_complete_id), 8) \ +X(a, STATIC, ONEOF, BOOL, (payloadVariant,rebooted,rebooted), 9) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,channel,channel), 10) #define FromRadio_CALLBACK NULL #define FromRadio_DEFAULT NULL -#define FromRadio_variant_packet_MSGTYPE MeshPacket -#define FromRadio_variant_my_info_MSGTYPE MyNodeInfo -#define FromRadio_variant_node_info_MSGTYPE NodeInfo -#define FromRadio_variant_radio_MSGTYPE RadioConfig -#define FromRadio_variant_log_record_MSGTYPE LogRecord -#define FromRadio_variant_channel_MSGTYPE ChannelSettings +#define FromRadio_payloadVariant_packet_MSGTYPE MeshPacket +#define FromRadio_payloadVariant_my_info_MSGTYPE MyNodeInfo +#define FromRadio_payloadVariant_node_info_MSGTYPE NodeInfo +#define FromRadio_payloadVariant_radio_MSGTYPE RadioConfig +#define FromRadio_payloadVariant_log_record_MSGTYPE LogRecord +#define FromRadio_payloadVariant_channel_MSGTYPE ChannelSettings #define ToRadio_FIELDLIST(X, a) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,packet,variant.packet), 1) \ -X(a, STATIC, ONEOF, UINT32, (variant,want_config_id,variant.want_config_id), 100) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,set_radio,variant.set_radio), 101) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,set_owner,variant.set_owner), 102) \ -X(a, STATIC, ONEOF, MESSAGE, (variant,set_channel,variant.set_channel), 103) +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,packet,packet), 1) \ +X(a, STATIC, ONEOF, UINT32, (payloadVariant,want_config_id,want_config_id), 100) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,set_radio,set_radio), 101) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,set_owner,set_owner), 102) \ +X(a, STATIC, ONEOF, MESSAGE, (payloadVariant,set_channel,set_channel), 103) #define ToRadio_CALLBACK NULL #define ToRadio_DEFAULT NULL -#define ToRadio_variant_packet_MSGTYPE MeshPacket -#define ToRadio_variant_set_radio_MSGTYPE RadioConfig -#define ToRadio_variant_set_owner_MSGTYPE User -#define ToRadio_variant_set_channel_MSGTYPE ChannelSettings +#define ToRadio_payloadVariant_packet_MSGTYPE MeshPacket +#define ToRadio_payloadVariant_set_radio_MSGTYPE RadioConfig +#define ToRadio_payloadVariant_set_owner_MSGTYPE User +#define ToRadio_payloadVariant_set_channel_MSGTYPE ChannelSettings extern const pb_msgdesc_t Position_msg; extern const pb_msgdesc_t Data_msg; @@ -734,7 +751,7 @@ extern const pb_msgdesc_t ToRadio_msg; #define User_size 72 #define RouteDiscovery_size 88 #define SubPacket_size 275 -#define MeshPacket_size 320 +#define MeshPacket_size 322 #define ChannelSettings_size 95 #define RadioConfig_size 405 #define RadioConfig_UserPreferences_size 305 diff --git a/src/mesh/generated/portnums.pb.h b/src/mesh/generated/portnums.pb.h index 15572ca17..2133ecaa7 100644 --- a/src/mesh/generated/portnums.pb.h +++ b/src/mesh/generated/portnums.pb.h @@ -20,6 +20,7 @@ typedef enum _PortNum { PortNum_IP_TUNNEL_APP = 33, PortNum_SERIAL_APP = 64, PortNum_STORE_FORWARD_APP = 65, + PortNum_RANGE_TEST_APP = 66, PortNum_PRIVATE_APP = 256, PortNum_ATAK_FORWARDER = 257 } PortNum; diff --git a/src/plugins/NodeInfoPlugin.cpp b/src/plugins/NodeInfoPlugin.cpp index 54aea4cc7..6c236ed34 100644 --- a/src/plugins/NodeInfoPlugin.cpp +++ b/src/plugins/NodeInfoPlugin.cpp @@ -28,9 +28,15 @@ bool NodeInfoPlugin::handleReceivedProtobuf(const MeshPacket &mp, const User &p) void NodeInfoPlugin::sendOurNodeInfo(NodeNum dest, bool wantReplies) { + // cancel any not yet sent (now stale) position packets + if(prevPacketId) // if we wrap around to zero, we'll simply fail to cancel in that rare case (no big deal) + service.cancelSending(prevPacketId); + MeshPacket *p = allocReply(); p->to = dest; p->decoded.want_response = wantReplies; + p->priority = MeshPacket_Priority_BACKGROUND; + prevPacketId = p->id; service.sendToMesh(p); } diff --git a/src/plugins/NodeInfoPlugin.h b/src/plugins/NodeInfoPlugin.h index aabeb0059..8b01ea25e 100644 --- a/src/plugins/NodeInfoPlugin.h +++ b/src/plugins/NodeInfoPlugin.h @@ -6,6 +6,9 @@ */ class NodeInfoPlugin : public ProtobufPlugin { + /// The id of the last packet we sent, to allow us to cancel it if we make something fresher + PacketId prevPacketId = 0; + public: /** Constructor * name is for debugging output diff --git a/src/plugins/PositionPlugin.cpp b/src/plugins/PositionPlugin.cpp index f9f86bf68..4ea7298e6 100644 --- a/src/plugins/PositionPlugin.cpp +++ b/src/plugins/PositionPlugin.cpp @@ -37,9 +37,15 @@ MeshPacket *PositionPlugin::allocReply() void PositionPlugin::sendOurPosition(NodeNum dest, bool wantReplies) { + // cancel any not yet sent (now stale) position packets + if(prevPacketId) // if we wrap around to zero, we'll simply fail to cancel in that rare case (no big deal) + service.cancelSending(prevPacketId); + MeshPacket *p = allocReply(); p->to = dest; p->decoded.want_response = wantReplies; + p->priority = MeshPacket_Priority_BACKGROUND; + prevPacketId = p->id; service.sendToMesh(p); } diff --git a/src/plugins/PositionPlugin.h b/src/plugins/PositionPlugin.h index 6a1eb05f0..9ca2d2082 100644 --- a/src/plugins/PositionPlugin.h +++ b/src/plugins/PositionPlugin.h @@ -6,6 +6,9 @@ */ class PositionPlugin : public ProtobufPlugin { + /// The id of the last packet we sent, to allow us to cancel it if we make something fresher + PacketId prevPacketId = 0; + public: /** Constructor * name is for debugging output diff --git a/version.properties b/version.properties index 5ff3c45fa..98083da23 100644 --- a/version.properties +++ b/version.properties @@ -1,4 +1,4 @@ [VERSION] major = 1 minor = 1 -build = 42 +build = 46