11932 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HarukiToreda	ae3c4ed2cd	Copilot fixes	2026-06-01 12:20:42 -04:00
HarukiToreda	50ac915fd4	Merge branch 'develop' into SystemWide_MessageStore	2026-05-31 16:41:09 -04:00
HarukiToreda	12fb0be2d2	DM fix	2026-05-31 16:16:21 -04:00
HarukiToreda	cd9489969f	Unified Messagestore.	2026-05-31 15:47:15 -04:00
Austin	3feb155a5f	Fix null pointer dereference in updateBatteryLevel function (#10588)	2026-05-31 14:46:28 -04:00
Chloe Bethel	64e35908c9	Add Xiao RP2040 and RP2350 variants (#10109)	2026-05-31 12:51:15 -04:00
Ben Meadors	8a1d6d9285	Add stable uid generation for PLI entities in allocAtakPli function	2026-05-31 12:26:00 -04:00
Tom	ee441dd7b2	Merge pull request #10560 from meshtastic/migrate-overrideslot ... Move overrideSlot from RegionProfile to RegionInfo (override per-region)	2026-05-30 22:04:37 +01:00
vidplace7	178ae0a7f1	Move overrideSlot from RegionProfile to RegionInfo (override per-region) ... Move default frequency (slot) override from RegionProfile to RegionInfo (set per-region). This is usually set to `0`, but will be especially useful for Ham modes where each region default must fit within a band plan. Co-authored-by: Copilot <copilot@github.com>	2026-05-30 16:20:17 -04:00
Copilot	a08872299e	Fix thinknode_m7 esp32s3 CI build failure from missing esp_eth_driver.h (#10585) ... * Initial plan * Add ESP32 ethernet header compatibility shim --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>	2026-05-30 11:26:02 -05:00
Copilot	cc9d433db0	Fix mini-epaper-s3 build: resolve SensorLib isBitSet macro conflict with SparkFun MMC5983MA (#10584) ... * Initial plan * Fix SensorLib isBitSet macro conflict with SparkFun MMC5983MA library SensorLib 0.3.4 defines isBitSet as a C preprocessor macro in SensorLib.h, which conflicts with SparkFun_MMC5983MA_IO.h's class method of the same name. When both libraries are included in the same translation unit (e.g., via configuration.h → SensorRtcHelper.hpp → SensorLib chain, alongside the SparkFun MMC5983MA library in lib_deps), the macro expansion causes compile errors like 'expected unqualified-id before const'. Fix: undefine the isBitSet macro right after including SensorRtcHelper.hpp in configuration.h, so it doesn't interfere with SparkFun's class method. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>	2026-05-30 08:59:26 -05:00
Quency-D	60303968bb	Add Heltec mesh node t1 (#10416) ... * add heltec-mesh-node-t1 * fixed low power * Update the sensor enumeration values. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix memory leak in ICM42607PSensor * fix ST7735_MISO error --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>	2026-05-29 12:47:09 -05:00
Catalin Patulea	d3c7f05baa	Simplify tracking of BLE connection handle & improve thread safety. (#10390) ... - Redefine isConnected in terms of nimbleBluetoothConnHandle. isConnected was not safe because BLEServer::getConnectedCount is not thread-safe (https://github.com/espressif/arduino-esp32/issues/12538) while isConnected is called from various threads. Now we can avoid checking bleServer every time before calling isConnected. - getRssi: don't try to "populate nimbleBluetoothConnHandle", that requires calling BLEServer::getPeerDevices which is not thread-safe (same issue as above).	2026-05-29 06:48:43 -05:00
Ben Meadors	1971e5ab13	Remove now unused payload variant settings in allocAtakPli function	2026-05-29 06:15:11 -05:00
Ben Meadors	e2fda6598c	Update protobufs	2026-05-28 21:01:30 -05:00
Benjamin Faershtein	982440d21d	Noise floor (#9347) ... * add noise floor * Sliding window noise floor * Add getCurrentRSSI() to SimRadio for noise floor support * Remove sendLocalStatsToPhone call from runOnce * Change noise floor to int32_t type * Use int32_t for RSSI sample storage in noise floor * Remove float cast from noise floor assignment * Fix Copilot review issues: fix noise floor logic, types, and null pointer - Use robust busyTx/busyRx checks instead of simple isReceiving check - Initialize noiseFloorSamples to NOISE_FLOOR_MIN instead of 0 - Move noise_floor assignment inside null check to prevent potential crash - Change getNoiseFloor() and getAverageNoiseFloor() to return int32_t - Fix RSSI validation to check for positive values (rssi > 0) - Fix format specifier from %.1f to %d for int32_t - Update comments to accurately reflect the sampling logic * Fix RSSI condition to include zero value * Change noise floor initialization to zero * Disable noise floor for LR11x0 chips: getRSSI(bool) unsupported * Remove updateNoiseFloor call from onNotify to avoid radio queue overflow Per PR review feedback, calling updateNoiseFloor() in onNotify() for every ISR event (ISR_TX, ISR_RX, TRANSMIT_DELAY_COMPLETED) can cause the LoRa radio queue to get full. The noise floor sampling still happens in startReceive() and after transmitting. * fix lr11x0 current rssi * Address noise floor review comments * Address Copilot SimRadio noise floor comments * Fix RadioLibInterface formatting --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>	2026-05-28 19:39:41 -05:00
Ben Meadors	f9fea562aa	Add TAKTALK message and room data structures to support voice/text chat	2026-05-27 09:05:38 -05:00
Ben Meadors	c366296ab4	Update LoRaConfig region codes and add new amateur radio bands	2026-05-26 18:56:16 -05:00
Ben Meadors	a076d97eb6	Implement ATAK Plugin V2 and drop unishox2 compression support (#10105) ... * Implement ATAK Plugin V2 and drop unishox2 compression support * Fix course calculation and improve error handling in allocAtakPli * Update src/modules/AtakPluginModule.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix buffer overflow in allocAtakPli by ensuring null termination for callsigns * Add missing include for concurrency::OSThread in AtakPluginModule.h * Update src/modules/AtakPluginModule.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor allocAtakPli to use configurable team and role; improve position source mapping * Update src/modules/PositionModule.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove OSThread inheritance from AtakPluginModule - pure passthrough needs no periodic scheduling Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/bdc82eb6-77c4-4711-839c-04bcbb1aa9cd Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com> * Apply clang-format (trunk fmt) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>	2026-05-26 15:16:47 -05:00
Clive Blackledge	32dcd90abf	Preserve forwarded position payload precision (#10554)	2026-05-26 06:33:11 -05:00
Carlos Valdes	5b7a5b2c22	feat: add Raspberry Pi Pico 2 + W5500 + E22-900M30S variant (#10135) ... * feat: add Raspberry Pi Pico 2 + W5500 + E22-900M30S variant Adds community variant for Raspberry Pi Pico 2 (RP2350, 4 MB flash) with external WIZnet W5500 Ethernet module and EBYTE E22-900M30S LoRa module (SX1262, 30 dBm PA, 868/915 MHz). Key details: - LoRa on SPI1: GP10/11/12/13 (SCK/MOSI/MISO/CS), RST=GP15, DIO1=GP14, BUSY=GP2, RXEN=GP3 (held HIGH via SX126X_ANT_SW) - W5500 on SPI0: GP16/17/18/19/20 (MISO/CS/SCK/MOSI/RST) - SX126X_DIO2_AS_RF_SWITCH: DIO2→TXEN bridge on module handles PA - SX126X_DIO3_TCXO_VOLTAGE 1.8: TCXO support via EBYTE_E22 flags - DHCP timeout reduced to 10 s to avoid blocking LoRa startup - GPS on UART1/Serial2: GP8 TX, GP9 RX - Reuses WIZNET_5500_EVB_PICO2 code paths for Ethernet init Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * pico2_w5500_e22: rename define and address review feedback Rename WIZNET_5500_EVB_PICO2 to PICO2_W5500_E22 so the variant-specific define matches the variant directory name and isn't confused with an on-board EVB SKU. Review fixes from PR #10135: - Gate the 10 s Ethernet DHCP timeout behind PICO2_W5500_E22 so other Ethernet builds keep the default 60 s behavior; apply the same timeout to reconnectETH() for consistency. - Drop the unused -D EBYTE_E22 flag; EBYTE_E22_900M30S already selects TX_GAIN_LORA / SX126X_MAX_POWER in src/configuration.h. - Rewrite "on-board W5500" comments to describe the external module. - Correct README TX_GAIN_LORA value (7, not 10) and drop the EBYTE_E22 row. * fix(pico2_w5500_e22): drop DEBUG_RP2040_PORT=Serial The arduino-pico framework hooks _write() when DEBUG_RP2040_PORT=Serial is set and dumps raw debug bytes onto USB CDC, corrupting any binary protobuf stream sent through StreamAPI (e.g. `meshtastic --port COMx`). The variant excludes BT and WiFi, so the primary client transport is Ethernet TCP via ethServerAPI — unaffected — but users who configure the node over USB serial would see protobuf decode failures from debug-byte interleaving. Removing the flag restores clean USB CDC. Debug output can still be enabled per-build by adding -D DEBUG_RP2040_PORT=Serial1 to redirect to UART0 instead of USB CDC. * style(pico2_w5500_e22): apply trunk fmt — fixes Trunk Check - variant.h: clang-format 16.0.3 (drop manual #define alignment) - README.md: prettier + add `text` language to fenced code blocks (markdownlint MD040) - wiring.svg: svgo optimization Resolves the Trunk Check Runner failure on this PR (3 unformatted files + 8 markdownlint issues). No functional changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(pico2_w5500_e22): address review — move to rp2350/diy, generic guards Maintainer feedback from NomDeTom on PR #10135: - Move the variant from variants/rp2350/ to variants/rp2350/diy/ to distinguish DIY from prebuilt boards (matches the variants/*/diy/ pattern; still discovered via the existing variants/*/diy/*/platformio.ini glob in the root platformio.ini). - Replace the board-name macro PICO2_W5500_E22 in shared code with a generic capability macro USE_ARDUINO_ETHERNET, defined from variant.h. DebugConfiguration.h / ethServerAPI.h / ethClient.cpp no longer reference a board name. - Drop the architecture.h hook entirely: variant.h now defines PRIVATE_HW, which the existing `#elif defined(PRIVATE_HW)` branch already handles. No functional change. Build verified: pico2_w5500_e22 SUCCESS (RAM 19.2%, Flash 28.1%). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(pico2_w5500_e22): drop unoptimized wiring.svg to fix trunk fmt check --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2026-05-25 14:05:46 -05:00
Alexander Balya	5bce26d9b7	Fix SHT2x detection for INA219 addresses (#10482)	2026-05-24 21:03:24 -05:00
Manuel	ef734b73c7	fix: mbed TLS crash in Arduino 3.x (pioarduino) (#10535) ... * fix mbed TLS crash * adapt SSL_MAX_CONTENT_LEN size to framework-libs * found two more	2026-05-22 20:14:42 -05:00
Ben Meadors	c7748a1602	Fix update neighbor_info before checking update_interval in handleSetModuleConfig	2026-05-22 14:53:52 -05:00
Jaime Roldan	91f930d5c0	fix(telemetry): stop emitting -0.001V sentinel when battery unavailable (#7958) (#10217) ... * fix(telemetry): stop emitting -0.001V sentinel when battery unavailable (#7958) * address review: use int32_t for batteryMv to avoid uint16_t signed wrap	2026-05-22 06:58:21 -05:00
κρμγ	f2c5cb0a05	fix: first set pinMode, then write to pin (#10520)	2026-05-21 13:30:27 -05:00
Carlos Valdes	e10e13226d	nrf54l15: fix SHT4x libdep -- arduino-sht, not Adafruit_SHT4X (#10515) ... SHTXXSensor (the SHT4x driver) includes <SHTSensor.h>, gated by __has_include(<SHTSensor.h>). That header ships in Sensirion/arduino-sht. Adafruit_SHT4X ships Adafruit_SHT4X.h and has no consumer anywhere in src/, so the SHT40 driver was silently excluded from the build -- the nRF54L15 variant could not read an SHT4x sensor as committed in #10193. Replace the dead Adafruit_SHT4X libdep with arduino-sht v1.2.6. Validated on nRF54L15-DK: SHT40-AD1B @0x44, 24.3h soak, 0 reboots, temperature/humidity telemetry stable end-to-end. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2026-05-21 11:00:10 -05:00
Tom	5e69bc6c3f	Enable Narrow and Lite regions for EU (#10120) ... * Enable Lite and Narrow regions and introduce getEffectiveDutyCycle for Lite profiles * Add TrafficType enum and extend getConfiguredOrDefaultMsScaled to manage based on regionProfile settings * Refactor telemetry modules to include TrafficType in getConfiguredOrDefaultMsScaled calls * Update submodule protobufs to latest commit * Add support for new region presets and modem presets in menu options * Add new LoRa region codes and modem presets for EU bands * boof * Add modem presets for LITE and NARROW configurations * Update subproject commit reference in protobufs * Update protobufs * Refactor modem preset definitions to use macro for consistency and clarity * Refactor modem preset cases to use PRESET macro for consistency * fix: update LoRa region code for EU 868 narrowband configuration Co-authored-by: Copilot <copilot@github.com> * Fix test suite failure Co-authored-by: Copilot <copilot@github.com> * Add override slot override - for when one override isn't enough. Co-authored-by: Copilot <copilot@github.com> * address copilot comments --------- Co-authored-by: Copilot <copilot@github.com>	2026-05-21 10:20:09 -05:00
BJK	f3cb2bff78	Refactor keyboard cell height logic for consistency (#10501) ... Adjust keyboard cell height calculation for better layout consistency across different screen sizes. Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2026-05-21 06:12:34 -05:00
Austin	894c5556cf	Actions: Fix tagging upon release. (#10521) ... Current release tags are actually based upon the latest state of `develop` currently... Specify target_commitish to always use the commit that triggered the build	2026-05-21 06:09:57 -05:00
Ben Meadors	2f92eb8499	Refactor position precision handling to honor explicit channel settings and prevent location leaks (#10513)	2026-05-20 10:18:46 -05:00
Ben Meadors	8d08077412	Add Ethernet configuration to platformio.ini for ThinkNode variants	2026-05-20 07:12:43 -05:00
Ben Meadors	00ec69201d	Develop protos should be on develop	2026-05-19 06:57:05 -05:00
Ben Meadors	4304480ca3	Merge remote-tracking branch 'origin/master' into develop	2026-05-19 05:37:01 -05:00
github-actions[bot]	82aefd1af1	Upgrade trunk (#10503) ... Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>	2026-05-19 05:23:01 -05:00
Riker	0f9eb86830	Enabled SX_LNA_EN by default (#10469) ... * Enabled SX_LNA_EN by default * Update I2C configuration for IO direction and pull settings --------- Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com>	2026-05-19 04:56:01 -05:00
Thomas Göttgens	e2aa44ec54	T-Echo-Card support (#10267) ... # Conflicts: # src/graphics/draw/UIRenderer.cpp	2026-05-19 09:53:45 +02:00
Thomas Göttgens	1747e2d8e5	T-Echo-Card support (#10267)	2026-05-19 09:31:04 +02:00
Riker	622aa046f1	Enabled SX_LNA_EN by default (#10469) ... * Enabled SX_LNA_EN by default * Update I2C configuration for IO direction and pull settings --------- Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com>	2026-05-19 08:31:42 +02:00
Thomas Göttgens	0832330327	Fix antenna switch initialization logic	2026-05-19 08:00:02 +02:00
Thomas Göttgens	98e0604edf	Fix antenna switch initialization logic once more	2026-05-19 07:58:24 +02:00
github-actions[bot]	23ead5f2f1	Update protobufs (#10500) ... Co-authored-by: caveman99 <25002+caveman99@users.noreply.github.com>	2026-05-19 07:47:06 +02:00
github-actions[bot]	af3739fd63	Update protobufs (#10499) ... Co-authored-by: caveman99 <25002+caveman99@users.noreply.github.com>	2026-05-19 07:22:15 +02:00
github-actions[bot]	0148a89ddb	Upgrade trunk (#10493) ... Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>	2026-05-18 20:49:28 -05:00
Thomas Göttgens	6199faacf1	cherry pick backport fix for cardputer	2026-05-18 23:24:32 +02:00
Thomas Göttgens	3261c04afb	Fix Antenna Switch on Cardputer (#10491)	2026-05-18 11:18:40 +02:00
Austin	a541957480	ESP32: Migrate to Arduino 3.x (pioarduino) (#9122) ... * Migrate esp32 families to pioarduino platform * ESP32c6 align text.handler_execute same as C3 * Use pioarduino `develop` The latest fixes and the latest bugs! * preliminary esp32p4.ini * pioarduino: Update LovyanGFX Includes Manuel's recent commit * pioarduino 3.3.6 * pioarduino 3.3.6 *release* chasing the release * pioarduino: Fix OG ESP32 duplicate libs * pioarduino: T-Beam 1W CDC mode * pioarduino: disable network provisioning (wifiprov) * pioarduino: use legacy esptoolpy naming (forward-compatible) * Update lovyangfx from `develop` commit to 1.2.19 * fix esp32p4.ini * check for esp32 w/ wifi * esp32-p4 specific adaptations * Switch to meshtastic/esp32_https_server fork (idf5 branch) * don't ignore esp_lcd * config for MUI * fix/workaround SDMMC * revert a6f6175, update to 3.3.8 * enable esp_hosted for esp32-p4 (experimental) * Pioarduino 55.03.38-1 * NimBLE-Arduino -> Arduino "BLE" (3.3.x) migration (#10164) * NimBLE-Arduino -> Arduino "BLE" (3.3.x) migration * More NimBLE * Fix Device Name in ATT Read Request (0x2A00). Device Name is exposed in two places: - Advertisement data: this is set properly in startAdvertising. - GATT attribute Device Name (0x2A00). This one is handled internally in NimBLE and comes from ble_svc_gap_device_name_set. This is set initially, but then BLEDevice::createServer calls ble_svc_gap_init which resets the device name. This causes the device to apparently "change name after pairing": < ACL Data TX:... flags 0x00 dlen 7 #113 [hci0] 14.241149 ATT: Read Request (0x0a) len 2 Handle: 0x0003 Type: Device Name (0x2a00) > ACL Data RX: Handle 2048 flags 0x02 dlen 11 #115 [hci0] 14.269050 ATT: Read Response (0x0b) len 6 Value[6]: 6e696d626c65 # "nimble" Workaround this by setting the device name once again after BLEDevice::createServer. * Temporarily lower CORE_DEBUG_LEVEL to INFO to avoid triggering an apparent ESP-IDF Bluetooth bug when re-connecting to Pixel 8 Android devices. Initial pairing works, but after ESP32 is rebooted, phone fails to reconnect. Meshtastic app shows it as disconnecting immediately. LightBlue shows a more detailed error "Peripheral Connection - Warning: onConnectionStatusChange: status 61" (0x3D - MIC Failure). Bug report to Espresssif: https://github.com/espressif/esp-idf/issues/18126#issuecomment-4286197744 * Temporarily disable ble_gap_set_data_len, causes crash with Pixel 8 Android reconnect. Crash looks like this: [ 11966][E][BLEAdvertising.cpp:341] setScanResponseData(): ble_gap_adv_rsp_set_data: 22 [ 11975][E][BLEAdvertising.cpp:1554] start(): Host reset, wait for sync. ERROR | ??:??:?? 11 BLE failed to start advertising Guru Meditation Error: Core 0 panic'ed (LoadProhibited). Exception was unhandled. Core 0 register dump: PC : 0x420e6190 PS : 0x00060730 A0 : 0x820e158b A1 : 0x3fce50c0 A2 : 0x00000000 A3 : 0x3fcb8600 A4 : 0x3fcb85cc A5 : 0x00000000 A6 : 0x00000000 A7 : 0x00000c03 A8 : 0x00000000 A9 : 0x3fce50b0 A10 : 0x0000000e A11 : 0x00000000 A12 : 0x00000010 A13 : 0x3fce50e0 A14 : 0x00000c03 A15 : 0x00000001 SAR : 0x0000001e EXCCAUSE: 0x0000001c EXCVADDR: 0x00000000 LBEG : 0x400570e8 LEND : 0x400570f3 LCOUNT : 0x00000000 Backtrace: 0x420e618d:0x3fce50c0 0x420e1588:0x3fce5110 0x420dfe87:0x3fce5200 0x420dfefb:0x3fce5220 0x420dff3f:0x3fce5240 0x4219602b:0x3fce5260 0x4037b0e5:0x3fce5280 0x4201edf3:0x3fce52a0 Connection seems fast enough even without this. We'll investigate the reason for the crash and re-enable once it's safe. --------- Co-authored-by: Catalin Patulea <cronos586@gmail.com> * Add extension from pioarduino nag "Jason2866.esp-decoder" * Cleanup after merge * ESP32: Disable classic bluetooth * Cleanup: Fix ADC channels on new variants * InkHUD: Fix type casting for message size in saveToFlash method inkhud compiles again! * update p4 esp_hosted for BT * I thought I fixed this * fix linker error using response file (p4 only) * fix infinite loop * Fix Power.cpp check warning Local variable 'config' shadows outer variable [shadowVariable] * Build ESP32 original with NimBLE ('custom_sdkconfig' approach). (#10235) * Re-enable littlefs json manifest This works locally again :) Not sure what changed * Re-add tool-mklittlefs * sensecap indicator fixes after upgrade arduino-esp & lovyanGFX libs * hackaday fix * robot tbeam cache error fix Co-authored-by: Copilot <copilot@github.com> * trunk fmt * ignore trunk * BLEDevice::deinit() added Co-authored-by: Copilot <copilot@github.com> * platformio-custom: Modify mtjson target dependency to prevent fake-success. (#10291) Co-authored-by: Copilot <copilot@github.com> * Fix ESP32-C6 linker errors. Align .text.handler_execute section to 4 bytes and update watchdog timer core mask configuration Co-authored-by: Copilot <copilot@github.com> * tlora-c6: Disable Screen MESHTASTIC_EXCLUDE_SCREEN=1 on tlora-c6. It doesn't have a screen, and this gets it compiling again (saving flash). * Use mverch's iram_memset hack for all OG-ESP32 * Refactor watchdog timer initialization and handling * use adc_channel_t in variant.h * Fix variant headers * More idiomatic default ethernet that doesn't break the build * Elecrows: Delete problematic variant.cpp Not needed after USE_ETHERNET_DEFAULT --------- Co-authored-by: mverch67 <manuel.verch@gmx.de> Co-authored-by: Manuel <71137295+mverch67@users.noreply.github.com> Co-authored-by: Catalin Patulea <cronos586@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2026-05-17 18:53:32 -05:00
Jonathan Bennett	767a748188	add optional LED_LORA to indicate LoRa TX (#10465)	2026-05-16 22:11:49 -05:00
Jord	fc5556b8e6	Clamp direct position packets to channel precision (fixes #8640) (#10383) ... * Fix position precision for direct sends * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Clarify zero position precision logging * Use const channel reference for position precision * Use C linkage for position precision test entrypoints --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>	2026-05-16 14:08:46 -05:00
Carlos Valdes	4a1ff18f57	feat: add Nordic nRF54L15-DK variant (Zephyr + BLE + LoRa) (#10193) ... * feat: add Nordic nRF54L15-DK variant (Zephyr + BLE + LoRa) Adds a community hardware variant for the Nordic nRF54L15-DK (PCA10156) with an external EBYTE E22-900M30S (SX1262) LoRa module. First Meshtastic port running on the Zephyr RTOS; all other Nordic targets use the nRF5 SoftDevice stack. Scope ----- - New Zephyr-based platform layer under src/platform/nrf54l15/ providing Arduino-compatible shims (Arduino.h, SPI, Wire, Print, Stream) over the Zephyr APIs plus a LittleFS-backed InternalFileSystem on SPIM20. - Bluetooth LE peripheral (NRF54L15Bluetooth.*) built on the Zephyr BT host stack, exposing the Meshtastic GATT service with legacy connectable advertising, just-works pairing, dynamic MTU exchange (up to 247 bytes), and iOS connection-parameter tweaks. - Variant directory variants/nrf54l15/nrf54l15dk/ with pin map for the E22 module on connector J1, PlatformIO env (nrf54l15dk), Zephyr DT overlay and a wiring README. - Zephyr project config (zephyr/prj.conf + board overlay) tuned for BT + LoRa: 16 KB main stack, 4 KB BT RX thread, RTT logging in immediate mode, newlib-nano heap sized to leave room for the GATT pools while still allowing ATT MTU=247. - extra_scripts/nrf54l15_linker.py works around a PlatformIO + old Ninja issue where Zephyr's two-pass linker script generation does not run automatically; the post-script parses build.ninja and invokes the gcc -E step directly before the final link. - boards/nrf54l15dk.json board definition (PlatformIO needs it for the DK; the Seeed platform only ships the XIAO variants). - variants/rp2350/rp2350.ini excludes platform/nrf54l15/ from RP2350 build_src_filter so the shared platform tree does not leak between targets. - .gitignore: add nRF J-Link / RTT debug artifacts (flash.jlink, rtt_*.txt). Shared source changes --------------------- - src/main.{cpp,h}, src/RedirectablePrint.cpp, src/FSCommon.{cpp,h}, src/mesh/{Channels,NodeDB,RadioLibInterface,MeshService,PhoneAPI}.cpp, src/mesh/RadioLibInterface.h, src/modules/AdminModule.cpp: add small guards / helpers so the Zephyr build compiles alongside the Arduino targets. Behavior on existing boards is unchanged. Hardware model -------------- HW_VENDOR maps to meshtastic_HardwareModel_PRIVATE_HW until a dedicated protobuf enum value is assigned upstream. The variant declares custom_meshtastic_hw_model = 132 so the maintainers can wire the new enum value through the protobufs repo after merge. Hardware note ------------- The E22-900M30S does not connect its DIO2 pin to TXEN internally — a wire/solder bridge between DIO2 and TXEN on the module is required for TX to work. Details and full pin map are in the variant README. Validation ---------- Built clean against develop. On real hardware (April 2026) the port passes end-to-end: iOS companion app pairs and connects, configuration round-trip works, LoRa TX/RX reaches a canonical tbeam on the same mesh channel, NodeDB updates propagate both ways, and traceroute completes. * fix(nrf54l15): use atomic fs_rename instead of copy fallback Zephyr LittleFS on nrf54l15 supports fs_rename natively, so route it through the same atomic path as ESP32. The previous copyFile+remove fallback truncated the destination before copying, leaving 0-byte files if interrupted mid-write. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15): expand storage_partition from 36KB to 700KB LittleFS on the default 9-block (36KB) storage_partition ran out of space during copy-on-write of config.proto, causing fs_write to return ENOSPC and pb_encode to surface "io error" when saving configuration via the mobile app. Reclaim slot1_partition (the MCUboot secondary slot — unused since we flash directly via J-Link) and grow storage_partition to span 0xb6000..0x165000 (~175 blocks). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15): drop USERPREFS_LORACONFIG_* so LoRa config stays mutable NodeDB rewrites LoRa config from USERPREFS_LORACONFIG_* on every boot, which prevented reconfiguration via the BLE/serial app. Drop the variant-level defaults; users configure region and modem preset through the app like every other variant. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15): enforce MITM passkey pairing on GATT service - Add MESH_PERM_READ/MESH_PERM_WRITE macros (READ_AUTHEN/WRITE_AUTHEN) on all mesh service characteristics so clients must complete passkey exchange before accessing fromNum/fromRadio/toRadio/logRadio. - Wire FIXED_PIN mode to bt_passkey_set() so the device advertises a known PIN (config.bluetooth.fixed_pin); RANDOM_PIN keeps default per-pairing random passkey. - Reduce BleDeferredThread HARD_WATCHDOG_MS from 3min to 1min. - prj.conf: CONFIG_BT_SMP_ENFORCE_MITM=y, CONFIG_BT_FIXED_PASSKEY=y, CONFIG_BT_SMP_SC_PAIR_ONLY=n (legacy fallback for clients that abort SC pairing with reason 0x01 within 150ms). * fix(nrf54l15): resolve develop-merge conflict + cppcheck warnings The `Merge branch 'develop'` left two ~RadioLibInterface() declarations in src/mesh/RadioLibInterface.h: the inline version added upstream by PR #10254 (which independently applied the same UAF guard this PR was carrying) and the out-of-line version this PR introduced. GCC rejects the duplicate, breaking every platform build. Drop the out-of-line declaration + definition; keep upstream's inline form. Also silence the 13 cppcheck low warnings introduced by the new nrf54l15 Arduino shim — Arduino's `String`/`SPISettings` API contract relies on implicit single-arg constructors used pervasively by existing Meshtastic code, so suppress `noExplicitConstructor` inline with a comment instead of breaking the API. The few mechanical wins (`const tmp[2]`, `const uint32_t *sp`) are applied directly. * fmt: fix Trunk Check lint issues on nrf54l15-port - extra_scripts/nrf54l15_linker.py: move regular imports above Import("env") to silence E402, add trunk-ignore-all(F821) for the PIO/SCons SConstruct injection (matches esp32_pre.py / nrf52_extra.py convention) - src/platform/nrf54l15/NRF54L15Bluetooth.cpp: clang-format 16.0.3 - boards/nrf54l15dk.json + variants/nrf54l15/nrf54l15dk/README.md: prettier 3.8.3 (also resolves markdownlint MD060 on README tables) No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15): address Copilot review comments + correct clang-format style Six review threads from the 2026-04-30 Copilot review: - src/platform/nrf54l15/nrf54l15_main.cpp: validate PSP against the nRF54L15 SRAM range (0x20000000..0x20040000) and 4-byte alignment before walking the faulting thread's stack, and clamp the walk so it never reads past the end of RAM. Prevents a second fault inside the fatal handler when PSP is corrupted (common in real faults). - src/platform/nrf54l15/nrf54l15_arduino.cpp: gate the bring-up printk traces in digitalWrite/digitalRead (CS/NRESET toggle log, BUSY-before-NRESET snapshot, BUSY periodic timeline) behind a new -DNRF54L15_GPIO_DEBUG flag that is off by default. The "dev NOT READY" message stays unconditional — it indicates a genuine hardware/DTS misconfig. - src/modules/AdminModule.cpp: don't mutate config.device.output_gpio_enabled from handleGetConfig(). Reflect the live pin state in the response payload only — a getter must not write back to disk-persisted state. - src/platform/nrf54l15/InternalFileSystem.h: derive totalBytes() from FIXED_PARTITION_SIZE(storage_partition) at compile time so it tracks the DK overlay's ~700 KB partition instead of the stale 36 KB hard-coded value. Updated the file header comment accordingly. - extra_scripts/nrf54l15_linker.py: make _extract_gcc_command() handle the POSIX Ninja COMMAND format (no `cmd.exe /C "..."` wrapper) in addition to the Windows form, so the script doesn't hard-fail on Linux/macOS hosts. - src/platform/nrf54l15/NRF54L15Bluetooth.cpp: clamp NO_PIN to RANDOM_PIN with a one-shot LOG_WARN. The mesh GATT permissions are declared with BT_GATT_PERM_*_AUTHEN and prj.conf sets CONFIG_BT_SMP_ENFORCE_MITM=y, so NO_PIN with no auth callbacks would leave every characteristic returning BT_ATT_ERR_AUTHENTICATION. Falling back to RANDOM_PIN keeps the link usable instead of silently broken. Also re-formatted this file with the project's .trunk/configs/.clang-format (Linux braces, 4-space indent, 130-col) — the previous lint-fix commit a2aca3234 accidentally used the default LLVM style here, which CI's clang-format would have rejected. Build verified: pio run -e nrf54l15dk passes, RAM 47.4%, Flash 28.6%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15): address remaining Copilot review threads Round 2/3 review fixes — bugs first, then docs/portability: BLE concurrency (NRF54L15Bluetooth.cpp): - onNowHasData / sendLog / BleDeferredThread / shutdown: acquire active_conn under ble_mutex via new acquire_active_conn() helper so disconnected_cb can't free the conn between the null check and bt_conn_ref/bt_gatt_notify (use-after-unref). - write_toradio: reject writes that exceed MAX_TO_FROM_RADIO_SIZE with ATT_ERR_INVALID_ATTRIBUTE_LEN instead of returning success and silently dropping the payload (would hide failed config writes from the phone). - start_advertising: truncate the device name to fit the 31-byte legacy scan-response limit and switch to BT_DATA_NAME_SHORTENED so bt_le_adv_start() doesn't reject the payload when the name approaches CONFIG_BT_DEVICE_NAME_MAX=32. Linker / portability: - main.h: drop the rp2040Loop() forward declaration that had no definition and no callers — would surface as a link error if any RP2040 build added a call to the symbol. - nrf54l15_arduino.cpp: transfer16() now uses static __aligned(4) DMA buffers (matching transfer()), removing the EasyDMA-reachability hazard of caller-stack buffers on this part. Filesystem (InternalFileSystem.h): - usedBytes(): return real usage from fs_statvfs() instead of 0 so OTA / range-test free-space guards work. - rewindDirectory(): close the dir before reopening — Zephyr fs_dir_t has no rewind, and re-fs_opendir on an open handle leaks LittleFS state. Crash handler (nrf54l15_main.cpp): - After the stack walk, busy-wait 50 ms to flush RTT/printk and call sys_reboot(SYS_REBOOT_COLD) directly so the saved_crash record is actually reported on the next boot. Default Zephyr config has RESET_ON_FATAL_ERROR=n, so the previous k_fatal_halt() spun forever. Generalization / config: - PhoneAPI.cpp: replace the NRF54L15_DK ifdef with a MESHTASTIC_EXCLUDE_FILES_MANIFEST capability flag (defined in the nrf54l15dk env) so future variants can opt in/out without touching shared code. - variants/nrf54l15/nrf54l15.ini: parameterize libdeps include paths via ${PIOENV} so additional nRF54L15 envs sharing nrf54l15_base don't break. - prj.conf: drop the stale "36 KB storage_partition" comments — the DK overlay reclaims slot1 to ~700 KB and runtime size comes from FIXED_PARTITION_SIZE. - nrf54l15dk overlay: remove the zephyr,console / zephyr,shell-uart chosen entries that conflicted with CONFIG_UART_CONSOLE=n + RTT console; keep uart30 enabled so swapping the console is one Kconfig flip away. Build: nrf54l15dk SUCCESS (flash 28.6%, RAM 47.4%); wiznet_5500_evb_pico2 SUCCESS (verifies the shared main.h change). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15dk): use PRIVATE_HW (255) for custom_meshtastic_hw_model Per @thebentern's review: the nRF54L15-DK is a development kit, not a canonical Meshtastic SKU, so it falls under HardwareModel::PRIVATE_HW (255) — the same enum value already used at runtime via HW_VENDOR. The placeholder 132 is removed; no dedicated enum number will be assigned for DK boards. Slug stays NRF54L15_DK as a human-readable identifier. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(nrf54l15): unstarve bt_long_wq so SC pairing completes bt_pub_key_gen() runs the ECC P256 key generation on bt_long_wq. At default prio=10 (preemptible) and stack=1400 it gets starved by Meshtastic app threads at boot — sc_public_key stays NULL for minutes, smp_public_key() defers with SMP_FLAG_PKEY_SEND, and every SC pairing attempt stalls right after the public-key exchange. iOS shows "Connecting…" forever with no PIN prompt; bleak/CLI fails the first CCC notify write with "Protocol Error 0x05: Insufficient Authentication". Set CONFIG_BT_LONG_WQ_PRIO=0 (highest preemptible, ties with main) and CONFIG_BT_LONG_WQ_STACK_SIZE=4096 (margin for the P256M driver frames). Validated E2E with iOS Meshtastic app: bt_smp_pkey_ready fires within ~40 s of boot, 20 SC Passkey Entry rounds complete with matching pcnf/cfm, encrypt 0x01 / sec_level 0x04 (Authenticated MITM), bonded=1. * feat(nrf54l15): hardware I2C bus via TWIM30 + sensor telemetry Adds the Arduino TwoWire layer for the nRF54L15-DK so Meshtastic's sensor drivers can talk to external I2C devices over the hardware TWIM30 peripheral. Bus binding: - &uart30 disabled in the board overlay (peripheral instance 30 is shared between UARTE30 / TWIM30 / SPIM30 — pick one). Console stays on RTT via CONFIG_RTT_CONSOLE. - New i2c30_default / i2c30_sleep pinctrl with SDA=P0.03 / SCL=P0.04. External 4.7 kOhm pull-ups required on both lines. - &i2c30 enabled at I2C_BITRATE_FAST (400 kHz). - button_3 (SW3, P0.04) deleted from DTS so the pad can be claimed by i2c30 pinctrl; SW3 is still wired to the pad on the DK, do not press it during I2C use or it will short SCL to GND. Arduino layer: - src/platform/nrf54l15/Wire.cpp resolves the DT node at compile time via DEVICE_DT_GET(DT_NODELABEL(i2c30)) and dispatches Arduino's beginTransmission / write / endTransmission / requestFrom to i2c_write / i2c_write_read / i2c_read. Buffer is sized to 256 bytes for forward compatibility with the SE050 secure element on the custom PCB. - Wire.h drops the prior compile-only stubs and exposes the real TwoWire surface. - Arduino.h: BitOrder becomes an enum (not #define) so Adafruit_BusIO's `typedef BitOrder BusIOBitOrder;` compiles. Variant + build flags: - nrf54l15.ini flips HAS_WIRE / HAS_SENSOR / HAS_TELEMETRY from 0 to 1 and cherry-picks the sensor libs Meshtastic needs (BusIO, Sensor, BMP280, BME280, INA219/226/260/3221, SHT4X). The full environmental_base group is avoided because it pulls Adafruit_SSD1306 / Adafruit_GFX which rely on Arduino pin macros the Zephyr shim does not implement. - nrf54l15dk variant.h defines PIN_WIRE_SDA / PIN_WIRE_SCL for parity with the Arduino convention used by other variants. The actual bus wiring is fixed by the overlay pinctrl above. Validated 2026-05-14/15 on the DK with BMP280 @ 0x76 (temperature + barometric pressure) and INA3221 @ 0x42 (rail voltage / current); EnvironmentTelemetry / PowerTelemetry packets transmit successfully over LoRa. Footprint cost on nrf54l15dk: +45 KB flash, +1.7 KB RAM. * feat(nodedb): honor USERPREFS for environment telemetry on first boot installDefaultConfig() now respects two new compile-time prefs: USERPREFS_CONFIG_ENV_TELEM_UPDATE_INTERVAL USERPREFS_CONFIG_ENVIRONMENT_MEASUREMENT_ENABLED The mobile apps enforce a 30 min floor on environment_update_interval in the settings UI, which makes short-interval bring-up testing of new sensor hardware painful — you have to wait half an hour for the first LoRa packet to confirm wiring + driver. With these prefs baked into the variant, the firmware can ship a freshly-flashed device that broadcasts on a shorter cadence (e.g. 900 s) the moment storage_partition is empty. Both prefs are gated on #ifdef so the behavior is unchanged for any variant that does not opt in. Documented in userPrefs.jsonc with the existing telemetry-interval pref block. * fix(nrf54l15): allow multiple bonded BLE peers CONFIG_BT_MAX_PAIRED defaults to 1, so once the first peer (e.g. an iOS phone) has paired and bonded, every subsequent pairing attempt from a different MAC fails inside bt_keys_get_addr() with no free key slot — the host returns BT_SECURITY_ERR_KEY_DOES_NOT_EXIST and the second peer never gets past SMP. Raise the slot count to 4 so the device can simultaneously hold an iOS phone, a Windows host, a Linux host, and one spare bond. Add BT_KEYS_OVERWRITE_OLDEST so that once the table fills, the LRU peer is evicted on the next pairing rather than rejecting the new peer. This matches the behavior other Meshtastic ports already provide (nRF52 uses CONFIG_BT_PERIPHERAL_PRIO_CONN with similar semantics). Discovered while bringing up the Python CLI on Windows alongside the existing iOS bond. * fix(nrf54l15): zero-initialize TwoWire buffers + clang-format Wire cppcheck on every CI target (esp32s3, rp2040, rp2350, nrf52840, ...) was failing the build with two `uninitMemberVar` warnings on TwoWire's constructor: `txBuf` and `rxBuf` (256-byte arrays) were not initialized. Even though the buffers are only read after txLen/rxLen is set, leaving them uninitialized is a footgun if any future caller bypasses the len-set step. Use C++11 value-initialization in the member initializer list — costs ~512 B of memset at boot, gains a clean cppcheck pass and defensive-against-future-changes semantics. Also reformat Wire.{cpp,h} with the project's `.trunk/configs/.clang-format` config so the Trunk Check Runner passes — clang-format moved the `<errno.h>` include before the Zephyr-namespaced ones in Wire.cpp and collapsed two inline overloads to single lines in Wire.h. * fix(AdminModule): remove dead OUTPUT_GPIO_PIN/GpioOutputModule references OUTPUT_GPIO_PIN is never defined and modules/GpioOutputModule.h doesn't exist in the codebase; all #ifdef OUTPUT_GPIO_PIN branches were dead code introduced by the nRF54L15-DK variant commit. Strips the include, the output_gpio_enabled OFF→ON/ON→OFF transition logic in handleSetConfig(), and the digitalRead() reflection in handleGetConfig(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2026-05-16 06:16:11 -05:00