223 Commits

Author	SHA1	Message	Date
Eric Severance	3b0232de1b	Validate MQTT config by testing a connection (#6076)	2025-02-17 15:03:44 -06:00
Eric Severance	7648391f91	Reject invalid configuration for the default MQTT server (#6066) ... * Sanity check configuration for the default MQTT server * Skip for MESHTASTIC_EXCLUDE_MQTT --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2025-02-16 07:15:30 -06:00
Eric Severance	50b7d6a0f7	Establish MQTT connection only from MQTT::runOnce (#6057) ... Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2025-02-14 20:32:41 -06:00
Eric Severance	c83ffd4911	Consider the MQTT TLS remote IP when enabled. (#6058)	2025-02-14 19:19:50 -06:00
Jason P	cd8592ef4a	Fixes #5766 Updated MQTT privateCidrRanges to add Tailscale (#5957)	2025-01-29 06:14:43 -06:00
Eric Severance	27fbfd03d6	Add unit tests for MQTT (#5724) ... * Add unit tests for MQTT * Test received fields	2025-01-07 07:10:42 -06:00
isseysandei	66a961cb75	increased buffer size to 1024 (#5733)	2025-01-03 11:35:34 -06:00
Eric Severance	9f7cbf1b4f	MQTT unit test can inject WiFiClient (#5716)	2025-01-02 19:32:39 +08:00
Eric Severance	c2c06ed0ad	Move DecodedServiceEnvelope into its own file (#5715)	2025-01-02 08:40:14 +08:00
Tom Fifield	e45c0e4d40	Minor cppcheck fixes (#5689) ... * In graphics/Screen.cpp, a copy/paste error to do with hearts * In mesh/http/ContentHandler.cpp, an unused variable * in mqtt/MQTT.cpp, remove unneded logic " '!A || (A && B)' is equivalent to '!A || B'"	2024-12-28 18:56:05 -06:00
GUVWAF	b12aa3f360	Unset received SNR/RSSI values upon receiving packet via MQTT (#5668)	2024-12-26 20:49:06 +11:00
Eric Severance	a7d9e8107a	More accurately determine if MQTT uses the default server (#5663) ... * More accurately determine if MQTT uses the default server * Channels::anyMqttEnabled() uses same logic * Remove previous static bool	2024-12-25 08:33:53 -06:00
Eric Severance	143e1d1a0d	Check if MQTT remote IP is private (#5647) ... Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-12-23 09:48:07 -06:00
Eric Severance	2fd5a4848a	Separate host:port before checking for private IP (x2) (#5643)	2024-12-21 14:07:20 -06:00
Ben Meadors	fb7866fca7	Revert "Check if MQTT remote IP is private (#5627)" (#5636) ... This reverts commit 9a10907a2d.	2024-12-21 07:49:25 -06:00
Ben Meadors	d9b287880f	Revert "Separate host/port before checking for private IP (#5630)" (#5635) ... This reverts commit 398d29064e.	2024-12-21 07:48:47 -06:00
Ben Meadors	f39a9c5083	Clean up some straggler NRF52 json (#5628)	2024-12-21 14:42:54 +11:00
Eric Severance	398d29064e	Separate host/port before checking for private IP (#5630)	2024-12-21 14:06:01 +11:00
Eric Severance	9a10907a2d	Check if MQTT remote IP is private (#5627)	2024-12-20 19:25:31 -06:00
Eric Severance	58d80b8557	Use IPAddress.fromString for parsing private IPs (#5621)	2024-12-21 11:21:27 +11:00
Eric Severance	658459aaf3	Use encoded ServiceEnvelope in mqttQueue (#5619)	2024-12-20 14:59:23 -06:00
Eric Severance	8c6eec52f2	Refactor MQTT::onReceive to reduce if/else nesting (#5592) ... * Refactor MQTT::onReceive to reduce if/else nesting * Fix missing #include <functional> * const DecodedServiceEnvelope e * Combine validDecode if statement. * Only call pb_release when validDecode. * s/ptr/channelName/ * Use reference type for deleter * Use lambda instead of bind * Document deleter * Reorder 'if's to avoid object creation * Remove unnecessary comment * Remove 'else'; simpifies #5516 --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-12-19 05:47:46 -06:00
Tomas Dubec	7c2b6778cb	enable MQTT with TLS on RPi picow (#5442) ... Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-11-25 06:12:19 -06:00
César de Tassis Filho	37da78919a	Fix memory leaks by adding missing free() calls before early returns in MQTT::onReceive (#5439) ... This fix addresses memory leaks in the `MQTT::onReceive` function by ensuring that dynamically allocated resources (`e.channel_id`, `e.gateway_id` and `e.packet`) are properly freed before each early return. Previously, these resources were only freed at the end of the function, leaving them unhandled in certain exit paths. Adding the missing `free()` calls prevents memory leaks and ensures proper resource cleanup in all scenarios.	2024-11-25 12:05:06 +08:00
Ben Meadors	f5058a9cbb	Check for OkToMqtt flag presence before uplinking to MQTT (#5413) ... * Check for oktomqtt flag presence before uplinking to MQTT * Move to mqtt->onSend	2024-11-21 14:52:54 -06:00
GUVWAF	9b4c260a92	Fix memory leak in MQTT (#5311)	2024-11-11 13:22:22 +01:00
Ben Meadors	f769c50fa5	More reduction (#5256) ... * Now with even fewer ings * Ye * Mo * QMA6100PSensor	2024-11-04 19:15:59 -06:00
Ben Meadors	50dac38a1b	Pass#2: Lots more savings in logs and string reduction surgery (#5251) ... * Pass#2: Lots more savings in logs and string reduction surgery * Don't need Thread suffix either * Warn	2024-11-04 12:16:25 -06:00
Tom Fifield	276067065e	Log cleanups (#5135) ... * Log cleanups change log levels, shorten log messages, delete commented out logs * Address comments from review * Remove full stops * EDEBUG --> DEBUG	2024-11-04 06:09:23 -06:00
Thomas Göttgens	93318b4f56	T1000-E Peripherals (#5141) ... * T1000-E Peripherals - enable intelligent charge controller signals - enable Accelerometer - enable internal I2C bus - provide Power to Accelerometer * POC Accelerometer Code (wakeScreen is moot for that device, just test if the driver works) * fix building without the sensor	2024-10-26 12:03:28 +02:00
Robert	a4705d2c19	add RFC 3927 IP address space to private IP checks (#5115) ... Add the RFC 3927 IP address block (169.254.0.0/16), also referred to as IPIPA, to the private address checks for MQTT functionality.	2024-10-21 19:25:27 +11:00
Johnathon Mohr	fbb6778415	Account for port specification with IP address for MQTT server. Some additional format validation. (#5084)	2024-10-17 05:05:35 -05:00
Johnathon Mohr	3e5f129fce	Ensure the MQTT address is an IPv4 before determining it's private (#5081) ... * Ensure the mqtt address is an IPv4 (or at least not a domain) before determining it's private. * check address length	2024-10-16 05:19:00 -05:00
Johnathon Mohr	ad214ea42a	Add MQTT exception for private IP address server (#5072) ... Determines if the given IP address is a private address, i.e. not routable on the public internet. These are the ranges: 127.0.0.1, 10.0.0.0-10.255.255.255, 172.16.0.0-172.31.255.255, 192.168.0.0-192.168.255.255. If so, allow MQTT publication the same as existing localhost support.	2024-10-16 11:08:49 +11:00
Thomas Göttgens	05e4a639a1	remove newline from logging statements. (#5022) ... remove newline from logging statements in code. The LOG_* functions will now magically add it at the end. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-10-14 15:11:43 +11:00
GUVWAF	d55c08d5cd	Uplink DMs not to us if MQTT encryption enabled (#5025) ... * Uplink DMs not to us if MQTT encryption enabled * Only really need to try uplinking encrypted packet if MQTT encryption is enabled * Add log about publishing nothing when packet is not decrypted and encryption_enabled is false * Improve comment	2024-10-10 15:11:58 -05:00
Jonathan Bennett	f82585d9b0	Add localhost exception for dontMqttMeBro (#5023)	2024-10-10 14:06:47 -05:00
Thomas Göttgens	9d9258a59b	conflict resolution	2024-10-08 11:41:54 +02:00
GUVWAF	673fe294f3	Add rxDupe, txRelay and txRelayCanceled to LocalStats (#4936) ... * Introduce `isFromUs()` and `isToUs()` * Add rxDupe, txRelay and txRelayCanceled to LocalStats	2024-10-04 06:28:51 -05:00
Thomas Göttgens	cb1cf055b1	Merge branch 'master' into esp32-c6	2024-09-27 22:51:29 +02:00
Thomas Göttgens	b4bdf604f5	tryfix	2024-09-26 11:08:49 +02:00
Thomas Göttgens	12481b568a	fix a lot of nuisances reported by cppcheck (#4872) ... * fix a lot of nuisances reported by cppcheck * fix portduino	2024-09-25 19:09:06 -05:00
Thomas Göttgens	3072b2a444	Merge branch 'master' into esp32-c6	2024-09-26 00:20:00 +02:00
Thomas Göttgens	118809fbfc	Account for size of Envelope when allocating buffer. (#4819) ... * Account for size of Envelope when allocating buffer. INFO | 09:29:20 568 [mqtt] Subscribing to msh/2/e/LongFast/+ INFO | 09:29:20 568 [mqtt] Subscribing to msh/2/json/LongFast/+ INFO | 09:29:20 568 [mqtt] Subscribing to msh/2/e/PKI/+ DEBUG | 09:29:20 568 [mqtt] Publishing enqueued MQTT message ERROR | 09:29:20 568 [mqtt] Panic: can't encode protobuf reason='bytes size exceeded' assert failed: size_t pb_encode_to_bytes(uint8_t*, size_t, const pb_msgdesc_t*, const void*) mesh-pb-constants.cpp:18 (0) * save some mem	2024-09-25 17:13:04 -05:00
Tom Fifield	e6e05dda1e	Merge branch 'master' into master	2024-09-25 15:10:48 +08:00
Ben Meadors	e8829b8f52	Refactor and consolidate time window logic (#4826) ... * Refactor and consolidate windowing logic * Trunk * Fixes * More * Fix braces and remove unused now variables. There was a brace in src/mesh/RadioLibInterface.cpp that was breaking compile on some architectures. Additionally, there were some brace errors in src/modules/Telemetry/AirQualityTelemetry.cpp src/modules/Telemetry/EnvironmentTelemetry.cpp src/mesh/wifi/WiFiAPClient.cpp Move throttle include in WifiAPClient.cpp to top. Add Default.h to sleep.cpp rest of files just remove unused now variables. * Remove a couple more meows --------- Co-authored-by: Tom Fifield <tom@tomfifield.net>	2024-09-23 08:58:14 -05:00
Thomas Göttgens	6ffdc9875b	First stab at ESP32-C6 support for TLora-C6	2024-09-20 19:37:47 +02:00
Ben Meadors	85d722232e	Additional decoded packet ignores	2024-09-20 07:35:26 -05:00
Ben Meadors	921d92c649	Drop received packets from self	2024-09-20 06:55:16 -05:00
GUVWAF	db4a793aa9	Merge branch 'master' into master	2024-09-18 11:38:40 +02:00