mirror of
https://github.com/meshtastic/firmware.git
synced 2025-09-07 20:19:25 +00:00
f26e657577
- Fix esptool detection to use 'version' subcommand instead of no arguments - Fix device-update.bat to use 115200 bps for flashing, 1200 bps only for reset - Add missing closing quotes in debug messages Replace magic numbers with named constants for better maintainability - Add RESET_BAUD=1200 constant for reset baud rate - Add UPDATE_OFFSET=0x10000 constant for update flash offset - Use constants instead of hardcoded values throughout script Extract magic numbers to constants in shell scripts for consistency - Add FLASH_BAUD, RESET_BAUD, UPDATE_OFFSET constants to device-update.sh - Add RESET_BAUD, FIRMWARE_OFFSET constants to device-install.sh - Replace hardcoded values with named constants throughout - Maintain consistency with batch script improvements Fix Python path quoting and remove unreachable code - Quote Python interpreter paths to handle spaces in paths like 'C:\Program Files\Python\python.exe' - Remove unreachable GOTO statements after EXIT /B commands - Improve robustness when custom Python interpreters are specified Fix esptool detection for pipx installations - Change from checking ERRORLEVEL GEQ 2 to EQU 9009 - Pipx-installed esptool returns exit code 2 when showing help (normal) - Only treat Windows 'command not found' error (9009) as truly not found - Add debug output to show actual exit codes for troubleshooting
90 lines
2.2 KiB
Bash
Executable File
90 lines
2.2 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
PYTHON=${PYTHON:-$(which python3 python|head -n 1)}
|
|
CHANGE_MODE=false
|
|
|
|
# Constants
|
|
FLASH_BAUD=115200
|
|
RESET_BAUD=1200
|
|
UPDATE_OFFSET=0x10000
|
|
|
|
# Determine the correct esptool command to use
|
|
if "$PYTHON" -m esptool version >/dev/null 2>&1; then
|
|
ESPTOOL_CMD="$PYTHON -m esptool"
|
|
elif command -v esptool >/dev/null 2>&1; then
|
|
ESPTOOL_CMD="esptool"
|
|
elif command -v esptool.py >/dev/null 2>&1; then
|
|
ESPTOOL_CMD="esptool.py"
|
|
else
|
|
echo "Error: esptool not found"
|
|
exit 1
|
|
fi
|
|
|
|
# Usage info
|
|
show_help() {
|
|
cat << EOF
|
|
Usage: $(basename "$0") [-h] [-p ESPTOOL_PORT] [-P PYTHON] [-f FILENAME|FILENAME] [--change-mode]
|
|
Flash image file to device, leave existing system intact."
|
|
|
|
-h Display this help and exit
|
|
-p ESPTOOL_PORT Set the environment variable for ESPTOOL_PORT. If not set, ESPTOOL iterates all ports (Dangerous).
|
|
-P PYTHON Specify alternate python interpreter to use to invoke esptool. (Default: "$PYTHON")
|
|
-f FILENAME The *update.bin file to flash. Custom to your device type.
|
|
--change-mode Attempt to place the device in correct mode. Some hardware requires this twice. (1200bps Reset)
|
|
|
|
EOF
|
|
}
|
|
|
|
# Check for --change-mode and remove it from arguments
|
|
NEW_ARGS=()
|
|
for arg in "$@"; do
|
|
if [ "$arg" = "--change-mode" ]; then
|
|
CHANGE_MODE=true
|
|
else
|
|
NEW_ARGS+=("$arg")
|
|
fi
|
|
done
|
|
|
|
set -- "${NEW_ARGS[@]}"
|
|
|
|
while getopts ":hp:P:f:" opt; do
|
|
case "${opt}" in
|
|
h)
|
|
show_help
|
|
exit 0
|
|
;;
|
|
p) ESPTOOL_CMD="$ESPTOOL_CMD --port ${OPTARG}"
|
|
;;
|
|
P) PYTHON=${OPTARG}
|
|
;;
|
|
f) FILENAME=${OPTARG}
|
|
;;
|
|
*)
|
|
echo "Invalid flag."
|
|
show_help >&2
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
shift "$((OPTIND-1))"
|
|
|
|
if [ "$CHANGE_MODE" = true ]; then
|
|
$ESPTOOL_CMD --baud $RESET_BAUD --after no_reset read_flash_status
|
|
exit 0
|
|
fi
|
|
|
|
[ -z "$FILENAME" ] && [ -n "$1" ] && {
|
|
FILENAME="$1"
|
|
shift
|
|
}
|
|
|
|
if [ -f "${FILENAME}" ] && [ -z "${FILENAME##*"update"*}" ]; then
|
|
echo "Trying to flash update ${FILENAME}"
|
|
$ESPTOOL_CMD --baud $FLASH_BAUD write-flash $UPDATE_OFFSET "${FILENAME}"
|
|
else
|
|
show_help
|
|
echo "Invalid file: ${FILENAME}"
|
|
fi
|
|
|
|
exit 0
|