237 Commits

Author	SHA1	Message	Date
Dirk Mueller	fe6509a0f2	Avoid exceeding allocated buffers when doing MQTT proxying (#8320) ... the topic length could be longer than 65 characters. similarly for the payload. Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2025-10-13 06:57:21 -05:00
Ben Meadors	627c0145e7	Centralize getNodeId and fix references to owner.id (#8230)	2025-10-06 07:56:27 -05:00
Ben Meadors	c19f573b49	Fix TLS port bug on default mqtt validation	2025-08-19 20:10:47 -05:00
Jonathan Bennett	e26de85b5f	Mark meshPackets based on which interface received. (#7589)	2025-08-11 21:47:04 -05:00
Ben Meadors	a506dc6b65	Fix MQTT config bugs (#7446) ... * Fix mqtt config bugs * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add client notification * Verbiage * Update src/mqtt/MQTT.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/mqtt/MQTT.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/mqtt/MQTT.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/mqtt/MQTT.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove test that is no longer true * This test no longer exists * Fix client notification crap * Suppress false positive * Revert "Suppress false positive" This reverts commit bead96eaee. * Try macro exclusion * Derp * Fix --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jason P <applewiz@mac.com>	2025-07-26 05:38:24 -05:00
Ben Meadors	31d56c16d5	Map report should work over devices which do not have network hardware (with client proxy) (#7341) ... * Map report should work over devices which do not have network hardware (with client proxy) * Fix else	2025-07-14 20:13:34 -05:00
Jonathan Bennett	4feaec651f	Unify the native display config between legacy display and MUI (#6838) ... * Add missed include * Another Warning fix * Add another HAS_SCREEN * Namespace fixes * Removed depricated destination types and re-factored destination screen * Get rid of Arduino Strings * Clean up after Copilot * SixthLine Def, Screen Rename Added Sixth Line Definition Screen Rename, and Automatic Line Adjustment * Consistency is hard - fixed "Sixth" * System Frame Updates Adjusted line construction to ensure we fit maximum content per screen. * Fix up notifications * Add a couple more ifdef HAS_SCREEN lines * Add screen->isOverlayBannerShowing() * Don't forget the invert! * Adjust Nodelist Center Divider Adjust Nodelist Center Divider * Fix variable casting * Fix entryText variable as empty before update to fix validation * Altitude is int32_t * Update PowerTelemetry to have correct data type * Fix cppcheck warnings (#6945) * Fix cppcheck warnings * Adjust logic in Power.cpp for power sensor --------- Co-authored-by: Jason P <applewiz@mac.com> * More pixel wrangling so things line up NodeList edition * Adjust NodeList alignments and plumb some background padding for a possible title fix * Better alignment for banner notifications * Move title into drawCommonHeader; initial screen tested * Fonts make spacing items difficult * Improved beeping booping and other buzzer based feedback (#6947) * Improved beeping booping and other buzzer based feedback * audible button feedback (#6949) * Refactor --------- Co-authored-by: todd-herbert <herbert.todd@gmail.com> * Sandpapered the corners of the notification popup * Finalize drawCommonHeader migration * Update Title of Favorite Node Screens * Update node metric alignment on LoRa screen * Update the border for popups to separate it from background * Update PaxcounterModule.cpp with CommonHeader * Update WiFi screen with CommonHeader and related data reflow * It was not, in fact, pointing up * Fix build on wismeshtap * T-deck trackball debounce * Fix uptime on Device Focused page to actually detail * Update Sys screen for new uptime, add label to Freq/Chan on LoRa * Don't display DOP any longer, make Uptime consistent * Revert Uptime change on Favorites, Apply to Device Focused * Label the satelite number to avoid confusion * Boop boop boop boop * Correct GPS positioning and string consistency across strings for GPS * Fix GPS text alignment * Enable canned messages by default * Don't wake screen on new nodes * Cannedmessage list emote support added * Fn+e emote picker for freetext screen * Actually block CannedInput actions while display is shown * Add selection menu to bannerOverlay * Off by one * Move to unified text layouts and spacing * Still my Fav without an "e" * Fully remove EVENT_NODEDB_UPDATED * Simply LoRa screen * Make some char pointers const to fix compilation on native targets * Update drawCompassNorth to include radius * Fix warning * button thread cleanup * Pull OneButton handling from PowerFSM and add MUI switch (#6973) * Trunk * Onebutton Menu Support * Add temporary clock icon * Add gps location to fsi * Banner message state reset * Cast to char to satisfy compiler * Better fast handling of input during banner * Fix warning * Derp * oops * Update ref * Wire buzzer_mode * remove legacy string->print() * Only init screen if one found * Unsigned Char * More buttonThread cleaning * screen.cpp button handling cleanup * The Great Event Rename of 2025 * Fix the Radiomaster * Missed trackball type change * Remove unused function * Make ButtonThread an InputBroker * Coffee hadn't kicked in yet * Add clock icon for Navigation Bar * Restore clock screen definition code - whoops * ExternalNotifications now observe inputBroker * Clock rework (#6992) * Move Clock bits into ClockRenderer space * Rework clock into all device navigation * T-Watch Actually Builds Different * Compile fix --------- Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz> * Add AM/PM to Digital Clock * Flip Seconds and AM/PM on Clock Display * Tik-tok pixels are hard * Fix builds on Thinknode M1 * Check for GPS and don't crash * Don't endif til the end * Rework the OneButton thread to be much less of a mess. (#6997) * Rework the OneButton thread to be much less of a mess. And break lots of targets temporarily * Update src/input/ButtonThread.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix GPS toggle * Send the shutdown event, not just the kbchar * Honor the back button in a notificaiton popup * Draw the right size box for popup with options * Try to un-break all the things --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * 24-hour Clock Should have leading zero, but not 12-hour * Fixup some compile errors * Add intRoutine to ButtonThread init, to get more responsive user button back * Add Timezone picker * Fix Warning * Optionally set the initial selection for the chooser popup * Make back buttons work in canned messages * Drop the wrapper classes * LonPressTime now configurable * Clock Frame can not longer be blank; just add valid time * Back buttons everywhere! * Key Verification confirm banner * Make Elecrow M* top button a back button * Add settings saves * EInk responsiveness fixes * Linux Input Fixes * Add Native Trackball/Joystick support, and move UserButton to Input * No Flight Stick Mode * Send input event * Add Channel Utilization to Device Focused frame * Don't shift screens when we draw new ones * Add showOverlayBanner arguments to no-op * trunk * Default Native trackball to NC * Fix crash in simulator mode * Add longLong button press * Get the args right * Adjust Bluetooth Pairing Screen to account for bottom navigation. * Trackball everywhere, and unPhone buttons * Remap visionmaster secondary button to TB_UP * Kill ScanAndSelect * trunk * No longer need the canned messages input filter * All Canned All the time * Fix stm32 compile error regarding inputBroker * Unify tft lineheights (#7033) * Create variable line heights based upon SCREEN_HEIGHT * Refactor textPositions into method -> getTextPositions * Update SharedUIDisplay.h --------- Co-authored-by: Jason P <applewiz@mac.com> * Adjust top distance for larger displays * Adjust icon sizes for larger displays * Fix Paxcounter compile errors after code updates * Pixel wrangling to make larger screens fit better * Alert frame has precedence over banner -- for now * Unify on ALT_BUTTON * Align AM/PM to the digit, not the segment on larger displays * Move some global pin defines into configuration.h * Scaffolding for BMM150 9-axis gyro * Alt button behavior * Don't add the blank GPS frames without HAS_GPS * EVENT_NODEDB_UPDATED has been retired * Clean out LOG_WARN messages from debugging * Add dismiss message function * Minor buttonThread cleanup * Add BMM150 support * Clean up last warning from dev * Simplify bmm150 init return logic * Add option to reply to messages * Add minimal menu upon selecting home screen * Move Messages to slot 2, rename GPS to Position, move variables nearer functional usage in Screen.cpp * Properly dismiss message * T-Deck Trackball press is not user button * Add select on favorite frame to launch cannedMessage DM * Minor wording change * Less capital letters * Fix empty message check, time isn't reliable * drop dead code * Make UIRenderer a static class instead of namespace * Fix the select on favorite * Check if message is empty early and then 'return' * Add kb_found, and show the option to launch freetype if appropriate * Ignore impossible touchscreen touches * Auto scroll fix * Move linebreak after "from" for banners to maximize screen usage. * Center "No messages to show" on Message frame * Start consolidating buzzer behavior * Fixed signed / unsigned warning * Cast second parameter of max() to make some targets happy * Cast kbchar to (char) to make arduino string happy * Shorten the notice of "No messages" * Add buzzer mode chooser * Add regionPicker to Lora icon * Reduce line spacing and reorder Position screen to resolve overlapping issues * Update message titles, fix GPS icons, add Back options * Leftover boops * Remove chirp * Make the region selection dismissable when a region is already set * Add read-aloud functionality on messages w/ esp8266sam * "Last Heard" is a better label * tweak the beep * 5 options * properly tear down freetext upon cancel * de-convelute canned messages just a bit * Correct height of Mail icon in navigation bar * Remove unused warning * Consolidate time methods into TimeFormatters * Oops * Change LoRa Picker Cancel to Back * Tweak selection characters on Banner * Message render not scrolling on 5th line * More fixes for message scrolling * Remove the safety next on text overflow - we found that root cause * Add pin definitions to fix compilation for obscure target * Don't let the touchscreen send unitialized kbchar values * Make virtual KB just a bit quicker * No more double tap, swipe! * Left is left, and Right is right * Update horizontal lightning bolt design * Move from solid to dashed separator for Message Frame * Single emote feature fix * Manually sort overlapping elements for now * Freetext and clearer choices * Fix ESP32 InkHUD builds on the unify-tft branch (#7087) * Remove BaseUI branding * Capitalization is fun * Revert Meshtastic Boot Frame Changes * Add ANZ_433 LoRa region to picker * Update settings.json --------- Co-authored-by: HarukiToreda <116696711+HarukiToreda@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Jason P <applewiz@mac.com> Co-authored-by: todd-herbert <herbert.todd@gmail.com> Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2025-06-21 06:36:04 -05:00
Chloe Bethel	4e6418b635	Don't use assert() with side effects in a couple more places (#7009) ... * Don't use assert for Lock * Don't use assert for MQTT messages * Split assert in getMacAddr to always run the function --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2025-06-12 19:55:35 -05:00
Ben Meadors	beba1b4882	Added map report precision bounds (#6862) ... * Added map report precision bounds * Log warning * Precision range should be 12-15 * Missed commit * Update tests * That method was renamed * Removed now-defunct test call * Remove defunct test	2025-05-22 20:33:46 -05:00
Ben Meadors	7cffd9ba70	Added new map report opt-in for compliance and limit map report (and default) to one hour (#6813) ... * Added new map report opt-in for compliance and limit map report (and default) to one hour * Trunk	2025-05-14 15:31:28 -05:00
Austin	f16402dec1	MQTT userprefs (#6802)	2025-05-14 13:39:46 -05:00
Ben Meadors	040a34fca8	Switch to actually maintained thingsboard pubsubclient (#5204) ... * Switch to actually maintained thingsboard pubsubclient * .0 * TBPubSubClient * SetBufferSize is split into Send and Receive. * Update TBPubSubClient to 2.11 * Update platformio.ini Co-authored-by: Austin <vidplace7@gmail.com> * Re-add setBufferSize fix --------- Co-authored-by: Tom Fifield <tom@tomfifield.net> Co-authored-by: Austin <vidplace7@gmail.com>	2025-04-15 10:50:24 -05:00
Ben Meadors	dc100e4d3e	Cleanup	2025-03-16 08:19:46 -05:00
Thomas Göttgens	1640fb105d	new device: Lilygo T-Eth-Elite (#6321)	2025-03-15 14:15:35 +01:00
Eric Severance	3b0232de1b	Validate MQTT config by testing a connection (#6076)	2025-02-17 15:03:44 -06:00
Eric Severance	7648391f91	Reject invalid configuration for the default MQTT server (#6066) ... * Sanity check configuration for the default MQTT server * Skip for MESHTASTIC_EXCLUDE_MQTT --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2025-02-16 07:15:30 -06:00
Eric Severance	50b7d6a0f7	Establish MQTT connection only from MQTT::runOnce (#6057) ... Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2025-02-14 20:32:41 -06:00
Eric Severance	c83ffd4911	Consider the MQTT TLS remote IP when enabled. (#6058)	2025-02-14 19:19:50 -06:00
Jason P	cd8592ef4a	Fixes #5766 Updated MQTT privateCidrRanges to add Tailscale (#5957)	2025-01-29 06:14:43 -06:00
Eric Severance	27fbfd03d6	Add unit tests for MQTT (#5724) ... * Add unit tests for MQTT * Test received fields	2025-01-07 07:10:42 -06:00
isseysandei	66a961cb75	increased buffer size to 1024 (#5733)	2025-01-03 11:35:34 -06:00
Eric Severance	9f7cbf1b4f	MQTT unit test can inject WiFiClient (#5716)	2025-01-02 19:32:39 +08:00
Eric Severance	c2c06ed0ad	Move DecodedServiceEnvelope into its own file (#5715)	2025-01-02 08:40:14 +08:00
Tom Fifield	e45c0e4d40	Minor cppcheck fixes (#5689) ... * In graphics/Screen.cpp, a copy/paste error to do with hearts * In mesh/http/ContentHandler.cpp, an unused variable * in mqtt/MQTT.cpp, remove unneded logic " '!A || (A && B)' is equivalent to '!A || B'"	2024-12-28 18:56:05 -06:00
GUVWAF	b12aa3f360	Unset received SNR/RSSI values upon receiving packet via MQTT (#5668)	2024-12-26 20:49:06 +11:00
Eric Severance	a7d9e8107a	More accurately determine if MQTT uses the default server (#5663) ... * More accurately determine if MQTT uses the default server * Channels::anyMqttEnabled() uses same logic * Remove previous static bool	2024-12-25 08:33:53 -06:00
Eric Severance	143e1d1a0d	Check if MQTT remote IP is private (#5647) ... Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-12-23 09:48:07 -06:00
Eric Severance	2fd5a4848a	Separate host:port before checking for private IP (x2) (#5643)	2024-12-21 14:07:20 -06:00
Ben Meadors	fb7866fca7	Revert "Check if MQTT remote IP is private (#5627)" (#5636) ... This reverts commit 9a10907a2d.	2024-12-21 07:49:25 -06:00
Ben Meadors	d9b287880f	Revert "Separate host/port before checking for private IP (#5630)" (#5635) ... This reverts commit 398d29064e.	2024-12-21 07:48:47 -06:00
Ben Meadors	f39a9c5083	Clean up some straggler NRF52 json (#5628)	2024-12-21 14:42:54 +11:00
Eric Severance	398d29064e	Separate host/port before checking for private IP (#5630)	2024-12-21 14:06:01 +11:00
Eric Severance	9a10907a2d	Check if MQTT remote IP is private (#5627)	2024-12-20 19:25:31 -06:00
Eric Severance	58d80b8557	Use IPAddress.fromString for parsing private IPs (#5621)	2024-12-21 11:21:27 +11:00
Eric Severance	658459aaf3	Use encoded ServiceEnvelope in mqttQueue (#5619)	2024-12-20 14:59:23 -06:00
Eric Severance	8c6eec52f2	Refactor MQTT::onReceive to reduce if/else nesting (#5592) ... * Refactor MQTT::onReceive to reduce if/else nesting * Fix missing #include <functional> * const DecodedServiceEnvelope e * Combine validDecode if statement. * Only call pb_release when validDecode. * s/ptr/channelName/ * Use reference type for deleter * Use lambda instead of bind * Document deleter * Reorder 'if's to avoid object creation * Remove unnecessary comment * Remove 'else'; simpifies #5516 --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-12-19 05:47:46 -06:00
Tomas Dubec	7c2b6778cb	enable MQTT with TLS on RPi picow (#5442) ... Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-11-25 06:12:19 -06:00
César de Tassis Filho	37da78919a	Fix memory leaks by adding missing free() calls before early returns in MQTT::onReceive (#5439) ... This fix addresses memory leaks in the `MQTT::onReceive` function by ensuring that dynamically allocated resources (`e.channel_id`, `e.gateway_id` and `e.packet`) are properly freed before each early return. Previously, these resources were only freed at the end of the function, leaving them unhandled in certain exit paths. Adding the missing `free()` calls prevents memory leaks and ensures proper resource cleanup in all scenarios.	2024-11-25 12:05:06 +08:00
Ben Meadors	f5058a9cbb	Check for OkToMqtt flag presence before uplinking to MQTT (#5413) ... * Check for oktomqtt flag presence before uplinking to MQTT * Move to mqtt->onSend	2024-11-21 14:52:54 -06:00
GUVWAF	9b4c260a92	Fix memory leak in MQTT (#5311)	2024-11-11 13:22:22 +01:00
Ben Meadors	f769c50fa5	More reduction (#5256) ... * Now with even fewer ings * Ye * Mo * QMA6100PSensor	2024-11-04 19:15:59 -06:00
Ben Meadors	50dac38a1b	Pass#2: Lots more savings in logs and string reduction surgery (#5251) ... * Pass#2: Lots more savings in logs and string reduction surgery * Don't need Thread suffix either * Warn	2024-11-04 12:16:25 -06:00
Tom Fifield	276067065e	Log cleanups (#5135) ... * Log cleanups change log levels, shorten log messages, delete commented out logs * Address comments from review * Remove full stops * EDEBUG --> DEBUG	2024-11-04 06:09:23 -06:00
Thomas Göttgens	93318b4f56	T1000-E Peripherals (#5141) ... * T1000-E Peripherals - enable intelligent charge controller signals - enable Accelerometer - enable internal I2C bus - provide Power to Accelerometer * POC Accelerometer Code (wakeScreen is moot for that device, just test if the driver works) * fix building without the sensor	2024-10-26 12:03:28 +02:00
Robert	a4705d2c19	add RFC 3927 IP address space to private IP checks (#5115) ... Add the RFC 3927 IP address block (169.254.0.0/16), also referred to as IPIPA, to the private address checks for MQTT functionality.	2024-10-21 19:25:27 +11:00
Johnathon Mohr	fbb6778415	Account for port specification with IP address for MQTT server. Some additional format validation. (#5084)	2024-10-17 05:05:35 -05:00
Johnathon Mohr	3e5f129fce	Ensure the MQTT address is an IPv4 before determining it's private (#5081) ... * Ensure the mqtt address is an IPv4 (or at least not a domain) before determining it's private. * check address length	2024-10-16 05:19:00 -05:00
Johnathon Mohr	ad214ea42a	Add MQTT exception for private IP address server (#5072) ... Determines if the given IP address is a private address, i.e. not routable on the public internet. These are the ranges: 127.0.0.1, 10.0.0.0-10.255.255.255, 172.16.0.0-172.31.255.255, 192.168.0.0-192.168.255.255. If so, allow MQTT publication the same as existing localhost support.	2024-10-16 11:08:49 +11:00
Thomas Göttgens	05e4a639a1	remove newline from logging statements. (#5022) ... remove newline from logging statements in code. The LOG_* functions will now magically add it at the end. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>	2024-10-14 15:11:43 +11:00
GUVWAF	d55c08d5cd	Uplink DMs not to us if MQTT encryption enabled (#5025) ... * Uplink DMs not to us if MQTT encryption enabled * Only really need to try uplinking encrypted packet if MQTT encryption is enabled * Add log about publishing nothing when packet is not decrypted and encryption_enabled is false * Improve comment	2024-10-10 15:11:58 -05:00